Comment updates

Update user help format insert macro

Added additional message in help text to let user know each
dword must start with a 0x. Added a macro to handle the max
amount of dwords per TLP request.

Added check for dwords

Added an additional check and error message to
ensure that nothing greater than a dword is sent
in each section of the tlp.

Convert host byte order to le byte order

Author: BenReed161

cli/diag.c

@@ -65,6 +65,8 @@ struct diag_common_cfg {
 	"return the data for the previous link",			\
 }
 
+#define TLP_MAX_DWS 132
+
 static int get_port(struct switchtec_dev *dev, int port_id,
 		    struct switchtec_status *port)
 {
@@ -2030,13 +2032,21 @@ static int convert_str_to_dwords(char *str, uint32_t **dwords, int *num_dwords)
 {
 	*num_dwords = 0;
 	const char *ptr = str;
+	int dword_len = 0;
 	while (*ptr != '\0') {
 		if (*ptr == '0' && *(ptr + 1) == 'x') {
 			(*num_dwords)++;
 			ptr += 2;
+			dword_len = 0;
 		}
-		while (*ptr != ' ' && *ptr != '\0')
+		while (*ptr != ' ' && *ptr != '\0') {
 			ptr++;
+			dword_len++;
+		}
+		if (dword_len > 8) {
+			printf("Entered dword longer than allowed\n");
+			return -1;
+		}
 		if (*ptr == ' ')
 			ptr++;
 	}
@@ -2088,7 +2098,7 @@ static int tlp_inject (int argc, char **argv)
 			"Enable the ecrc to be included at the end of the input data (Default: disabled)"},
 		{"tlp_data", 'd', "\"DW0 DW1 ... DW131\"", CFG_STRING, 
 			&cfg.raw_tlp_data, required_argument, 
-			"DWs to be sent as part of the raw TLP (Maximum 132 DWs)"},
+			"DWs to be sent as part of the raw TLP (Maximum 132 DWs). Every DW must start with \'0x\'"},
 		{NULL}
 	};
 
@@ -2104,8 +2114,8 @@ static int tlp_inject (int argc, char **argv)
 		fprintf(stderr, "Error with tlp data provided \n");
 		return -1;
 	}
-	if (num_dwords > 132) {
-		fprintf(stderr, "TLP data cannot exceed 132 dwords \n");
+	if (num_dwords > TLP_MAX_DWS) {
+		fprintf(stderr, "TLP data cannot exceed %d dwords \n", TLP_MAX_DWS);
 		free(raw_tlp_dwords);
 		return -1;
 	}

lib/diag.c

@@ -1227,7 +1227,7 @@ int switchtec_tlp_inject(struct switchtec_dev * dev, int port_id, int tlp_type,
 	};
 	for (int i = 0; i < tlp_in.tlp_length; i++)
 	{
-		tlp_in.raw_tlp_data[i] = *(raw_tlp_data + i);
+		tlp_in.raw_tlp_data[i] = htole32(*(raw_tlp_data + i));
 	}
 	free(raw_tlp_data);