Skip to content

Conversation

NAO-MSFT
Copy link

@NAO-MSFT NAO-MSFT commented Aug 7, 2025

as per sr# 2408260040006818 and other support requests, it's better to make this clear.

as per sr# 2408260040006818 and other support requests, it's better to make this clear.
Copy link
Contributor

@NAO-MSFT : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit f20c6f6:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-machines/dedicated-host-memory-optimized-skus.md ✅Succeeded

For more details, please refer to the build report.

@v-dirichards
Copy link
Contributor

@vamckMS

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Aug 7, 2025
@vamckMS
Copy link

vamckMS commented Aug 7, 2025

@v-dirichards I am no longer the PM for ADH hence I am not the owner for these docs. @TravisCragg-MSFT is the new owner.

@v-dirichards
Copy link
Contributor

v-dirichards commented Aug 7, 2025

@vamckMS Thanks for letting us know.

@TravisCragg-MSFT Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

Thanks!
#assign: @TravisCragg-MSFT
#unassign: @vamckMS

@v-dirichards
Copy link
Contributor

@TravisCragg-MSFT Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

Thanks!

@NAO-MSFT
Copy link
Author

@v-dirichards, is this still under the review?

@v-regandowner
Copy link
Contributor

@NAO-MSFT - We're waiting on approval (in the form of a sign-off comment or approving review) from the owner of this content @TravisCragg-MSFT before we can merge.

@NAO-MSFT
Copy link
Author

NAO-MSFT commented Sep 5, 2025

I want to publish this somehow...

@ttorble
Copy link
Contributor

ttorble commented Sep 5, 2025

@NAO-MSFT

Because this PR was created in the public repo, only the listed author @TravisCragg-MSFT can sign off on updates. You can wait for approval from the author or you can close this PR and make the change in the private repo azure-compute-docs-pr.

Read about authors working in the public repo for more information. Note that access to the contributor guide changed recently. See this thread in the Learn support channel in Teams for more information.

If you need help getting set up to work in the private repo, see Get started contributing to the Microsoft Learn platform.

After you make your changes in the private repo, review the articles on staging, and fix any validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged. 

Thanks

@TravisCragg-MSFT
Copy link
Member

@NAO-MSFT This is part of a larger change we need to make within ADH, but I am fine with this going through to help short-term.

@TravisCragg-MSFT
Copy link
Member

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @vamckMS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants