-
Notifications
You must be signed in to change notification settings - Fork 259
Update dedicated-host-memory-optimized-skus.md #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
as per sr# 2408260040006818 and other support requests, it's better to make this clear.
@NAO-MSFT : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit f20c6f6: ✅ Validation status: passed
For more details, please refer to the build report. |
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
@v-dirichards I am no longer the PM for ADH hence I am not the owner for these docs. @TravisCragg-MSFT is the new owner. |
@vamckMS Thanks for letting us know. @TravisCragg-MSFT Could you review this proposed update to your article and enter Thanks! |
@TravisCragg-MSFT Could you review this proposed update to your article and enter Thanks! |
@v-dirichards, is this still under the review? |
@NAO-MSFT - We're waiting on approval (in the form of a sign-off comment or approving review) from the owner of this content @TravisCragg-MSFT before we can merge. |
I want to publish this somehow... |
Because this PR was created in the public repo, only the listed author @TravisCragg-MSFT can sign off on updates. You can wait for approval from the author or you can close this PR and make the change in the private repo Read about authors working in the public repo for more information. Note that access to the contributor guide changed recently. See this thread in the Learn support channel in Teams for more information. If you need help getting set up to work in the private repo, see Get started contributing to the Microsoft Learn platform. After you make your changes in the private repo, review the articles on staging, and fix any validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged. Thanks |
@NAO-MSFT This is part of a larger change we need to make within ADH, but I am fine with this going through to help short-term. |
#sign-off |
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @vamckMS |
as per sr# 2408260040006818 and other support requests, it's better to make this clear.