Skip to content

Commit 03a8af1

Browse files
committed
acrolinx
1 parent 7a14f96 commit 03a8af1

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

articles/application-gateway/ingress-controller-install-existing.md

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ The zip file you downloaded contains JSON templates, bash, and PowerShell script
4040
Gateway should that become necessary
4141

4242
## Install Helm
43-
[Helm](../aks/kubernetes-helm.md) is a package manager for Kubernetes. This is used to install the `application-gateway-kubernetes-ingress` package.
43+
[Helm](../aks/kubernetes-helm.md) is a package manager for Kubernetes, used to install the `application-gateway-kubernetes-ingress` package.
4444
Use [Cloud Shell](https://shell.azure.com/) to install Helm:
4545

4646
1. Install [Helm](../aks/kubernetes-helm.md) and run the following to add `application-gateway-kubernetes-ingress` helm package:
@@ -83,15 +83,15 @@ Next we need to create an Azure identity and give it permissions ARM.
8383
Use [Cloud Shell](https://shell.azure.com/) to run all of the following commands and create an identity:
8484

8585
1. Create an Azure identity **in the same resource group as the AKS nodes**. Picking the correct resource group is
86-
important. The resource group required in the command below is *not* the one referenced on the AKS portal pane. This is
86+
important. The resource group required in the following commands is *not* the one referenced on the AKS portal pane. This is
8787
the resource group of the `aks-agentpool` virtual machines. Typically that resource group starts with `MC_` and contains
8888
the name of your AKS. For instance: `MC_resourceGroup_aksABCD_westus`
8989

9090
```azurecli
9191
az identity create -g <agent-pool-resource-group> -n <identity-name>
9292
```
9393

94-
1. For the role assignment commands below we need to obtain `principalId` for the newly created identity:
94+
1. For the role assignment, commands we need to obtain `principalId` for the newly created identity:
9595

9696
```azurecli
9797
az identity show -g <resourcegroup> -n <identity-name>
@@ -151,7 +151,7 @@ In the first few steps, we install Helm's Tiller on your Kubernetes cluster. Use
151151
```bash
152152
wget https://raw.githubusercontent.com/Azure/application-gateway-kubernetes-ingress/master/docs/examples/sample-helm-config.yaml -O helm-config.yaml
153153
```
154-
Or copy the YAML file below:
154+
Or copy the following YAML file:
155155

156156
```yaml
157157
# This file contains the essential configs for the ingress controller helm chart
@@ -244,9 +244,9 @@ Refer to [this how-to guide](ingress-controller-expose-service-over-http-https.m
244244
## Shared Application Gateway
245245
By default AGIC assumes full ownership of the Application Gateway it's linked to. AGIC version 0.8.0 and later can
246246
share a single Application Gateway with other Azure components. For instance, we could use the same Application Gateway for an app
247-
hosted on Virtual Machine Scale Set as well as an AKS cluster.
247+
hosted on Virtual Machine Scale Set and an AKS cluster.
248248
249-
Please __backup your Application Gateway's configuration__ before enabling this setting:
249+
**Backup your Application Gateway's configuration** before enabling this setting:
250250
1. using [Azure portal](https://portal.azure.com/) navigate to your `Application Gateway` instance
251251
2. from `Export template` click `Download`
252252

@@ -312,13 +312,12 @@ kubectl get AzureIngressProhibitedTargets prohibit-all-targets -o yaml
312312
```
313313
314314
The object `prohibit-all-targets`, as the name implies, prohibits AGIC from changing config for *any* host and path.
315-
Helm install with `appgw.shared=true` deploys AGIC, but won't make any changes to Application Gateway.
315+
Helm install with `appgw.shared=true` deploys AGIC, but doesn't make any changes to Application Gateway.
316316

317317

318318
### Broaden permissions
319-
Since Helm with `appgw.shared=true` and the default `prohibit-all-targets` blocks AGIC from applying a config.
319+
Since Helm with `appgw.shared=true` and the default `prohibit-all-targets` blocks AGIC from applying a config, broaden AGIC permissions:
320320

321-
Broaden AGIC permissions with:
322321
1. Create a new `AzureIngressProhibitedTarget` with your specific setup:
323322
```bash
324323
cat <<EOF | kubectl apply -f -

0 commit comments

Comments
 (0)