Skip to content

Commit 03cb3f2

Browse files
authored
Merge pull request #105496 from zr-msft/ds-fix-ingress-confusion
[Dev Spaces] updated text to reduce confusion for custom ingress
2 parents 7d36f25 + c10e14e commit 03cb3f2

File tree

2 files changed

+20
-3
lines changed

2 files changed

+20
-3
lines changed

articles/dev-spaces/how-to/ingress-https-nginx.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,11 @@ git clone https://github.com/Azure/dev-spaces
9191
cd dev-spaces/samples/BikeSharingApp/charts
9292
```
9393

94-
Open [values.yaml][values-yaml] and replace all instances of *<REPLACE_ME_WITH_HOST_SUFFIX>* with *nginx.MY_CUSTOM_DOMAIN* using your domain for *MY_CUSTOM_DOMAIN*. Also replace *kubernetes.io/ingress.class: nginx-azds # Dev Spaces-specific* with *kubernetes.io/ingress.class: nginx # Custom Ingress*. Below is an example of an updated `values.yaml` file:
94+
Open [values.yaml][values-yaml] and make the following updates:
95+
* Replace all instances of *<REPLACE_ME_WITH_HOST_SUFFIX>* with *nginx.MY_CUSTOM_DOMAIN* using your domain for *MY_CUSTOM_DOMAIN*.
96+
* Replace *kubernetes.io/ingress.class: traefik-azds # Dev Spaces-specific* with *kubernetes.io/ingress.class: nginx # Custom Ingress*.
97+
98+
Below is an example of an updated `values.yaml` file:
9599

96100
```yaml
97101
# This is a YAML-formatted file.
@@ -145,6 +149,9 @@ http://dev.gateway.nginx.MY_CUSTOM_DOMAIN/ Available
145149

146150
Navigate to the *bikesharingweb* service by opening the public URL from the `azds list-uris` command. In the above example, the public URL for the *bikesharingweb* service is `http://dev.bikesharingweb.nginx.MY_CUSTOM_DOMAIN/`.
147151

152+
> [!NOTE]
153+
> If you see an error page instead of the *bikesharingweb* service, verify you updated **both** the *kubernetes.io/ingress.class* annotation and the host in the *values.yaml* file.
154+
148155
Use the `azds space select` command to create a child space under *dev* and list the URLs to access the child dev space.
149156

150157
```console

articles/dev-spaces/how-to/ingress-https-traefik.md

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,12 @@ helm repo add stable https://kubernetes-charts.storage.googleapis.com/
4444

4545
Create a Kubernetes namespace for the traefik ingress controller and install it using `helm`.
4646

47+
> [!NOTE]
48+
> If your AKS does not have RBAC enabled, remove the *--set rbac.enabled=true* parameter.
49+
4750
```console
4851
kubectl create ns traefik
49-
helm install traefik stable/traefik --namespace traefik --set kubernetes.ingressClass=traefik --set kubernetes.ingressEndpoint.useDefaultPublishedService=true --version 1.85.0
52+
helm install traefik stable/traefik --namespace traefik --set kubernetes.ingressClass=traefik --set rbac.enabled=true --set fullnameOverride=customtraefik --set kubernetes.ingressEndpoint.useDefaultPublishedService=true --version 1.85.0
5053
```
5154

5255
> [!NOTE]
@@ -90,7 +93,11 @@ git clone https://github.com/Azure/dev-spaces
9093
cd dev-spaces/samples/BikeSharingApp/charts
9194
```
9295

93-
Open [values.yaml][values-yaml] and replace all instances of *<REPLACE_ME_WITH_HOST_SUFFIX>* with *traefik.MY_CUSTOM_DOMAIN* using your domain for *MY_CUSTOM_DOMAIN*. Also replace *kubernetes.io/ingress.class: traefik-azds # Dev Spaces-specific* with *kubernetes.io/ingress.class: traefik # Custom Ingress*. Below is an example of an updated `values.yaml` file:
96+
Open [values.yaml][values-yaml] and make the following updates:
97+
* Replace all instances of *<REPLACE_ME_WITH_HOST_SUFFIX>* with *traefik.MY_CUSTOM_DOMAIN* using your domain for *MY_CUSTOM_DOMAIN*.
98+
* Replace *kubernetes.io/ingress.class: traefik-azds # Dev Spaces-specific* with *kubernetes.io/ingress.class: traefik # Custom Ingress*.
99+
100+
Below is an example of an updated `values.yaml` file:
94101

95102
```yaml
96103
# This is a YAML-formatted file.
@@ -144,6 +151,9 @@ http://dev.gateway.traefik.MY_CUSTOM_DOMAIN/ Available
144151

145152
Navigate to the *bikesharingweb* service by opening the public URL from the `azds list-uris` command. In the above example, the public URL for the *bikesharingweb* service is `http://dev.bikesharingweb.traefik.MY_CUSTOM_DOMAIN/`.
146153

154+
> [!NOTE]
155+
> If you see an error page instead of the *bikesharingweb* service, verify you updated **both** the *kubernetes.io/ingress.class* annotation and the host in the *values.yaml* file.
156+
147157
Use the `azds space select` command to create a child space under *dev* and list the URLs to access the child dev space.
148158

149159
```console

0 commit comments

Comments
 (0)