Skip to content

Commit 0732095

Browse files
committed
Addressing PR feedback
1 parent d17b291 commit 0732095

File tree

6 files changed

+24
-24
lines changed

6 files changed

+24
-24
lines changed

articles/communication-services/quickstarts/email/includes/manage-suppression-list-java.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ ms.custom: mode-other
1616
- An Azure account with an active subscription. [Create an account for free](https://azure.microsoft.com/free/dotnet/).
1717
- An Azure Email Communication Services Resource ready to provision domains. [Get started creating an Email Communication Resource](../create-email-communication-resource.md).
1818
- An [Azure Managed Domain](../add-azure-managed-domains.md) or [Custom Domain](../add-custom-verified-domains.md) provisioned and ready to send emails.
19-
- We're using a [service principal for authentication](../../../../active-directory/develop/howto-create-service-principal-portal.md). Set the values of the client ID, tenant ID, and client secret of the AAD application as the following environment variables: `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_CLIENT_SECRET`.
19+
- We're using a [service principal for authentication](../../../../active-directory/develop/howto-create-service-principal-portal.md). Set the values of the client ID, tenant ID, and client secret of the Azure Active Directory (AD) application as the following environment variables: `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_CLIENT_SECRET`.
2020

2121
## Install the required packages
2222

@@ -66,7 +66,7 @@ CommunicationManager manager = CommunicationManager
6666

6767
To block your email messages from being sent to certain addresses, the first step is setting up a suppression list in your domain resource.
6868

69-
Update the code sample with the resource group name, the email service name, and the domain resource name for which you would like to create the suppression list. This information can be found in portal by navigating to the domains resource you created when setting up the prerequisites. The title of the resource is `<your-email-service-name>/<your-domain-name>`. The resource group name and subscription ID can be found in the Essentials sections in the domain resource overview. Choose any name for your suppression list resource and update that field in the sample as well.
69+
Update the code sample with the resource group name, the email service name, and the domain resource name for which you would like to create the suppression list. Find this information in the portal by navigating to the domain resource you created when setting up the prerequisites. The title of the resource is `<your-email-service-name>/<your-domain-name>`. Find the resource group name and subscription ID in the Essentials sections in the domain resource overview. Choose any name for your suppression list resource and update that field in the sample as well.
7070

7171
For the list name, make sure it's the same as the sender username of the MailFrom address you would like to suppress emails from. These MailFrom addresses can be found in the "MailFrom addresses" section of your domain resource in the portal. For example, you may have a MailFrom address that looks like "[email protected]". The sender username for this address would be "donotreply" so a list name of "donotreply" should be used.
7272

@@ -95,7 +95,7 @@ manager.suppressionLists().define(suppressionListResourceName)
9595

9696
After setting up the suppression list, you can now add specific email addresses to which you wish to prevent your email messages from being sent.
9797

98-
Update the code sample with the suppression list address ID. Every suppression list address ID you add needs to be unique, so using a GUID is recommended. Update the email address you want to block from receiving your messages as well.
98+
Update the code sample with the suppression list address ID. Every suppression list address ID you add needs to be unique. We recommend using a GUID. Update the email address you want to block from receiving your messages as well.
9999

100100
To add multiple addresses to the suppression list, you need to repeat this code sample multiple times.
101101

@@ -123,9 +123,9 @@ manager.suppressionListAddresses()
123123

124124
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource or by using one of the Email SDKs](../send-email.md). Make sure to send the email using the MailFrom address with the sender username you choose to suppress. Your email will successfully send to the previously suppressed address.
125125

126-
## Remove a suppression list from a domains resource
126+
## Remove a suppression list from a domain resource
127127

128-
Call the `delete` method on `suppressionLists` to remove a suppression list from the domains resource.
128+
Call the `delete` method on `suppressionLists` to remove a suppression list from the domain resource.
129129

130130
```java
131131
manager.suppressionLists()

articles/communication-services/quickstarts/email/includes/manage-suppression-list-js.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ ms.custom: mode-other
1616
- An Azure account with an active subscription. [Create an account for free](https://azure.microsoft.com/free/dotnet/).
1717
- An Azure Email Communication Services Resource ready to provision domains. [Get started creating an Email Communication Resource](../create-email-communication-resource.md).
1818
- An [Azure Managed Domain](../add-azure-managed-domains.md) or [Custom Domain](../add-custom-verified-domains.md) provisioned and ready to send emails.
19-
- We're using a [service principal for authentication](../../../../active-directory/develop/howto-create-service-principal-portal.md). Set the values of the client ID, tenant ID, and client secret of the AAD application as the following environment variables: `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_CLIENT_SECRET`.
19+
- We're using a [service principal for authentication](../../../../active-directory/develop/howto-create-service-principal-portal.md). Set the values of the client ID, tenant ID, and client secret of the Azure Active Directory (AD) application as the following environment variables: `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_CLIENT_SECRET`.
2020

2121
## Install the required packages
2222

@@ -44,7 +44,7 @@ const client = new CommunicationServiceManagementClient(credential, subscription
4444

4545
To block your email messages from being sent to certain addresses, the first step is setting up a suppression list in your domain resource.
4646

47-
Update the code sample with the resource group name, the email service name, and the domain resource name for which you would like to create the suppression list. This information can be found in portal by navigating to the domains resource you created when setting up the prerequisites. The title of the resource is `<your-email-service-name>/<your-domain-name>`. The resource group name and subscription ID can be found in the Essentials sections in the domain resource overview. Choose any name for your suppression list resource and update that field in the sample as well.
47+
Update the code sample with the resource group name, the email service name, and the domain resource name for which you would like to create the suppression list. Find this information in the portal by navigating to the domain resource you created when setting up the prerequisites. The title of the resource is `<your-email-service-name>/<your-domain-name>`. Find the resource group name and subscription ID in the Essentials sections in the domain resource overview. Choose any name for your suppression list resource and update that field in the sample as well.
4848

4949
For the list name, make sure it's the same as the sender username of the MailFrom address you would like to suppress emails from. These MailFrom addresses can be found in the "MailFrom addresses" section of your domain resource in the portal. For example, you may have a MailFrom address that looks like "[email protected]". The sender username for this address would be "donotreply" so a list name of "donotreply" should be used.
5050

@@ -87,7 +87,7 @@ await client.suppressionLists.createOrUpdate(
8787

8888
After setting up the suppression list, you can now add specific email addresses to which you wish to prevent your email messages from being sent.
8989

90-
Update the code sample with the suppression list address ID. Every suppression list address ID you add needs to be unique, so using a GUID is recommended. Update the email address you want to block from receiving your messages as well.
90+
Update the code sample with the suppression list address ID. Every suppression list address ID you add needs to be unique. We recommend using a GUID. Update the email address you want to block from receiving your messages as well.
9191

9292
To add multiple addresses to the suppression list, you need to repeat this code sample multiple times.
9393

@@ -129,9 +129,9 @@ await client.suppressionListAddresses.delete(
129129

130130
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource or by using one of the Email SDKs](../send-email.md). Make sure to send the email using the MailFrom address with the sender username you choose to suppress. Your email will successfully send to the previously suppressed address.
131131

132-
## Remove a suppression list from a domains resource
132+
## Remove a suppression list from a domain resource
133133

134-
Call the `delete` method on `suppressionList` to remove a suppression list from the domains resource.
134+
Call the `delete` method on `suppressionList` to remove a suppression list from the domain resource.
135135

136136
```javascript
137137
await client.suppressionLists.delete(

articles/communication-services/quickstarts/email/includes/manage-suppression-list-net.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ ms.custom: mode-other
1616
- An Azure account with an active subscription. [Create an account for free](https://azure.microsoft.com/free/dotnet/).
1717
- An Azure Email Communication Services Resource ready to provision domains. [Get started creating an Email Communication Resource](../create-email-communication-resource.md).
1818
- An [Azure Managed Domain](../add-azure-managed-domains.md) or [Custom Domain](../add-custom-verified-domains.md) provisioned and ready to send emails.
19-
- We're using a [service principal for authentication](../../../../active-directory/develop/howto-create-service-principal-portal.md). Set the values of the client ID, tenant ID, and client secret of the AAD application as the following environment variables: `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_CLIENT_SECRET`.
19+
- We're using a [service principal for authentication](../../../../active-directory/develop/howto-create-service-principal-portal.md). Set the values of the client ID, tenant ID, and client secret of the Azure Active Directory (AD) application as the following environment variables: `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_CLIENT_SECRET`.
2020

2121
## Install the required packages
2222

@@ -43,7 +43,7 @@ ArmClient client = new ArmClient(new DefaultAzureCredential());
4343

4444
To block your email messages from being sent to certain addresses, the first step is setting up a suppression list in your domain resource.
4545

46-
Update the code sample with the resource group name, the email service name, and the domain resource name for which you would like to create the suppression list. This information can be found in portal by navigating to the domains resource you created when setting up the prerequisites. The title of the resource is `<your-email-service-name>/<your-domain-name>`. The resource group name and subscription ID can be found in the Essentials sections in the domain resource overview. Choose any name for your suppression list resource and update that field in the sample as well.
46+
Update the code sample with the resource group name, the email service name, and the domain resource name for which you would like to create the suppression list. Find this information in the portal by navigating to the domain resource you created when setting up the prerequisites. The title of the resource is `<your-email-service-name>/<your-domain-name>`. Find the resource group name and subscription ID in the Essentials sections in the domain resource overview. Choose any name for your suppression list resource and update that field in the sample as well.
4747

4848
For the list name, make sure it's the same as the sender username of the MailFrom address you would like to suppress emails from. These MailFrom addresses can be found in the "MailFrom addresses" section of your domain resource in the portal. For example, you may have a MailFrom address that looks like "[email protected]". The sender username for this address would be "donotreply" so a list name of "donotreply" should be used.
4949

@@ -82,7 +82,7 @@ suppressionListResource.Update(WaitUntil.Completed, suppressiontListData);
8282

8383
After setting up the suppression list, you can now add specific email addresses to which you wish to prevent your email messages from being sent.
8484

85-
Update the code sample with the suppression list address ID. Every suppression list address ID you add needs to be unique, so using a GUID is recommended. Update the email address you want to block from receiving your messages as well.
85+
Update the code sample with the suppression list address ID. Every suppression list address ID you add needs to be unique. We recommend using a GUID. Update the email address you want to block from receiving your messages as well.
8686

8787
To add multiple addresses to the suppression list, you need to repeat this code sample multiple times.
8888

@@ -114,9 +114,9 @@ suppressionListAddressResource.Delete(WaitUntil.Completed);
114114

115115
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource or by using one of the Email SDKs](../send-email.md). Make sure to send the email using the MailFrom address with the sender username you choose to suppress. Your email will successfully send to the previously suppressed address.
116116

117-
## Remove a suppression list from a domains resource
117+
## Remove a suppression list from a domain resource
118118

119-
To remove a suppression list from the domains resource, create the `SuppressionListResource` as shown in the previous code samples and call the `Delete` method.
119+
To remove a suppression list from the domain resource, create the `SuppressionListResource` as shown in the previous code samples and call the `Delete` method.
120120

121121
```csharp
122122
suppressionListResource.Delete(WaitUntil.Completed);

articles/communication-services/quickstarts/email/includes/manage-suppression-list-python.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ ms.custom: mode-other
1616
- An Azure account with an active subscription. [Create an account for free](https://azure.microsoft.com/free/dotnet/).
1717
- An Azure Email Communication Services Resource ready to provision domains. [Get started creating an Email Communication Resource](../create-email-communication-resource.md).
1818
- An [Azure Managed Domain](../add-azure-managed-domains.md) or [Custom Domain](../add-custom-verified-domains.md) provisioned and ready to send emails.
19-
- We're using a [service principal for authentication](../../../../active-directory/develop/howto-create-service-principal-portal.md). Set the values of the client ID, tenant ID, and client secret of the AAD application as the following environment variables: `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_CLIENT_SECRET`.
19+
- We're using a [service principal for authentication](../../../../active-directory/develop/howto-create-service-principal-portal.md). Set the values of the client ID, tenant ID, and client secret of the Azure Active Directory (AD) application as the following environment variables: `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_CLIENT_SECRET`.
2020

2121
## Install the required packages
2222

@@ -44,7 +44,7 @@ mgmt_client = CommunicationServiceManagementClient(credential, subscription_id)
4444

4545
To block your email messages from being sent to certain addresses, the first step is setting up a suppression list in your domain resource.
4646

47-
Update the code sample with the resource group name, the email service name, and the domain resource name for which you would like to create the suppression list. This information can be found in portal by navigating to the domains resource you created when setting up the prerequisites. The title of the resource is `<your-email-service-name>/<your-domain-name>`. The resource group name and subscription ID can be found in the Essentials sections in the domain resource overview. Choose any name for your suppression list resource and update that field in the sample as well.
47+
Update the code sample with the resource group name, the email service name, and the domain resource name for which you would like to create the suppression list. Find this information in the portal by navigating to the domain resource you created when setting up the prerequisites. The title of the resource is `<your-email-service-name>/<your-domain-name>`. Find the resource group name and subscription ID in the Essentials sections in the domain resource overview. Choose any name for your suppression list resource and update that field in the sample as well.
4848

4949
For the list name, make sure it's the same as the sender username of the MailFrom address you would like to suppress emails from. These MailFrom addresses can be found in the "MailFrom addresses" section of your domain resource in the portal. For example, you may have a MailFrom address that looks like "[email protected]". The sender username for this address would be "donotreply" so a list name of "donotreply" should be used.
5050

@@ -88,7 +88,7 @@ mgmt_client.suppression_lists.create_or_update(
8888

8989
After setting up the suppression list, you can now add specific email addresses to which you wish to prevent your email messages from being sent.
9090

91-
Update the code sample with the suppression list address ID. Every suppression list address ID you add needs to be unique, so using a GUID is recommended. Update the email address you want to block from receiving your messages as well.
91+
Update the code sample with the suppression list address ID. Every suppression list address ID you add needs to be unique. We recommend using a GUID. Update the email address you want to block from receiving your messages as well.
9292

9393
To add multiple addresses to the suppression list, you need to repeat this code sample multiple times.
9494

@@ -129,9 +129,9 @@ mgmt_client.suppression_list_addresses.delete(
129129

130130
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource or by using one of the Email SDKs](../send-email.md). Make sure to send the email using the MailFrom address with the sender username you've chosen to suppress. Your email will successfully send to the previously suppressed address.
131131

132-
## Remove a suppression list from a domains resource
132+
## Remove a suppression list from a domain resource
133133

134-
Call the `delete` method on `suppression_lists` to remove a suppression list from the domains resource.
134+
Call the `delete` method on `suppression_lists` to remove a suppression list from the domain resource.
135135

136136
```python
137137
mgmt_client.suppression_lists.delete(

articles/communication-services/quickstarts/email/manage-suppression-list-mgmt-sdks.md renamed to articles/communication-services/quickstarts/email/manage-suppression-list-management-sdks.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
---
2-
title: Manage Domain Suppression Lists in Azure Communication Services using the Management Client Libraries
2+
title: Manage domain suppression lists in Azure Communication Services using the management client libraries
33
titleSuffix: An Azure Communication Services quick start guide.
4-
description: Lear about managing Domain Suppression Lists in Azure Communication Services using the Management Client Libraries
4+
description: Learn about managing domain suppression ists in Azure Communication Services using the management client libraries
55
author: yogeshmo
66
manager: koagbakp
77
services: azure-communication-services
88
ms.author: ymohanraj
99
ms.date: 11/21/2023
10-
ms.topic: quickstart
10+
ms.topic: quickstartl
1111
ms.service: azure-communication-services
1212
ms.custom: devx-track-extended-java, devx-track-js, devx-track-python
1313
zone_pivot_groups: acs-js-csharp-java-python

articles/communication-services/toc.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ items:
188188
- name: Add multiple sender addresses with Azure Communication Services Management SDKs
189189
href: quickstarts/email/add-multiple-senders-mgmt-sdks.md
190190
- name: Manage domain suppression lists with Azure Communication Services Management SDKs
191-
href: quickstarts/email/manage-suppression-list-mgmt-sdks.md
191+
href: quickstarts/email/manage-suppression-list-management-sdks.md
192192
- name: Sending emails using SMTP
193193
items:
194194
- name: Setting up SMTP Authentication

0 commit comments

Comments
 (0)