Skip to content

Commit 07bef08

Browse files
Apply suggestions from review
Co-authored-by: Karl Erickson <[email protected]>
1 parent 013e55d commit 07bef08

9 files changed

+36
-23
lines changed

articles/spring-apps/enterprise/how-to-application-insights.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@ Enable the Java In-Process Agent by using the following procedure.
9090
1. Select an existing instance of Application Insights or create a new one.
9191
1. When **Application Insights** is enabled, you can configure one optional sampling rate (default 10.0%).
9292

93-
:::image type="content" source="media/how-to-application-insights/insights-process-agent.png" alt-text="Screenshot of the Azure portal that shows the Azure Spring Apps instance with Enable Application Insights checkbox highlighted." lightbox="media/how-to-application-insights/insights-process-agent.png":::
93+
:::image type="content" source="media/how-to-application-insights/insights-process-agent.png" alt-text="Screenshot of the Azure portal that shows the Application Insights page for Azure Spring Apps with Enable Application Insights checkbox highlighted." lightbox="media/how-to-application-insights/insights-process-agent.png":::
94+
9495

9596
1. Select **Save** to save the change.
9697

articles/spring-apps/enterprise/how-to-circuit-breaker-metrics.md

Lines changed: 22 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -196,23 +196,28 @@ Use the following steps to build and deploy the sample applications.
196196
197197
1. Select **Metrics** in the navigation pane. The **Metrics** page provides dropdown menus and options to define the charts in this procedure. For all charts, set **Metric Namespace** to **azure.applicationinsights**.
198198
199-
:::image type="content" source="media/how-to-circuit-breaker-metrics/chart-menus.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page with Metrics and azure-applicationinsights highlighted." lightbox="media/how-to-circuit-breaker-metrics/chart-menus.png":::
199+
:::image type="content" source="media/how-to-circuit-breaker-metrics/chart-menus.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page with Metric Namespace menu open and azure-applicationinsights option highlighted." lightbox="media/how-to-circuit-breaker-metrics/chart-menus.png":::
200+
200201
201202
1. Set **Metric** to **resilience4j_circuitbreaker_buffered_calls**, and then set **Aggregation** to **Avg**.
202203
203-
:::image type="content" source="media/how-to-circuit-breaker-metrics/buffered-calls.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows the Metric and Aggregation options." lightbox="media/how-to-circuit-breaker-metrics/buffered-calls.png":::
204+
:::image type="content" source="media/how-to-circuit-breaker-metrics/buffered-calls.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows a chart with circuit breaker buffered calls and average aggregation." lightbox="media/how-to-circuit-breaker-metrics/buffered-calls.png":::
205+
204206
205207
1. Set **Metric** to **resilience4j_circuitbreaker_calls**, and then set **Aggregation** to **Avg**.
206208
207-
:::image type="content" source="media/how-to-circuit-breaker-metrics/calls.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows a chart with Metric and Aggregation options." lightbox="media/how-to-circuit-breaker-metrics/calls.png":::
209+
:::image type="content" source="media/how-to-circuit-breaker-metrics/calls.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows a chart with circuit breaker calls and average aggregation." lightbox="media/how-to-circuit-breaker-metrics/calls.png":::
210+
208211
209212
1. Set **Metric** to **resilience4j_circuitbreaker_calls**, and then set **Aggregation** to **Avg**. Select **Add filter** and set **Name** to **Delay**.
210213
211-
:::image type="content" source="media/how-to-circuit-breaker-metrics/calls-filter.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows a chart with Metric, Aggregation, and Filter options." lightbox="media/how-to-circuit-breaker-metrics/calls-filter.png":::
214+
:::image type="content" source="media/how-to-circuit-breaker-metrics/calls-filter.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows a chart with circuit breaker calls, average aggregation and Delay Filter." lightbox="media/how-to-circuit-breaker-metrics/calls-filter.png":::
215+
212216
213217
1. Set **Metric** to **resilience4j_circuitbreaker_calls**, and then set **Aggregation** to **Avg**. Select **Apply splitting** and set **Split by** to **kind**.
214218
215-
:::image type="content" source="media/how-to-circuit-breaker-metrics/calls-splitting.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows a chart with Metric, Aggregation, and Split by options." lightbox="media/how-to-circuit-breaker-metrics/calls-splitting.png":::
219+
:::image type="content" source="media/how-to-circuit-breaker-metrics/calls-splitting.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows a chart with circuit breaker calls, average aggregation, and splitting." lightbox="media/how-to-circuit-breaker-metrics/calls-splitting.png":::
220+
216221
217222
1. Set **Metric** to **resilience4j_circuitbreaker_calls**, and then set **Aggregation** to **Avg**. Select **Add metric** and set **Metric** to **resilience4j_circuitbreaker_buffered_calls**, and then set **Aggregation** to **Avg**. Select **Add metric** again and set **Metric** to **resilience4j_circuitbreaker_slow_calls**, and then set **Aggregation** set to **Avg**.
218223
@@ -225,7 +230,8 @@ Use the following steps to build and deploy the sample applications.
225230
226231
1. In your Azure Spring Apps instance, select **Application Insights** in the navigation pane and then select the default **Application Insights** on the page.
227232
228-
:::image type="content" source="media/how-to-circuit-breaker-metrics/application-insights-enterprise.png" alt-text="Screenshot of the Azure portal that shows the Application Insights page with the Application Insights highlighted." lightbox="media/how-to-circuit-breaker-metrics/application-insights-enterprise.png":::
233+
:::image type="content" source="media/how-to-circuit-breaker-metrics/application-insights-enterprise.png" alt-text="Screenshot of the Azure portal that shows the Azure Spring Apps Application Insights page with the default Application Insights instance highlighted." lightbox="media/how-to-circuit-breaker-metrics/application-insights-enterprise.png":::
234+
229235
230236
> [!NOTE]
231237
> If there's no default Application Insights available, you can enable the Java In-Process agent. For more information, see the [Manage Application Insights using the Azure portal](./how-to-application-insights.md#manage-application-insights-using-the-azure-portal) section of [Use Application Insights Java In-Process Agent in Azure Spring Apps](./how-to-application-insights.md).
@@ -234,23 +240,28 @@ Use the following steps to build and deploy the sample applications.
234240
235241
1. Select **Metrics** in the navigation pane. The **Metrics** page provides dropdown menus and options to define the charts in this procedure. For all charts, set **Metric Namespace** to **azure.applicationinsights**.
236242
237-
:::image type="content" source="media/how-to-circuit-breaker-metrics/chart-menus.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows the Metrics and azure-applicationinsights highlighted." lightbox="media/how-to-circuit-breaker-metrics/chart-menus.png":::
243+
:::image type="content" source="media/how-to-circuit-breaker-metrics/chart-menus.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page with the Metric Namespace menu open and azure.applicationinsights highlighted." lightbox="media/how-to-circuit-breaker-metrics/chart-menus.png":::
244+
238245
239246
1. Set **Metric** to **resilience4j_circuitbreaker_buffered_calls**, and then set **Aggregation** to **Avg**.
240247
241-
:::image type="content" source="media/how-to-circuit-breaker-metrics/buffered-calls.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows a chart with Metric and Aggregation options." lightbox="media/how-to-circuit-breaker-metrics/buffered-calls.png":::
248+
:::image type="content" source="media/how-to-circuit-breaker-metrics/buffered-calls.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows a chart with circuit breaker buffered calls and average aggregation." lightbox="media/how-to-circuit-breaker-metrics/buffered-calls.png":::
249+
242250
243251
1. Set **Metric** to **resilience4j_circuitbreaker_calls**, and then set **Aggregation** to **Avg**.
244252
245-
:::image type="content" source="media/how-to-circuit-breaker-metrics/calls.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows the Metric and Aggregation options." lightbox="media/how-to-circuit-breaker-metrics/calls.png":::
253+
:::image type="content" source="media/how-to-circuit-breaker-metrics/calls.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows a chart with circuit breaker calls and average aggregation." lightbox="media/how-to-circuit-breaker-metrics/calls.png":::
254+
246255
247256
1. Set **Metric** to **resilience4j_circuitbreaker_calls**, and then set **Aggregation** to **Avg**. Select **Add filter** and set **Name** to **Delay**.
248257
249-
:::image type="content" source="media/how-to-circuit-breaker-metrics/calls-filter.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows a chart with Metric, Aggregation, and Filter options." lightbox="media/how-to-circuit-breaker-metrics/calls-filter.png":::
258+
:::image type="content" source="media/how-to-circuit-breaker-metrics/calls-filter.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows a chart with circuit breaker calls, average aggregation and delay filter." lightbox="media/how-to-circuit-breaker-metrics/calls-filter.png":::
259+
250260
251261
1. Set **Metric** to **resilience4j_circuitbreaker_calls**, and then set **Aggregation** to **Avg**. Select **Apply splitting** and set **Split by** to **kind**.
252262
253-
:::image type="content" source="media/how-to-circuit-breaker-metrics/calls-splitting.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows a chart with Metric, Aggregation, and Split by options." lightbox="media/how-to-circuit-breaker-metrics/calls-splitting.png":::
263+
:::image type="content" source="media/how-to-circuit-breaker-metrics/calls-splitting.png" alt-text="Screenshot of the Azure portal Application Insights Metrics page that shows a chart with circuit breaker calls, average aggregation, and splitting." lightbox="media/how-to-circuit-breaker-metrics/calls-splitting.png":::
264+
254265
255266
1. Set **Metric** to **resilience4j_circuitbreaker_calls**, and then set **Aggregation** to **Avg**. Select **Add metric** and set **Metric** to **resilience4j_circuitbreaker_buffered_calls**, and then set **Aggregation** to **Avg**. Select **Add metric** again and set **Metric** to **resilience4j_circuitbreaker_slow_calls**, and then set **Aggregation** set to **Avg**.
256267

articles/spring-apps/enterprise/how-to-custom-domain.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,9 @@ use the following steps to grant access using the Azure portal:
159159
> [!NOTE]
160160
> If you don't find the "Azure Spring Apps Domain-Management", search for "Azure Spring Cloud Domain-Management".
161161
162-
:::image type="content" source="./media/how-to-custom-domain/import-certificate-b.png" alt-text="Screenshot of the Azure portal that shows the Add Access Policy page for a key vault with Get and List selected." lightbox="./media/how-to-custom-domain/import-certificate-b.png":::
162+
:::image type="content" source="./media/how-to-custom-domain/import-certificate-b.png" alt-text="Screenshot of the Azure portal Create an access policy page with Get and List options for Secret permissions and Certificate permissions highlighted." lightbox="./media/how-to-custom-domain/import-certificate-b.png":::
163163

164-
:::image type="content" source="./media/how-to-custom-domain/import-certificate-c.png" alt-text="Screenshot of the Azure portal that shows the Create Access Policy page for a key vault with Azure Spring Apps Domain-management selected." lightbox="./media/how-to-custom-domain/import-certificate-c.png":::
164+
:::image type="content" source="./media/how-to-custom-domain/import-certificate-c.png" alt-text="Screenshot of the Azure portal that shows the Create Access Policy page for a key vault with Azure Spring Cloud Domain-Management selected." lightbox="./media/how-to-custom-domain/import-certificate-c.png":::
165165

166166
#### [Azure CLI](#tab/Azure-CLI)
167167

articles/spring-apps/enterprise/how-to-deploy-in-azure-virtual-network.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,8 @@ Use the following steps to grant permission:
164164
> [!NOTE]
165165
> If you don't find Azure Spring Apps Resource Provider, search for *Azure Spring Cloud Resource Provider*.
166166
167-
:::image type="content" source="./media/how-to-deploy-in-azure-virtual-network/assign-owner-resource-provider.png" alt-text="Screenshot of the Azure portal that shows the Access Control (IAM) page, with the search results displaying the Azure Spring Apps Resource Provider." lightbox="./media/how-to-deploy-in-azure-virtual-network/assign-owner-resource-provider.png":::
167+
:::image type="content" source="./media/how-to-deploy-in-azure-virtual-network/assign-owner-resource-provider.png" alt-text="Screenshot of the Azure portal Access Control page with Add role assignment pane and Select box with Azure Spring Apps Resource Provider highlighted." lightbox="./media/how-to-deploy-in-azure-virtual-network/assign-owner-resource-provider.png":::
168+
168169

169170
### [Azure CLI](#tab/azure-CLI)
170171

articles/spring-apps/enterprise/how-to-enterprise-build-service.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ Tanzu Build Service allows at most one pool-sized build task to build and twice
5454

5555
When you create a new Azure Spring Apps Enterprise service instance using the Azure portal, you can use the **VMware Tanzu settings** tab to configure the number of resources given to the build agent pool.
5656

57-
:::image type="content" source="media/how-to-enterprise-build-service/agent-pool.png" alt-text="Screenshot of Azure portal that shows the Azure Spring Apps Create page with V M ware Tanzu settings highlighted." lightbox="media/how-to-enterprise-build-service/agent-pool.png":::
57+
:::image type="content" source="media/how-to-enterprise-build-service/agent-pool.png" alt-text="Screenshot of the Azure portal that shows the Create Azure Spring Apps page with V M ware Tanzu settings tab and Allocated Resources highlighted." lightbox="media/how-to-enterprise-build-service/agent-pool.png":::
5858

5959
The following image shows the resources given to the Tanzu Build Service Agent Pool after you successfully provision the service instance. You can also update the configured agent pool size here after you create the service instance.
6060

@@ -93,11 +93,11 @@ Use the following steps to enable Tanzu Build Service when provisioning an Azure
9393
1. Select **Next: VMware Tanzu settings**.
9494
1. On the **VMware Tanzu settings** tab, select **Enable Build Service**. For **Container registry**, the default setting is **Use a managed Azure Container Registry to store built images**.
9595

96-
:::image type="content" source="media/how-to-enterprise-build-service/enable-build-service-with-default-acr.png" alt-text="Screenshot of the Azure portal that shows the VMware Tanzu Settings with default Build Service settings highlighted." lightbox="media/how-to-enterprise-build-service/enable-build-service-with-default-acr.png":::
96+
:::image type="content" source="media/how-to-enterprise-build-service/enable-build-service-with-default-acr.png" alt-text="Screenshot of the Azure portal that shows the Create Azure Spring Apps page with V M ware Tanzu settings tab and Build Service settings highlighted." lightbox="media/how-to-enterprise-build-service/enable-build-service-with-default-acr.png":::
9797

9898
1. If you select **Use your own container registry to store built images (preview)** for **Container registry**, provide your container registry's server, username, and password.
9999

100-
:::image type="content" source="media/how-to-enterprise-build-service/enable-build-service-with-user-acr.png" alt-text="Screenshot of the Azure portal that shows VMware Tanzu Settings with use your own container registry highlighted." lightbox="media/how-to-enterprise-build-service/enable-build-service-with-user-acr.png":::
100+
:::image type="content" source="media/how-to-enterprise-build-service/enable-build-service-with-user-acr.png" alt-text="Screenshot of the Azure portal that shows the Create Azure Spring Apps page V M ware Tanzu settings tab with container registry settings highlighted." lightbox="media/how-to-enterprise-build-service/enable-build-service-with-user-acr.png":::
101101

102102
1. If you disable **Enable Build Service**, the container registry options aren't provided but you can deploy applications with container images.
103103

articles/spring-apps/enterprise/how-to-enterprise-configure-apm-integration-and-ca-certificates.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,7 @@ You can unbind a buildpack binding by using the **Unbind binding** command, or b
504504

505505
To use the **Unbind binding** command, select the **Bound** hyperlink, and then select **Unbind binding**.
506506

507-
:::image type="content" source="media/how-to-enterprise-configure-apm-integration-and-ca-certificates/unbind-binding-command.png" alt-text="Screenshot of the Azure portal that shows the Edit bindings for default builder page with the Unbind binding option highlighted." lightbox="media/how-to-enterprise-configure-apm-integration-and-ca-certificates/unbind-binding-command.png":::
507+
:::image type="content" source="media/how-to-enterprise-configure-apm-integration-and-ca-certificates/unbind-binding-command.png" alt-text="Screenshot of the Azure portal Edit bindings for default builder page with the Unbind binding option highlighted for a selected binding type." lightbox="media/how-to-enterprise-configure-apm-integration-and-ca-certificates/unbind-binding-command.png":::
508508

509509
To unbind a buildpack binding by editing binding properties, select **Edit Binding**, and then select **Unbind**.
510510

articles/spring-apps/enterprise/how-to-enterprise-deploy-polyglot-apps.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ Use the following steps to show, add, edit, and delete the container registry:
111111

112112
1. To delete a container registry, select the ellipsis (**...**) button, then select **Delete** to delete the registry. If the container registry is used by build service, it can't be deleted.
113113

114-
:::image type="content" source="media/how-to-enterprise-deploy-polyglot-apps/delete-container-registry.png" alt-text="Screenshot of Azure portal that shows the Container registry page with Delete container registry pane open." lightbox="media/how-to-enterprise-deploy-polyglot-apps/delete-container-registry.png":::
114+
:::image type="content" source="media/how-to-enterprise-deploy-polyglot-apps/delete-container-registry.png" alt-text="Screenshot of Azure portal that shows the Container registry page with Edit container registry pane open and Username and Password boxes highlighted." lightbox="media/how-to-enterprise-deploy-polyglot-apps/delete-container-registry.png":::
115115

116116
#### [Azure CLI](#tab/Azure-CLI)
117117

0 commit comments

Comments
 (0)