Skip to content

Commit 0871cc9

Browse files
committed
review feedback
1 parent 958cbbd commit 0871cc9

File tree

4 files changed

+8
-17
lines changed

4 files changed

+8
-17
lines changed

articles/azure-arc/kubernetes/extensions-troubleshooting.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ The following label must be present:
452452
If you aren't using `osm` CLI, you can also manually add these annotations to your namespaces. If a namespace isn't annotated with `"openservicemesh.io/sidecar-injection": "enabled"`, or isn't labeled with `"openservicemesh.io/monitored-by": "osm"`, the OSM injector won't add Envoy sidecars.
453453

454454
> [!NOTE]
455-
> After `osm namespace add` is called, only **new** pods will be injected with an Envoy sidecar. Existing pods must be restarted with `kubectl rollout restart deployment` command.
455+
> After `osm namespace add` is called, only **new** pods will be injected with an Envoy sidecar. Existing pods must be restarted with the `kubectl rollout restart deployment` command.
456456

457457
### Verify the SMI CRDs
458458

articles/azure-arc/kubernetes/extensions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ az k8s-extension update --name azureml --extension-type Microsoft.AzureML.Kubern
261261
|--------------|------------|
262262
| `--auto-upgrade-minor-version` | Boolean property that specifies whether the extension minor version is automatically upgraded. The default setting is `true`. If this parameter is set to true, you can't set the `version` parameter, as the version will be dynamically updated. If set to `false`, the extension won't be automatically upgraded, even for patch versions. |
263263
| `--version` | Version of the extension to be installed (specific version to pin the extension instance to). Must not be supplied if auto-upgrade-minor-version is set to `true`. |
264-
| `--configuration-settings` | Settings that can be passed into the extension to control its functionality.These are passed in as space-separated `key=value` pairs after the parameter name. If this parameter is used in the command, then `--configuration-settings-file` can't be used in the same command. Only the settings that require an update need to be provided. The provided settings will be replaced with the specified values. |
264+
| `--configuration-settings` | Settings that can be passed into the extension to control its functionality. These are passed in as space-separated `key=value` pairs after the parameter name. If this parameter is used in the command, then `--configuration-settings-file` can't be used in the same command. Only the settings that require an update need to be provided. The provided settings will be replaced with the specified values. |
265265
| `--configuration-settings-file` | Path to the JSON file with `key=value` pairs to be used for passing in configuration settings to the extension. If this parameter is used in the command, then `--configuration-settings` can't be used in the same command. |
266266
| `--configuration-protected-settings` | Settings that aren't retrievable using `GET` API calls or `az k8s-extension show` commands. Typically used to pass in sensitive settings. These are passed in as space-separated `key=value` pairs after the parameter name. If this parameter is used in the command, then `--configuration-protected-settings-file` can't be used in the same command. When you update a protected setting, all of the protected settings are expected to be specified. If any of these settings are omitted, those settings will be considered obsolete and deleted. |
267267
| `--configuration-protected-settings-file` | Path to a JSON file with `key=value` pairs to be used for passing in sensitive settings to the extension. If this parameter is used in the command, then `--configuration-protected-settings` can't be used in the same command. |

articles/azure-arc/kubernetes/troubleshooting.md

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ If you see these errors, check [Azure status](https://azure.status.microsoft/en-
7878

7979
## Overage claims error
8080

81-
If you receive an overage claim, make sure that your service principal isn't part of more than 200 Microsoft Entra groups. If sp, you must create and use another service principal that isn't a member of more than 200 groups, or remove the original service principal from some of its groups and try again.
81+
If you receive an overage claim, make sure that your service principal isn't part of more than 200 Microsoft Entra groups. If this is the case, you must create and use another service principal that isn't a member of more than 200 groups, or remove the original service principal from some of its groups and try again.
8282

8383
An overage claim may also occur if you have configured an outbound proxy environment without allowing the endpoint `https://<region>.obo.arc.azure.com:8084/` for outbound traffic.
8484

@@ -235,17 +235,8 @@ This warning occurs when you use a service principal to log into Azure, and the
235235
236236
1. Sign in into Azure CLI using the service principal. Use the `<objectId>` value from the previous step to enable custom locations on the cluster:
237237
238-
* To enable custom locations when connecting the cluster to Arc, run the following command:
239-
240-
```azurecli
241-
az connectedk8s connect -n <cluster-name> -g <resource-group-name> --custom-locations-oid <objectId>
242-
```
243-
244-
* To enable custom locations on an existing Azure Arc-enabled Kubernetes cluster, run the following command:
245-
246-
```azurecli
247-
az connectedk8s enable-features -n <cluster-name> -g <resource-group-name> --custom-locations-oid <objectId> --features cluster-connect custom-locations
248-
```
238+
* To enable custom locations when connecting the cluster to Arc, run `az connectedk8s connect -n <cluster-name> -g <resource-group-name> --custom-locations-oid <objectId>`
239+
* To enable custom locations on an existing Azure Arc-enabled Kubernetes cluster, run `az connectedk8s enable-features -n <cluster-name> -g <resource-group-name> --custom-locations-oid <objectId> --features cluster-connect custom-locations`
249240
250241
## Next steps
251242

articles/azure-arc/kubernetes/tutorial-arc-enabled-open-service-mesh.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ Changes to `osm-mesh-config` can be made using the `kubectl patch` command. In t
422422
kubectl patch meshconfig osm-mesh-config -n arc-osm-system -p '{"spec":{"traffic":{"enablePermissiveTrafficPolicyMode":false}}}' --type=merge
423423
```
424424

425-
If an incorrect value is used, validations on the MeshConfig CRD prevents the change with an error message explaining why the value is invalid. For example, this command shows what happens if we patch `enableEgress` to a non-boolean value:
425+
If an incorrect value is used, validations on the MeshConfig CRD prevent the change with an error message explaining why the value is invalid. For example, this command shows what happens if we patch `enableEgress` to a non-boolean value:
426426

427427
```azurecli-interactive
428428
kubectl patch meshconfig osm-mesh-config -n arc-osm-system -p '{"spec":{"traffic":{"enableEgress":"no"}}}' --type=merge
@@ -551,7 +551,7 @@ There may be some downtime of the control plane during upgrades. The data plane
551551

552552
### Supported upgrades
553553

554-
The OSM extension can be upgraded manually across minor and major versions. However, auto-upgrades (if enabled) only works across minor versions.
554+
The OSM extension can be upgraded manually across minor and major versions. However, automatic upgrade (if enabled) only works across minor versions.
555555

556556
### Upgrade to a specific OSM version manually
557557

@@ -585,7 +585,7 @@ az k8s-extension list --cluster-type connectedClusters --cluster-name $CLUSTER_N
585585

586586
This output should not include OSM. If you do not have any other extensions installed on your cluster, it's just an empty array.
587587

588-
When you use the `az k8s-extension `command to delete the OSM extension, the `arc-osm-system`` namespace is not removed, and the actual resources within the namespace (like mutating webhook configuration and osm-controller pod) takes around ~10 minutes to delete.
588+
When you use the `az k8s-extension` command to delete the OSM extension, the `arc-osm-system` namespace is not removed, and the actual resources within the namespace (like mutating webhook configuration and osm-controller pod) take around 10 minutes to delete.
589589

590590
> [!NOTE]
591591
> Use the az k8s-extension CLI to uninstall OSM components managed by Arc. Using the OSM CLI to uninstall is not supported by Arc and can result in undesirable behavior.

0 commit comments

Comments
 (0)