Merge pull request #287724 from rossgrambo/main

Azure App Configuration - Prepare for Feature Management 4.0.0 release.

Author: denrea

articles/azure-app-configuration/feature-management-dotnet-reference.md

@@ -275,7 +275,7 @@ configurationBuilder.AddAzureAppConfiguration(options =>
 ```
 
 > [!NOTE]
-> Load balancing support is available if you use version **8.0.0-preview.3** or later of any of the following packages.
+> Load balancing support is available if you use version **8.0.0** or later of any of the following packages.
 > - `Microsoft.Extensions.Configuration.AzureAppConfiguration`
 > - `Microsoft.Azure.AppConfiguration.AspNetCore`
 > - `Microsoft.Azure.AppConfiguration.Functions.Worker`

articles/azure-app-configuration/howto-geo-replication.md

@@ -199,68 +199,26 @@ In this section, you create a web application that allows users to sign in and u
 
 ## Enable targeting for the web application
 
-The targeting filter evaluates a user's feature state based on the user's targeting context, which comprises the user ID and the groups the user belongs to. In this example, you use the signed-in user's email address as the user ID and the domain name of the email address as the group.
+A targeting context is required for feature evaluation with targeting. You can provide it as a parameter to the `featureManager.IsEnabledAsync` API explicitly. In ASP.NET Core, the targeting context can also be provided through the service collection as an ambient context by implementing the [ITargetingContextAccessor](./feature-management-dotnet-reference.md#itargetingcontextaccessor) interface.
 
-1. Add an *ExampleTargetingContextAccessor.cs* file with the following code. You implement the `ITargetingContextAccessor` interface to provide the targeting context for the signed-in user of the current request.
+### Targeting Context Accessor
 
-    ```csharp
-    using Microsoft.FeatureManagement.FeatureFilters;
+To provide the targeting context, pass your implementation type of the `ITargetingContextAccessor` to the `WithTargeting<T>` method. If no type is provided, a default implementation is used, as shown in the following code snippet. The default targeting context accessor utilizes `HttpContext.User.Identity.Name` as `UserId` and `HttpContext.User.Claims` of type [`Role`](/dotnet/api/system.security.claims.claimtypes.role#system-security-claims-claimtypes-role) for `Groups`. You can reference the [DefaultHttpTargetingContextAccessor](https://github.com/microsoft/FeatureManagement-Dotnet/blob/main/src/Microsoft.FeatureManagement.AspNetCore/DefaultHttpTargetingContextAccessor.cs) to implement your own if customization is needed. To learn more about implementing the `ITargetingContextAccessor`, see the [feature reference for targeting](./feature-management-dotnet-reference.md#itargetingcontextaccessor).
 
-    namespace TestFeatureFlags
-    {
-        public class ExampleTargetingContextAccessor : ITargetingContextAccessor
-        {
-            private const string TargetingContextLookup = "ExampleTargetingContextAccessor.TargetingContext";
-            private readonly IHttpContextAccessor _httpContextAccessor;
-
-            public ExampleTargetingContextAccessor(IHttpContextAccessor httpContextAccessor)
-            {
-                _httpContextAccessor = httpContextAccessor ?? throw new ArgumentNullException(nameof(httpContextAccessor));
-            }
-
-            public ValueTask<TargetingContext> GetContextAsync()
-            {
-                HttpContext httpContext = _httpContextAccessor.HttpContext;
-                if (httpContext.Items.TryGetValue(TargetingContextLookup, out object value))
-                {
-                    return new ValueTask<TargetingContext>((TargetingContext)value);
-                }
-                List<string> groups = new List<string>();
-                if (httpContext.User.Identity.Name != null)
-                {
-                    groups.Add(httpContext.User.Identity.Name.Split("@", StringSplitOptions.None)[1]);
-                }
-                TargetingContext targetingContext = new TargetingContext
-                {
-                    UserId = httpContext.User.Identity.Name,
-                    Groups = groups
-                };
-                httpContext.Items[TargetingContextLookup] = targetingContext;
-                return new ValueTask<TargetingContext>(targetingContext);
-            }
-        }
-    }
-    ```
+``` C#
+// Existing code in Program.cs
+// ... ...
 
-1. Open the *Program.cs* file and enable the targeting filter by calling the `WithTargeting` method. You pass in the type `ExampleTargetingContextAccessor` that the targeting filter will use to get the targeting context during feature flag evaluation. Add `HttpContextAccessor` to the service collection to allow `ExampleTargetingContextAccessor` to access the signed-in user information from the `HttpContext`.
+// Add feature management to the container of services
+builder.Services.AddFeatureManagement()
+                .WithTargeting();
 
-    ```csharp
-    // Existing code in Program.cs
-    // ... ...
-
-    // Add feature management to the container of services
-    builder.Services.AddFeatureManagement()
-                    .WithTargeting<ExampleTargetingContextAccessor>();
+// The rest of existing code in Program.cs
+// ... ...
+```
 
-    // Add HttpContextAccessor to the container of services.
-    builder.Services.AddHttpContextAccessor();
-
-    // The rest of existing code in Program.cs
-    // ... ...
-    ```
-    
-    > [!NOTE]
-    > For Blazor applications, see [instructions](./faq.yml#how-to-enable-feature-management-in-blazor-applications-or-as-scoped-services-in--net-applications) for enabling feature management as scoped services.
+> [!NOTE]
+> For Blazor applications, see [instructions](./faq.yml#how-to-enable-feature-management-in-blazor-applications-or-as-scoped-services-in--net-applications) for enabling feature management as scoped services.
 
 ## Targeting filter in action
 
@@ -280,10 +238,6 @@ The targeting filter evaluates a user's feature state based on the user's target
 
     Now sign in as `[email protected]`, using the password you set when registering the account. The **Beta** item doesn't appear on the toolbar, because `[email protected]` is specified as an excluded user.
 
-    You can create more users with `@contoso.com` and `@contoso-xyz.com` email addresses to see the behavior of the group settings.
-
-    Users with `contoso-xyz.com` email addresses won't see the **Beta** item. While 50% of users with `@contoso.com` email addresses will see the **Beta** item, the other 50% won't see the **Beta** item.
-
 ## Next steps
 
 To learn more about the feature filters, continue to the following documents.

articles/azure-app-configuration/howto-targetingfilter-aspnet-core.md

@@ -134,10 +134,10 @@ This project will use [dependency injection in .NET Azure Functions](../azure-fu
    Add a constructor used to obtain instances of `_featureManagerSnapshot` and `IConfigurationRefresherProvider` through dependency injection. From the `IConfigurationRefresherProvider`, you can obtain the instance of `IConfigurationRefresher`.
 
     ```csharp
-    private readonly IFeatureManagerSnapshot _featureManagerSnapshot;
+    private readonly IVariantFeatureManagerSnapshot _featureManagerSnapshot;
     private readonly IConfigurationRefresher _configurationRefresher;
 
-    public Function1(IFeatureManagerSnapshot featureManagerSnapshot, IConfigurationRefresherProvider refresherProvider)
+    public Function1(IVariantFeatureManagerSnapshot featureManagerSnapshot, IConfigurationRefresherProvider refresherProvider)
     {
         _featureManagerSnapshot = featureManagerSnapshot;
         _configurationRefresher = refresherProvider.Refreshers.First();

articles/azure-app-configuration/quickstart-feature-flag-azure-functions-csharp.md

@@ -117,16 +117,16 @@ Add a feature flag called *Beta* to the App Configuration store and leave **Labe
     using Microsoft.FeatureManagement;
     ```
 
-1. Update the constructor of the `Worker` service to obtain instances of `IConfigurationRefresher` and `IFeatureManager` through dependency injection.
+1. Update the constructor of the `Worker` service to obtain instances of `IConfigurationRefresher` and `IVariantFeatureManager` through dependency injection.
 
     ```csharp
     public class Worker : BackgroundService
     {
         private readonly ILogger<Worker> _logger;
         private readonly IConfigurationRefresher _refresher;
-        private readonly IFeatureManager _featureManager;
+        private readonly IVariantFeatureManager _featureManager;
 
-        public Worker(ILogger<Worker> logger, IConfigurationRefresher refresher, IFeatureManager featureManager)
+        public Worker(ILogger<Worker> logger, IConfigurationRefresher refresher, IVariantFeatureManager featureManager)
         {
             _logger = logger ?? throw new ArgumentNullException(nameof(logger));
             _refresher = refresher ?? throw new ArgumentNullException(nameof(refresher));

articles/azure-app-configuration/quickstart-feature-flag-dotnet-background-service.md

@@ -40,9 +40,9 @@ You can use Visual Studio to create a new console app project.
 
 1. Start Visual Studio, and select **File** > **New** > **Project**.
 
-1. In **Create a new project**, filter on the **Console** project type and select **Console App**. If you want to create a .NET Framework app, please select **Console App (.NET Framework)** instead. Click **Next**.
+1. In **Create a new project**, filter on the **Console** project type and select **Console App**. If you want to create a .NET Framework app, select **Console App (.NET Framework)** instead. Click **Next**.
 
-1. In **Configure your new project**, enter a project name. If you are creating a .NET Framework app, please select **.NET Framework 4.7.2** or higher under **Framework**. Click **Create**.
+1. In **Configure your new project**, enter a project name. If you're creating a .NET Framework app, select **.NET Framework 4.7.2** or higher under **Framework**. Click **Create**.
 
 ## Use the feature flag
 
@@ -77,7 +77,7 @@ You can use Visual Studio to create a new console app project.
 
     IFeatureDefinitionProvider featureDefinitionProvider = new ConfigurationFeatureDefinitionProvider(configuration);
 
-    IFeatureManager featureManager = new FeatureManager(
+    IVariantFeatureManager featureManager = new FeatureManager(
         featureDefinitionProvider, 
         new FeatureManagementOptions());
 
@@ -103,7 +103,7 @@ You can use Visual Studio to create a new console app project.
 
         IFeatureDefinitionProvider featureDefinitionProvider = new ConfigurationFeatureDefinitionProvider(configuration);
 
-        IFeatureManager featureManager = new FeatureManager(
+        IVariantFeatureManager featureManager = new FeatureManager(
             featureDefinitionProvider, 
             new FeatureManagementOptions());
 
@@ -130,7 +130,7 @@ You can use Visual Studio to create a new console app project.
     setx ConnectionString "<connection-string-of-your-app-configuration-store>"
     ```
 
-    Restart the command prompt to allow the change to take effect. Print the value of the environment variable to validate that it's set properly.
+    Restart the command prompt to allow the change to take effect. Validate that it's set properly by printing the value of the environment variable.
 
     ### [PowerShell](#tab/powershell)
 

articles/azure-app-configuration/quickstart-feature-flag-dotnet.md

@@ -1295,15 +1295,6 @@ groups:
     title: .NET
   - id: framework-spring
     title: Spring Framework
-# Owner: zhiyuanliang
-- id: feature-management
-  title: Library version pivots
-  prompt: Choose a release
-  pivots:
-  - id: stable-version
-    title: Stable release
-  - id: preview-version
-    title: Preview release
 # Owner: avanigupta
 - id: appconfig-data-plane-api-version
   title: API version pivots