Skip to content

Commit 130e985

Browse files
Apply suggestions from code review
Co-authored-by: Max Horstmann <[email protected]>
1 parent e43811c commit 130e985

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

articles/deployment-environments/how-to-configure-extensibility-generic-container-image.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ In this article, you learn how to build custom container images to deploy your [
1717

1818
An environment definition comprises at least two files: a template file, like *azuredeploy.json*, and a manifest file named *environment.yaml*. ADE uses containers to deploy environment definitions, and natively supports the Azure Resource Manager (ARM) and Bicep IaC frameworks.
1919

20-
The ADE extensibility model enables you to create custom container images to use with your environment definitions. By using the extensibility model, you can create your own custom container images, and store them in a public container registry like DockerHub, or a private container registry like Azure Container Registry (ACR). You can then reference these images in your environment definitions to deploy your environments.
20+
The ADE extensibility model enables you to create custom container images to use with your environment definitions. By using the extensibility model, you can create your own custom container images, and store them in a container registry like Azure Container Registry (ACR) or Docker Hub. You can then reference these images in your environment definitions to deploy your environments.
2121

2222
The ADE team provides a selection of images to get you started, including a core image, and an Azure Resource Manager (ARM)/Bicep image. You can access these sample images in the [Runner-Images](https://aka.ms/deployment-environments/runner-images) folder.
2323

@@ -134,14 +134,14 @@ docker build . -t {YOUR_REGISTRY}.azurecr.io/customImage:1.0.0
134134

135135
### Push the image to a registry
136136

137-
In order to use custom images, you need to store them in a registry. You can use a public container registry like DockerHub, or the Azure Container Registry (ACR), which is a private registry.
137+
In order to use custom images, you need to store them in a registry like Azure Container Registry (ACR) or Docker Hub.
138138

139139
To use a custom image stored in a public registry, you need to enable anonymous image pull. This way, Azure Deployment Environments can access your custom image to execute in our container.
140140

141141
> [!Caution]
142142
> Enabling anonymous (unauthenticated) pull access makes all registry content publicly available for read (pull) actions.
143143
144-
To use a custom image stored in the ACR, you need to ensure that ADE has appropriate permissions to access your image. When you create an ACR instance, it's secure by default and only allows authenticated users to gain access. With this configuration, you don't have to enable anonymous pull access.
144+
To use a custom image stored in ACR, you need to ensure that ADE has appropriate permissions to access your image. Anonymous pull access is disabled by default in ACR.
145145

146146
#### Use a public registry with anonymous pull
147147

@@ -161,11 +161,11 @@ docker push {YOUR_REGISTRY}.azurecr.io/{YOUR_IMAGE_LOCATION}:{YOUR_TAG}
161161
```
162162
#### Use ACR with secured access
163163

164-
By default, access to pull or push content from an Azure container registry is only available to authenticated users. You can further secure access to ACR by limiting access from certain networks and assigning specific roles.
164+
By default, access to pull or push content from an Azure Container Registry is only available to authenticated users. You can further secure access to ACR by limiting access from certain networks and assigning specific roles.
165165

166166
##### Limit network access
167167

168-
To secure network access to your ACR, you can limit access to your own networks, or disable public network access entirely. If you limit network access, you must enable the firewall exception *Allow trusted Microsoft services to access this container registry*. ADE uses the Azure Container Instances service, which is a trusted Microsoft service.
168+
To secure network access to your ACR, you can limit access to your own networks, or disable public network access entirely. If you limit network access, you must enable the firewall exception *Allow trusted Microsoft services to access this container registry*.
169169

170170
To disable access from public networks:
171171

0 commit comments

Comments
 (0)