Skip to content

Commit 14c97bc

Browse files
committed
Fixed typo and restructured auth section
1 parent 0499621 commit 14c97bc

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

articles/load-testing/tutorial-cicd-github-actions.md

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,9 @@ The sample application's source repo includes an Apache JMeter script named *Sam
5656

5757
## Set up GitHub access permissions for Azure
5858

59-
The GitHub Actions workflow needs to authenticate with Azure to access Azure resources. In the sample application, you use the [Azure Login](https://github.com/Azure/login) action and an Azure Active Directory service principal to authenticate with Azure. For other options to authenticate to Azure, see the [Azure and GitHub integration site](/azure/developer/github).
59+
The GitHub Actions workflow needs to authenticate with Azure to access Azure resources. In the sample application, you use the [Azure Login](https://github.com/Azure/login) action and an Azure Active Directory service principal to authenticate with Azure.
6060

61-
In this section, you'll go through the following steps:
62-
63-
- Create an Azure Active Directory service principal with the Contributor role.
64-
- Add the service principal as a GitHub secret to the sample application repository.
65-
- Assign the Load Test Contributor role to the service principal.
66-
67-
Set up your GitHub repository to have permissions to access your Azure load testing resource:
61+
In this section, you'll configure your GitHub repository to have permissions to access your Azure load testing resource:
6862

6963
1. Run the following Azure CLI command to create a service principal and assign the Contributor role:
7064

@@ -88,8 +82,13 @@ Set up your GitHub repository to have permissions to access your Azure load test
8882
}
8983
```
9084
85+
> [!NOTE]
86+
> Azure Login supports multiple ways to authenticate with Azure. For other authentication options, see the [Azure and GitHub integration site](/azure/developer/github).
87+
9188
1. Go to your forked GitHub repository for the sample application.
9289
90+
You'll add a GitHub secret to your repository for the service principal you created in the previous step. The Azure Login action uses this secret to authenticate with Azure.
91+
9392
1. Add a new secret to your GitHub repository by selecting **Settings** > **Secrets** > **New repository secret**.
9493
9594
:::image type="content" source="./media/tutorial-cicd-github-actions/github-new-secret.png" alt-text="Screenshot that shows selections for adding a new repository secret to your GitHub repo.":::
@@ -114,7 +113,7 @@ Set up your GitHub repository to have permissions to access your Azure load test
114113
--subscription "<subscription-name-or-id>"
115114
```
116115
117-
You can now use the `AZURE_CREDENTIALS` secret with the Azure Login action in your CI/CD workflow. The following code snippet describes how this for the sample application:
116+
You can now use the `AZURE_CREDENTIALS` secret with the Azure Login action in your CI/CD workflow. The following code snippet describes how this works for the sample application:
118117
119118
```yml
120119
jobs:

0 commit comments

Comments
 (0)