Skip to content

Commit 1abc159

Browse files
committed
Addressed PR feedback
1 parent f7168ea commit 1abc159

File tree

5 files changed

+19
-18
lines changed

5 files changed

+19
-18
lines changed

articles/key-vault/quick-create-java.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ Open the *pom.xml* file in your text editor. Add the following dependency elemen
9696

9797
### Create a resource group and key vault
9898

99-
This quickstart uses a pre-created Azure key vault. You can create a key vault by following the steps in the [Azure CLI quickstart](quick-create-cli.md), [Azure PowerShell quickstart](quick-create-powershell.md), or [Azure portal quickstart](quick-create-portal.md). Alternatively, you can simply run the Azure CLI commands below.
99+
This quickstart uses a pre-created Azure key vault. You can create a key vault by following the steps in the [Azure CLI quickstart](quick-create-cli.md), [Azure PowerShell quickstart](quick-create-powershell.md), or [Azure portal quickstart](quick-create-portal.md). Alternatively, you can run the Azure CLI commands below.
100100

101101
> [!Important]
102102
> Each key vault must have a unique name. Replace <your-unique-keyvault-name> with the name of your key vault in the following examples.
@@ -109,7 +109,7 @@ az keyvault create --name <your-unique-keyvault-name> -g "myResourceGroup"
109109

110110
### Create a service principal
111111

112-
The simplest way to authenticate an cloud-based application is with a managed identity; see [Use an App Service managed identity to access Azure Key Vault](managed-identity.md) for details. For the sake of simplicity however, this quickstarts creates a desktop application, which requires the use of a service principal and an access control policy.
112+
The simplest way to authenticate a cloud-based application is with a managed identity; see [Use an App Service managed identity to access Azure Key Vault](managed-identity.md) for details. For the sake of simplicity however, this quickstart creates a desktop application, which requires the use of a service principal and an access control policy.
113113

114114
Create a service principle using the Azure CLI [az ad sp create-for-rbac](/cli/azure/ad/sp?view=azure-cli-latest#az-ad-sp-create-for-rbac) command:
115115

@@ -146,7 +146,7 @@ az keyvault set-policy -n <your-unique-keyvault-name> --spn <clientId-of-your-se
146146

147147
#### Set environmental variables
148148

149-
The DefaultAzureCredential method in our application relies on three environmental variables: `AZURE_CLIENT_ID`, `AZURE_CLIENT_SECRET`, and `AZURE_TENANT_ID`. use set these variables to the clientId, clientSecret, and tenantId values you noted in the [Create a service principal](#create-a-service-principal) step, above. Use the `export VARNAME=VALUE` format to set your environmental variables. (This only sets the variables for your current shell and processes created from the shell; to permanently add these variables to your environment, edit your `/etc/)
149+
The DefaultAzureCredential method in our application relies on three environmental variables: `AZURE_CLIENT_ID`, `AZURE_CLIENT_SECRET`, and `AZURE_TENANT_ID`. use set these variables to the clientId, clientSecret, and tenantId values you noted in the [Create a service principal](#create-a-service-principal) step, above. Use the `export VARNAME=VALUE` format to set your environmental variables. (This method only sets the variables for your current shell and processes created from the shell; to permanently add these variables to your environment, edit your `/etc/environment ` file.)
150150

151151
You will also need to save your key vault name as an environment variable called `KEY_VAULT_NAME`.
152152

@@ -182,7 +182,7 @@ import com.azure.security.keyvault.secrets.models.KeyVaultSecret;
182182

183183
### Authenticate and create a client
184184

185-
Authenticating to your key vault and creating a key vault client depends on the environmental variables in the [Set environmental variables](#set-environmental-variables) step above. The name of your key vault is expanded to the key vault URI, in the format "https://&lt;your-key-vault-name&gt;.vault.azure.net".
185+
Authenticating to your key vault and creating a key vault client depends on the environmental variables in the [Set environmental variables](#set-environmental-variables) step above. The name of your key vault is expanded to the key vault URI, in the format `https://<your-key-vault-name>.vault.azure.net`.
186186

187187
```java
188188
String keyVaultName = System.getenv("KEY_VAULT_NAME");

articles/key-vault/quick-create-net-v3.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ az keyvault create --name <your-unique-keyvault-name> -g "myResourceGroup"
9494

9595
### Create a service principal
9696

97-
The simplest way to authenticate an cloud-based .NET application is with a managed identity; see [Use an App Service managed identity to access Azure Key Vault](managed-identity.md) for details. For the sake of simplicity however, this quickstarts creates a .NET console application. Authenticating a desktop application with Azure requires the use of a service principal and an access control policy.
97+
The simplest way to authenticate a cloud-based .NET application is with a managed identity; see [Use an App Service managed identity to access Azure Key Vault](managed-identity.md) for details. For the sake of simplicity however, this quickstart creates a .NET console application. Authenticating a desktop application with Azure requires the use of a service principal and an access control policy.
9898

9999
Create a service principle using the Azure CLI [az ad sp create-for-rbac](/cli/azure/ad/sp?view=azure-cli-latest#az-ad-sp-create-for-rbac) command:
100100

@@ -163,7 +163,7 @@ Assign these environment variables to strings in your code, and then authenticat
163163

164164
### Save a secret
165165

166-
Now that your application is authenticated, you can put a secret into your keyvault using the [SetSecretAsync method](/dotnet/api/microsoft.azure.keyvault.keyvaultclientextensions.setsecretasync) This requires the URL of your key vault, which is in the form `https://<your-unique-keyvault-name>.vault.azure.net/secrets/`. It also requires a name for the secret -- we're using "mySecret". You may wish to assign these strings to a variables for reuse.
166+
Now that your application is authenticated, you can put a secret into your keyvault using the [SetSecretAsync method](/dotnet/api/microsoft.azure.keyvault.keyvaultclientextensions.setsecretasync) This requires the URL of your key vault, which is in the form `https://<your-unique-keyvault-name>.vault.azure.net/secrets/`. It also requires a name for the secret -- we're using "mySecret".
167167

168168
[!code-csharp[Set secret](~/samples-key-vault-dotnet-quickstart/akvdotnet/Program.cs?name=setsecret)]
169169

articles/key-vault/quick-create-net.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ az keyvault create --name <your-unique-keyvault-name> -g "myResourceGroup"
8484

8585
### Create a service principal
8686

87-
The simplest way to authenticate an cloud-based .NET application is with a managed identity; see [Use an App Service managed identity to access Azure Key Vault](managed-identity.md) for details. For the sake of simplicity however, this quickstarts creates a .NET console application. Authenticating a desktop application with Azure requires the use of a service principal and an access control policy.
87+
The simplest way to authenticate a cloud-based .NET application is with a managed identity; see [Use an App Service managed identity to access Azure Key Vault](managed-identity.md) for details. For the sake of simplicity however, this quickstart creates a .NET console application. Authenticating a desktop application with Azure requires the use of a service principal and an access control policy.
8888

8989
Create a service principle using the Azure CLI [az ad sp create-for-rbac](/cli/azure/ad/sp?view=azure-cli-latest#az-ad-sp-create-for-rbac) command:
9090

articles/key-vault/quick-create-python.md

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ pip install azure.identity
4949

5050
### Create a resource group and key vault
5151

52-
This quickstart uses a pre-created Azure key vault. You can create a key vault by following the steps in the [Azure CLI quickstart](quick-create-cli.md), [Azure PowerShell quickstart](quick-create-powershell.md), or [Azure portal quickstart](quick-create-portal.md). Alternatively, you can simply run the Azure CLI commands below.
52+
This quickstart uses a pre-created Azure key vault. You can create a key vault by following the steps in the [Azure CLI quickstart](quick-create-cli.md), [Azure PowerShell quickstart](quick-create-powershell.md), or [Azure portal quickstart](quick-create-portal.md). Alternatively, you can run the Azure CLI commands below.
5353

5454
> [!Important]
5555
> Each key vault must have a unique name. Replace <your-unique-keyvault-name> with the name of your key vault in the following examples.
@@ -62,7 +62,7 @@ az keyvault create --name <your-unique-keyvault-name> -g "myResourceGroup"
6262

6363
### Create a service principal
6464

65-
The simplest way to authenticate an cloud-based .NET application is with a managed identity; see [Use an App Service managed identity to access Azure Key Vault](managed-identity.md) for details. For the sake of simplicity however, this quickstarts creates a .NET console application. Authenticating a desktop application with Azure requires the use of a service principal and an access control policy.
65+
The simplest way to authenticate a cloud-based .NET application is with a managed identity; see [Use an App Service managed identity to access Azure Key Vault](managed-identity.md) for details. For the sake of simplicity however, this quickstart creates a .NET console application. Authenticating a desktop application with Azure requires the use of a service principal and an access control policy.
6666

6767
Create a service principle using the Azure CLI [az ad sp create-for-rbac](/cli/azure/ad/sp?view=azure-cli-latest#az-ad-sp-create-for-rbac) command:
6868

@@ -99,7 +99,7 @@ az keyvault set-policy -n <your-unique-keyvault-name> --spn <clientId-of-your-se
9999

100100
#### Set environmental variables
101101

102-
The DefaultAzureCredential method in our application relies on three environmental variables: `AZURE_CLIENT_ID`, `AZURE_CLIENT_SECRET`, and `AZURE_TENANT_ID`. Set these variables to the clientId, clientSecret, and tenantId values you noted in the [Create a service principal](#create-a-service-principal) step using the `export VARNAME=VALUE` format. (This only sets the variables for your current shell and processes created from the shell; to permanently add these variables to your environment, edit your `/etc/environment ` file.)
102+
The DefaultAzureCredential method in our application relies on three environmental variables: `AZURE_CLIENT_ID`, `AZURE_CLIENT_SECRET`, and `AZURE_TENANT_ID`. Set these variables to the clientId, clientSecret, and tenantId values you noted in the [Create a service principal](#create-a-service-principal) step using the `export VARNAME=VALUE` format. (This method only sets the variables for your current shell and processes created from the shell; to permanently add these variables to your environment, edit your `/etc/environment ` file.)
103103

104104
You will also need to save your key vault name as an environment variable called `KEY_VAULT_NAME`.
105105

@@ -117,6 +117,7 @@ export KEY_VAULT_NAME=<your-key-vault-name>
117117

118118
The Azure Key Vault client library for Python allows you to manage keys and related assets such as certificates and secrets. The code samples below will show you how to create a client, set a secret, retrieve a secret, and delete a secret.
119119

120+
The entire console app is available at https://github.com/Azure-Samples/key-vault-dotnet-core-quickstart/tree/master/key-vault-console-app.
120121

121122
## Code examples
122123

@@ -142,7 +143,7 @@ client = SecretClient(vault_endpoint=KVUri, credential=credential)
142143

143144
### Save a secret
144145

145-
Now that your application is authenticated, you can put a secret into your keyvault using the `client.set_secret` method. This requires a name for the secret -- we've assigned the value "mySecret" to the `secretName` variable in this sample.
146+
Now that your application is authenticated, you can put a secret into your keyvault using the client.SetSecret method](/dotnet/api/microsoft.azure.keyvault.keyvaultclientextensions.setsecretasync) This requires a name for the secret -- we're using "mySecret" in this sample.
146147

147148
```python
148149
client.set_secret(secretName, secretValue);
@@ -156,7 +157,7 @@ az keyvault secret show --vault-name <your-unique-keyvault-name> --name mySecret
156157

157158
### Retrieve a secret
158159

159-
You can now retrieve the previously set value with the `client.get_secret` method.
160+
You can now retrieve the previously set value with the [client.GetSecret method](/dotnet/api/microsoft.azure.keyvault.keyvaultclientextensions.getsecretasync).
160161

161162
```python
162163
retrieved_secret = client.get_secret(secretName)
@@ -166,7 +167,7 @@ Your secret is now saved as `retrieved_secret.value`.
166167

167168
### Delete a secret
168169

169-
Finally, let's delete the secret from your key vault with the `client.delete_secret` method.
170+
Finally, let's delete the secret from your key vault with the [client.DeleteSecret method](/dotnet/api/microsoft.azure.keyvault.keyvaultclientextensions.getsecretasync).
170171

171172
```python
172173
client.delete_secret(secretName);
@@ -234,7 +235,9 @@ print(" done.");
234235

235236
## Next steps
236237

237-
In this quickstart you created a key vault, stored a secret, and retrieved that secret. To learn more about Key Vault and how to integrate it with your applications, continue on to the articles below.
238+
In this quickstart you created a key vault, stored a secret, and retrieved that secret. See the [entire console app in GitHub](https://github.com/Azure-Samples/key-vault-dotnet-core-quickstart/tree/master/key-vault-console-app).
239+
240+
To learn more about Key Vault and how to integrate it with your applications, continue on to the articles below.
238241

239242
- Read an [Overview of Azure Key Vault](key-vault-overview.md)
240243
- See the [Azure Key Vault developer's guide](key-vault-developers-guide.md)

articles/key-vault/toc.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@
1919
href: quick-create-net.md
2020
- name: .NET (SDK v3)
2121
href: quick-create-net-v3.md
22-
- name: Java
23-
href: quick-create-java.md
2422
- name: Node.js
2523
href: quick-create-node.md
2624
- name: Azure Resource Manager template
@@ -60,8 +58,6 @@
6058
href: ../azure-resource-manager/resource-manager-keyvault-parameter.md
6159
- name: Set up key rotation and auditing
6260
href: key-vault-key-rotation-log-monitoring.md
63-
- name: Monitor Key Vault events with Event Grid
64-
href: event-grid-overview.md
6561
- name: Samples
6662
items:
6763
- name: Code samples
@@ -116,6 +112,8 @@
116112
href: key-vault-group-permissions-for-apps.md
117113
- name: Route key vault notifications with Event Grid
118114
href: event-grid-tutorial.md
115+
- name: Receive notifications via Event Grid and Logic Apps
116+
href: event-grid-logicapps.md
119117
- name: Integrate with Azure Policy
120118
href: azure-policy.md
121119
- name: Azure Key Vault logging

0 commit comments

Comments
 (0)