Skip to content

Commit 1abd6e0

Browse files
committed
Address comments
1 parent 16ee282 commit 1abd6e0

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

articles/communication-services/concepts/router/router-rule-concepts.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ In this example a `ExpressionRule`, which is a subtype of `RouterRule` can be us
7575
await routerAdministration.CreateClassificationPolicyAsync(
7676
new CreateClassificationPolicyOptions(classificationPolicyId: "my-policy-id")
7777
{
78-
PrioritizationRule = new ExpressionRule("If(job.Urgent = true, 10, 5)") // this will check whether the job has a label "Escalated" set to "true"
78+
PrioritizationRule = new ExpressionRule("If(job.Escalated = true, 10, 5)") // this will check whether the job has a label "Escalated" set to "true"
7979
});
8080
```
8181

@@ -88,7 +88,7 @@ await client.upsertClassificationPolicy({
8888
id: "my-policy-id",
8989
prioritizationRule: {
9090
kind: "expression-rule",
91-
expression: "If(job.Urgent = true, 10, 5)"
91+
expression: "If(job.Escalated = true, 10, 5)"
9292
}
9393
});
9494
```

articles/communication-services/how-tos/router-sdk/escalate-job.md

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ await routerClient.CreateExceptionPolicyAsync(
4646
{
4747
"EscalateReclassifyExceptionAction" = new ReclassifyExceptionAction(
4848
classificationPolicyId: "<classification policy id>",
49-
labelsToUpsert: new Dictionary<string, object>()
49+
labelsToUpsert: new Dictionary<string, LabelValue>()
5050
{
51-
["Escalated"] = true,
51+
["Escalated"] = new LabelValue(true),
5252
})
5353
})
5454
}
@@ -126,12 +126,7 @@ await routerClient.CreateJobAsync(
126126
{
127127
RequestedWorkerSelectors = new List<WorkerSelector>
128128
{
129-
new WorkerSelector()
130-
{
131-
Key = "XBOX_Hardware",
132-
Operator = LabelOperator.GreaterThanEqual,
133-
Value = 7
134-
}
129+
new WorkerSelector(key: "XBOX_Hardware", labelOperator: LabelOperator.GreaterThanEqual, value: new LabelValue(7))
135130
}
136131
});
137132
);

articles/communication-services/how-tos/router-sdk/manage-queue.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ The Job Router SDK will update an existing queue when the `UpdateQueue` or `Upda
5656
var queue = await administrationClient.UpdateQueueAsync(
5757
options: new UpdateQueueOptions("XBOX_DEFAULT_QUEUE")
5858
{
59-
QueueId = "XBOX_DEFAULT_QUEUE",
6059
Name = "XBOX Default Queue",
6160
DistributionPolicyId = "Longest_Idle_45s_Min1Max10",
6261
Labels = new Dictionary<string, LabelValue>()

0 commit comments

Comments
 (0)