Skip to content

Commit 2361cf3

Browse files
committed
updates from internal review
1 parent cc7d4c7 commit 2361cf3

File tree

6 files changed

+13
-12
lines changed

6 files changed

+13
-12
lines changed

articles/communication-services/concepts/call-automation/call-recording/bring-your-own-storage.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Bring your own Azure storage uses [Azure Managed Identities](/entra/identity/man
2727
## Known issues
2828

2929
- Azure Communication Services will also store your files in a built-in storage for 24 hours even if the exporting is successful.
30-
- Randomly, recording files are duplicated during the exporting process. Make sure you delete the duplicated file to avoid extra storage costs in your storage account.
30+
- For Pause on Start Recording the meta data file would have an incorrect pause duration in relation to the recording file.
3131

3232

3333
## Next steps

articles/communication-services/quickstarts/call-automation/call-recording/bring-your-own-storage.md

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,8 @@ ms.custom: mode-api, devx-track-extended-java
1414
---
1515
# Call recording: Bring your own Azure storage quickstart
1616

17-
[!INCLUDE [Private Preview](../../../includes/private-preview-include-section.md)]
18-
1917
This quickstart gets you started with Bring your own Azure storage for Call Recording. To start using Bring your own Azure Storage functionality, make sure you're familiar with the [Call Recording APIs](../../voice-video-calling/get-started-call-recording.md).
2018

21-
You need to be part of the Azure Communication Services TAP program. It's likely that you’re already part of this program, and if you aren't, sign-up using https://aka.ms/acs-tap-invite. Bring your own Azure Storage uses Managed Identities, to access to this functionality for Call Recording, submit your Azure Communication Services Resource IDs by filling this - [Registration form](https://forms.office.com/r/njact5SiVJ). You need to fill the form every time you need a new resource ID allow-listed.
22-
2319
## Pre-requisite: Setting up Managed Identity and RBAC role assignments
2420

2521
### 1. Enable system assigned managed identity for Azure Communication Services
@@ -77,7 +73,7 @@ Refer to this example of the event schema.
7773
"topic": "string", // /subscriptions/{subscription-id}/resourceGroups/{group-name}/providers/Microsoft.Communication/communicationServices/{communication-services-resource-name}
7874
"subject": "string", // /recording/call/{call-id}/serverCallId/{serverCallId}
7975
"data": {
80-
"storageType": "string", // acsstorage, blobstorage etc.
76+
"storageType": "string", // AzureBlob etc.
8177
"recordingId": "string", // unique id for recording
8278
"recordingStorageInfo": {
8379
"recordingChunks": [
@@ -106,12 +102,12 @@ Refer to this example of the event schema.
106102
Recordings are stored in the following format as shown in the diagram.
107103
/YYYYMMDD/
108104
callId/
109-
8+ recordingId(guid)/
105+
first_8_of_recordingId + '-' + unique guid)/
110106
0-acsmetadata.documentId.json
111-
0- audiomp3.documentId.mp3
107+
0-audiomp3.documentId.mp3
112108
1-acsmetadata.documentId.json
113109
1-audiomp3.documentId.mp3
114-
110+
115111
![Diagram showing a Call Recording Folder structure](../media/call-recording-folder.png)
116112

117113
## Next steps

articles/communication-services/quickstarts/voice-video-calling/includes/call-recording-samples/call-recording-csharp.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,8 @@ Response<RecordingStateResult> response = await callAutomationClient.GetCallReco
7878
.StartAsync(recordingOptions);
7979
```
8080
## 2.2. Start recording session with Pause mode enabled using 'StartAsync' API
81-
81+
> [!NOTE]
82+
> **Recordings will need to be resumed for recording file to be generated.**
8283
```csharp
8384
StartRecordingOptions recordingOptions = new StartRecordingOptions(new ServerCallLocator("<ServerCallId>"))
8485
{

articles/communication-services/quickstarts/voice-video-calling/includes/call-recording-samples/call-recording-java.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,8 @@ Start Recording session with your own Azure Blob Storage to store the recording
8181
```
8282

8383
### 2.2. Start recording session with Pause mode enabled using 'StartAsync' API
84-
84+
> [!NOTE]
85+
> **Recordings will need to be resumed for recording file to be generated.**
8586
```java
8687
StartRecordingOptions recordingOptions = new StartRecordingOptions(new ServerCallLocator("<serverCallId>"))
8788
.setRecordingChannel(RecordingChannel.UNMIXED)

articles/communication-services/quickstarts/voice-video-calling/includes/call-recording-samples/call-recording-javascript.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ var options: StartRecordingOptions = {
8585
var response = await callAutomationClient.getCallRecording().start(options);
8686
```
8787
## 2.2. Start recording session with Pause mode enabled using 'StartAsync' API
88-
88+
> [!NOTE]
89+
> **Recordings will need to be resumed for recording file to be generated.**
8990
```javascript
9091
var locator: CallLocator = { id: "<ServerCallId>", kind: "serverCallLocator" };
9192

articles/communication-services/quickstarts/voice-video-calling/includes/call-recording-samples/call-recording-python.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ response = call_automation_client.start_recording(call_locator=ServerCallLocator
7171
recording_storage = AzureBlobContainerRecordingStorage(container_url="<YOUR_STORAGE_CONTAINER_URL>"))
7272
```
7373
## 2.2. Start recording session with Pause mode enabled using 'StartAsync' API
74+
> [!NOTE]
75+
> **Recordings will need to be resumed for recording file to be generated.**
7476
7577
```python
7678
response = call_automation_client.start_recording(call_locator=ServerCallLocator(server_call_id),

0 commit comments

Comments
 (0)