Skip to content

Commit 253d8ec

Browse files
committed
address comments
1 parent 77626d7 commit 253d8ec

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

articles/playwright-testing/playwright-testing-reporting-with-sharding.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ In this article, you learn how to use the Microsoft Playwright Testing service's
1616

1717
Playwright's sharding enables you to split your test suite to run across multiple machines simultaneously. This feature helps running tests in parallel.
1818

19-
You can use Playwright Testing's reporting feature to get a consolidated report of a test run with sharding. You need to make sure the `runId` of the test run is same across all shards.
19+
You can use Playwright Testing's reporting feature to get a consolidated report of a test run with sharding. Ensure the `runId` of the test run is same across all shards.
2020

2121
> [!IMPORTANT]
2222
> Microsoft Playwright Testing is currently in preview. For legal terms that apply to Azure features that are in beta, in preview, or otherwise not yet released into general availability, see the [Supplemental Terms of Use for Microsoft Azure Previews](https://azure.microsoft.com/support/legal/preview-supplemental-terms/).
@@ -53,7 +53,7 @@ By default, a test run that uses reporting feature automatically generates a uni
5353
> If you use the cloud-hosted browsers provided by Microsoft Playwright Testing service to run your tests, you might have already set this variable. To avoid overwrites, make sure you set it only once.
5454
5555

56-
While using sharding, make sure the same `runId` is set across all the shards for the results to be reported together. This can be achieved by using a variable `PLAYWRIGHT_SERVICE_RUN_ID` and setting this value same across all shards.
56+
While using sharding, make sure the same `runId` is set across all the shards for the results to be reported together. Use the variable `PLAYWRIGHT_SERVICE_RUN_ID` and set the value same across all shards.
5757

5858
Here's an example of how you can set it in your pipeline via GitHub Actions.
5959

articles/playwright-testing/quickstart-automate-end-to-end-testing.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ Set up Playwright to capture artifacts such as screenshot, videos and traces.
155155
- For videos, see [record videos for your tests](https://playwright.dev/dotnet/docs/videos#introduction)
156156
- For traces, see [recording a trace](https://playwright.dev/dotnet/docs/trace-viewer-intro#recording-a-trace)
157157

158-
Once you collect these artifacts, attach them to the `TestContext` to ensure they're available in your test reports. For more information, see our [sample project for NUnit](https://aka.ms/mpt/nunit-sample)
158+
Once you collect these artifacts, attach them to the `TestContext` to ensure they're available in your test reports. For more information, see our [sample project for NUnit](https://aka.ms/mpt/nunit-sample).
159159
::: zone-end
160160

161161
## Set up authentication
@@ -202,7 +202,7 @@ The service offers two authentication methods: Microsoft Entra ID and Access Tok
202202
| `AZURE_SUBSCRIPTION_ID` | Subscription ID |
203203
| `AZURE_TENANT_ID` | Directory (Tenant) ID |
204204

205-
> **Note:**
205+
> [!NOTE]
206206
> For enhanced security, it is strongly recommended to use GitHub Secrets to store sensitive values rather than including them directly in your workflow file.
207207
208208
# [Azure Pipelines](#tab/pipelines)
@@ -218,13 +218,13 @@ The service offers two authentication methods: Microsoft Entra ID and Access Tok
218218
#### Set up authentication using access tokens
219219

220220
> [!CAUTION]
221-
> We strongly recommend using Microsoft Entra ID for authentication to the service. If you're using access tokens, see [How to Manage Access Tokens](./how-to-manage-access-tokens.md)
221+
> We strongly recommend using Microsoft Entra ID for authentication to the service. If you're using access tokens, see [How to manage access tokens](./how-to-manage-access-tokens.md)
222222
223223
You can generate an access token from your Playwright Testing workspace and use it in your setup. However, we strongly recommend Microsoft Entra ID for authentication due to its enhanced security. Access tokens, while convenient, function like long-lived passwords and are more susceptible to being compromised.
224224

225-
1. Authentication using access tokens is disabled by default. To use, [Enable access-token based authentication](./how-to-manage-authentication.md#enable-authentication-using-access-tokens)
225+
1. Authentication using access tokens is disabled by default. To use, [Enable access-token based authentication](./how-to-manage-authentication.md#enable-authentication-using-access-tokens).
226226

227-
2. [Set up authentication using access tokens](./how-to-manage-authentication.md#set-up-authentication-using-access-tokens)
227+
2. [Set up authentication using access tokens](./how-to-manage-authentication.md#set-up-authentication-using-access-tokens).
228228

229229
3. Store the access token in a CI workflow secret and use it in the GitHub Actions workflow or Azure Pipeline yaml file.
230230

0 commit comments

Comments
 (0)