Merge pull request #50577 from kgremban/aug30-angellfeedback

First changes from Tony's feedback

Author: rjagiewich

articles/iot-edge/TOC.yml

@@ -93,14 +93,14 @@
       href: how-to-auto-provision-simulated-device-windows.md
   - name: Develop and debug modules
     items:
+    - name: Azure Functions
+      href: how-to-develop-csharp-function.md
     - name: C#
       href: how-to-develop-csharp-module.md
     - name: Node.js
       href: how-to-develop-node-module.md
     - name: C
       href: how-to-develop-c-module.md
-    - name: Azure Functions
-      href: how-to-develop-csharp-function.md
     - name: Develop multiple modules
       href: how-to-develop-multiple-modules-vscode.md
     - name: Debug multiple modules

articles/iot-edge/how-to-develop-c-module.md

@@ -32,9 +32,7 @@ Because this article uses Visual Studio Code as the main development tool, insta
 To create a module, you need Docker to build the module image, and a container registry to hold the module image:
 * [Docker Community Edition](https://docs.docker.com/install/) on your development machine. 
 * [Azure Container Registry](https://docs.microsoft.com/azure/container-registry/) or [Docker Hub](https://docs.docker.com/docker-hub/repos/#viewing-repository-tags)
-
-   > [!TIP]
-   > You can use a local Docker registry for prototype and testing purposes instead of a cloud registry. 
+   * You can use a local Docker registry for prototype and testing purposes instead of a cloud registry. 
 
 To test your module on a device, you need an active IoT hub with at least one IoT Edge device. To use your computer as an IoT Edge device, follow the steps in the quickstart for [Windows](quickstart.md) or [Linux](quickstart-linux.md). 
 
@@ -43,16 +41,24 @@ To test your module on a device, you need an active IoT hub with at least one Io
 Take these steps to create an IoT Edge module based on Azure IoT C SDK using Visual Studio Code and the Azure IoT Edge extension. First you create a solution, and then you generate the first module in that solution. Each solution can contain more than one module. 
 
 1. In Visual Studio Code, select **View** > **Integrated Terminal**.
-3. Select **View** > **Command Palette**. 
-4. In the command palette, enter and run the command **Azure IoT Edge: New IoT Edge Solution**.
+
+2. Select **View** > **Command Palette**. 
+
+3. In the command palette, enter and run the command **Azure IoT Edge: New IoT Edge Solution**.
 
    ![Run New IoT Edge Solution](./media/how-to-develop-csharp-module/new-solution.png)
 
-5. Browse to the folder where you want to create the new solution. Choose **Select folder**. 
-6. Enter a name for your solution. 
-7. Select **C Module** as the template for the first module in the solution.
-8. Enter a name for your module. Choose a name that's unique within your container registry. 
-9. Provide the name of the module's image repository. VS Code autopopulates the module name with **localhost:5000**. Replace it with your own registry information. If you use a local Docker registry for testing, then **localhost** is fine. If you use Azure Container Registry, then use the login server from your registry's settings. The login server looks like **\<registry name\>.azurecr.io**.
+4. Browse to the folder where you want to create the new solution. Choose **Select folder**. 
+
+5. Enter a name for your solution. 
+
+6. Select **C Module** as the template for the first module in the solution.
+
+7. Enter a name for your module. Choose a name that's unique within your container registry. 
+
+8. Provide the name of the module's image repository. VS Code autopopulates the module name with **localhost:5000**. Replace it with your own registry information. If you use a local Docker registry for testing, then **localhost** is fine. If you use Azure Container Registry, then use the login server from your registry's settings. The login server looks like **\<registry name\>.azurecr.io**. Only replace the localhost part of the string, don't delete your module name. 
+
+   ![Provide Docker image repository](./media/how-to-develop-c-module/repository.png)
 
 VS Code takes the information you provided, creates an IoT Edge solution, and then loads it in a new window.
 
@@ -70,7 +76,7 @@ There are four items within the solution:
 
 ## Develop your module
 
-The default C module code that comes with the solution is located at **modules** > **\<your module name\>** > **main.c**. The module and the deployment.template.json file are set up so that you can build the solution, push it to your container registry, and deploy it to a device to start testing without touching any code. The module is built to simply take input from a source (in this case, the tempSensor module that simulates data) and pipe it to IoT Hub. 
+The default C module code that comes with the solution is located at **modules** > [your module name] > **main.c**. The module and the deployment.template.json file are set up so that you can build the solution, push it to your container registry, and deploy it to a device to start testing without touching any code. The module is built to simply take input from a source (in this case, the tempSensor module that simulates data) and pipe it to IoT Hub. 
 
 When you're ready to customize the C template with your own code, use the [Azure IoT Hub SDKs](../iot-hub/iot-hub-devguide-sdks.md) to build modules that address the key needs for IoT solutions such as security, device management, and reliability. 
 

articles/iot-edge/how-to-develop-csharp-function.md

@@ -28,12 +28,11 @@ This article uses Visual Studio Code as the main development tool. Install VS Co
 * [Docker extension](https://marketplace.visualstudio.com/items?itemName=PeterJausovec.vscode-docker)
 
 To create a module, you need .NET to build the project folder, Docker to build the module image, and a container registry to hold the module image:
+
 * [.NET Core 2.1 SDK](https://www.microsoft.com/net/download)
 * [Docker Community Edition](https://docs.docker.com/install/) on your development machine 
 * [Azure Container Registry](https://docs.microsoft.com/azure/container-registry/) or [Docker Hub](https://docs.docker.com/docker-hub/repos/#viewing-repository-tags)
-
-   > [!TIP]
-   > You can use a local Docker registry for prototype and testing purposes instead of a cloud registry. 
+   * You can use a local Docker registry for prototype and testing purposes instead of a cloud registry. 
 
 To test your module on a device, you need an active IoT hub with at least one IoT Edge device. To use your computer as an IoT Edge device, follow the steps in the quickstart for [Windows](quickstart.md) or [Linux](quickstart-linux.md). 
 
@@ -51,7 +50,9 @@ Take these steps to create an IoT Edge solution that has one C# function module.
 6. Enter a name for your solution. 
 7. Choose **Azure Functions - C#** as the template for the first module in the solution.
 8. Enter a name for your module. Choose a name that's unique within your container registry. 
-9. Provide the image repository for the module. VS Code autopopulates the module name with **localhost:5000**. Replace it with your own registry information. If you use a local Docker registry for testing, then **localhost** is fine. If you use Azure Container Registry, then use the login server from your registry's settings. The login server looks like **\<registry name\>.azurecr.io**.
+9. Provide the image repository for the module. VS Code autopopulates the module name with **localhost:5000**. Replace it with your own registry information. If you use a local Docker registry for testing, then **localhost** is fine. If you use Azure Container Registry, then use the login server from your registry's settings. The login server looks like **\<registry name\>.azurecr.io**. Only replace the localhost part of the string, don't delete your module name.
+
+   ![Provide Docker image repository](./media/how-to-develop-csharp-function/repository.png)
 
 VS Code takes the information you provided, creates an IoT Edge solution with an Azure Functions project, and then loads it in a new window.
 
@@ -68,7 +69,7 @@ There are four items within the solution:
 
 ## Develop your module
 
-The default Azure Function code that comes with the solution is located at **modules** > **\<your module name\>** > **EdgeHubTrigger-Csharp** > **run.csx**. The module and the deployment.template.json file are set up so that you can build the solution, push it to your container registry, and deploy it to a device to start testing without touching any code. The module is built to simply take input from a source (in this case, the tempSensor module that simulates data) and pipe it to IoT Hub. 
+The default Azure Function code that comes with the solution is located at **modules** > [your module name] > **EdgeHubTrigger-Csharp** > **run.csx**. The module and the deployment.template.json file are set up so that you can build the solution, push it to your container registry, and deploy it to a device to start testing without touching any code. The module is built to simply take input from a source (in this case, the tempSensor module that simulates data) and pipe it to IoT Hub. 
 
 When you're ready to customize the Azure Function template with your own code, use the [Azure IoT Hub SDKs](../iot-hub/iot-hub-devguide-sdks.md) to build modules that address the key needs for IoT solutions such as security, device management, and reliability. 
 
@@ -80,7 +81,7 @@ When you're ready to customize the Azure Function template with your own code, u
 2. Rebuild your solution. In the VS Code command palette, enter and run the command **Azure IoT Edge: Build IoT Edge solution**.
 3. In Azure IoT Hub Devices explorer, right-click an IoT Edge device ID, and then select **Create deployment for Edge device**. Select the `deployment.json` file in the `config` folder. You'll see the deployment successfully created with a deployment ID in a VS Code-integrated terminal.
 
-Check your container status in VS Code Docker explorer or by running the `docker images` command in the terminal.
+Check your container status in VS Code Docker explorer or by running the `docker ps` command in the terminal.
 
 ## Start debugging C# functions in VS Code
 1. VS Code keeps debugging configuration information in a `launch.json` file located in a `.vscode` folder in your workspace. This `launch.json` file was generated when you created a new IoT Edge solution. It updates each time you add a new module that supports debugging. Navigate to the debug view. Select the corresponding debug configuration file. The debug option name should be similar to **ModuleName Remote Debug (.NET Core)**.

articles/iot-edge/how-to-develop-csharp-module.md

@@ -33,9 +33,7 @@ To create a module, you need .NET to build the project folder, Docker to build t
 * [.NET Core 2.1 SDK](https://www.microsoft.com/net/download).
 * [Docker Community Edition](https://docs.docker.com/install/) on your development machine. 
 * [Azure Container Registry](https://docs.microsoft.com/azure/container-registry/) or [Docker Hub](https://docs.docker.com/docker-hub/repos/#viewing-repository-tags)
-
-   > [!TIP]
-   > You can use a local Docker registry for prototype and testing purposes instead of a cloud registry. 
+   * You can use a local Docker registry for prototype and testing purposes instead of a cloud registry. 
 
 To test your module on a device, you need an active IoT hub with at least one IoT Edge device. To use your computer as an IoT Edge device, follow the steps in the quickstart for [Windows](quickstart.md) or [Linux](quickstart-linux.md). 
 
@@ -53,7 +51,9 @@ Take these steps to create an IoT Edge module based on .NET Core 2.0 using Visua
 6. Enter a name for your solution. 
 7. Select **C# Module** as the template for the first module in the solution.
 8. Enter a name for your module. Choose a name that's unique within your container registry. 
-9. Provide the name of the module's image repository. VS Code autopopulates the module name with **localhost:5000**. Replace it with your own registry information. If you use a local Docker registry for testing, then **localhost** is fine. If you use Azure Container Registry, then use the login server from your registry's settings. The login server looks like **\<registry name\>.azurecr.io**.
+9. Provide the name of the module's image repository. VS Code autopopulates the module name with **localhost:5000**. Replace it with your own registry information. If you use a local Docker registry for testing, then **localhost** is fine. If you use Azure Container Registry, then use the login server from your registry's settings. The login server looks like **\<registry name\>.azurecr.io**. Only replace the localhost part of the string, don't delete your module name.
+
+   ![Provide Docker image repository](./media/how-to-develop-csharp-module/repository.png)
 
 VS Code takes the information you provided, creates an IoT Edge solution, and then loads it in a new window.
 
@@ -71,7 +71,7 @@ There are four items within the solution:
 
 ## Develop your module
 
-The default Azure Function code that comes with the solution is located at **modules** > **\<your module name\>** > **Program.cs**. The module and the deployment.template.json file are set up so that you can build the solution, push it to your container registry, and deploy it to a device to start testing without touching any code. The module is built to simply take input from a source (in this case, the tempSensor module that simulates data) and pipe it to IoT Hub. 
+The default Azure Function code that comes with the solution is located at **modules** > [your module name] > **Program.cs**. The module and the deployment.template.json file are set up so that you can build the solution, push it to your container registry, and deploy it to a device to start testing without touching any code. The module is built to simply take input from a source (in this case, the tempSensor module that simulates data) and pipe it to IoT Hub. 
 
 When you're ready to customize the C# template with your own code, use the [Azure IoT Hub SDKs](../iot-hub/iot-hub-devguide-sdks.md) to build modules that address the key needs for IoT solutions such as security, device management, and reliability. 
 

articles/iot-edge/how-to-develop-node-module.md

@@ -33,9 +33,7 @@ To create a module, you need Node.js which includes npm to build the project fol
 * [Node.js](https://nodejs.org)
 * [Docker](https://docs.docker.com/engine/installation/)
 * [Azure Container Registry](https://docs.microsoft.com/azure/container-registry/) or [Docker Hub](https://docs.docker.com/docker-hub/repos/#viewing-repository-tags)
-
-   >[!TIP]
-   >You can use a local Docker registry for prototype and testing purposes, instead of a cloud registry. 
+   * You can use a local Docker registry for prototype and testing purposes, instead of a cloud registry. 
 
 To test your module on a device, you need an active IoT hub with at least one IoT Edge device. If you want to use your computer as an IoT Edge device, you can do so by following the steps in the tutorials for [Windows](quickstart.md) or [Linux](quickstart-linux.md). 
 
@@ -58,7 +56,9 @@ The following steps show you how to create an IoT Edge module based on Node.js u
 6. Provide a name for your solution. 
 7. Choose **Node.js Module** as the template for the first module in the solution.
 8. Provide a name for your module. Choose a name that's unique within your container registry. 
-9. Provide the image repository for the module. VS Code autopopulates the module name, so you just have to replace **localhost:5000** with your own registry information. If you use a local Docker registry for testing, then localhost is fine. If you use Azure Container Registry, then use the login server from your registry's settings. The login server looks like **\<registry name\>.azurecr.io**.
+9. Provide the image repository for the module. VS Code autopopulates the module name, so you just have to replace **localhost:5000** with your own registry information. If you use a local Docker registry for testing, then localhost is fine. If you use Azure Container Registry, then use the login server from your registry's settings. The login server looks like **\<registry name\>.azurecr.io**. Only replace the localhost part of the string, don't delete your module name.
+
+   ![Provide Docker image repository](./media/how-to-develop-node-module/repository.png)
 
 VS Code takes the information you provided, creates an IoT Edge solution, then loads it in a new window.
 
@@ -74,7 +74,7 @@ Within the solution you have three items:
 
 ## Develop your module
 
-The default Node.js code that comes with the solution is located at **modules** > **\<your module name\>** > **app.js**. The module and the deployment.template.json file are set up so that you can build the solution, push it to your container registry, and deploy it to a device to start testing without touching any code. The module is built to simply take input from a source (in this case, the tempSensor module that simulates data) and pipe it to IoT Hub. 
+The default Node.js code that comes with the solution is located at **modules** > [your module name] > **app.js**. The module and the deployment.template.json file are set up so that you can build the solution, push it to your container registry, and deploy it to a device to start testing without touching any code. The module is built to simply take input from a source (in this case, the tempSensor module that simulates data) and pipe it to IoT Hub. 
 
 When you're ready to customize the Node.js template with your own code, use the [Azure IoT Hub SDKs](../iot-hub/iot-hub-devguide-sdks.md) to build modules that address the key needs for IoT solutions such as security, device management, and reliability. 
 

articles/iot-edge/media/how-to-develop-c-module/repository.png

@@ -148,7 +148,7 @@ For examples about how to create queries for message properties, see [Device-to-
 An example that is specific to IoT Edge is when you want to filter for messages that arrived at a gateway device from a leaf device. Messages that come from modules contain a system property called **connectionModuleId**. So if you want to route messages from leaf devices directly to IoT Hub, use the following route to exclude module messages:
 
 ```sql
-FROM /messages/* WHERE NOT IS_DEFINED($connectionModuleId) INTO $upstream
+FROM /messages/\* WHERE NOT IS_DEFINED($connectionModuleId) INTO $upstream
 ```
 
 ### Sink