Skip to content

Commit 3122999

Browse files
authored
Apply suggestions from code review
1 parent bc0c359 commit 3122999

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

articles/spring-apps/enterprise/how-to-application-insights.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -491,12 +491,14 @@ The Java agent is updated/upgraded when the buildpack is updated.
491491

492492
## Java agent configuration hot-loading
493493

494-
Azure Spring Apps enables a hot-loading mechanism to adjust the settings of agent configuration without restart of applications.
494+
Azure Spring Apps has a hot-loading mechanism to adjust the settings of agent configuration without restart of applications.
495+
495496

496497
> [!NOTE]
497498
> The hot-loading mechanism has a delay in minutes.
498499
499-
* When the Java agent is previously enabled, changes to the Application Insights instance and/or SamplingRate do NOT require applications to be restarted.
500+
* If the Java agent is already enabled, changes to the Application Insights instance or `SamplingRate` value don't require application restart.
501+
500502
* If you enable the Java agent, then you must restart applications.
501503
* When you disable the Java agent, applications stop sending all monitoring data after a delay in minutes. You can restart applications to remove the agent from the Java runtime environment.
502504

articles/spring-apps/enterprise/how-to-circuit-breaker-metrics.md

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,17 @@ Use the following steps to build and deploy the sample applications.
3838

3939
::: zone pivot="sc-standard"
4040

41-
1. Use the following command to create Azure Spring Apps:
41+
1. Use the following command to create an Azure Spring Apps service instance:
42+
4243

4344
```azurecli
4445
az spring create \
4546
--resource-group ${resource-group-name} \
4647
--name ${Azure-Spring-Apps-instance-name}
4748
```
4849

49-
1. Use the following commands to create applications with endpoints:
50+
1. Use the following commands to create the applications with endpoints:
51+
5052

5153
```azurecli
5254
az spring app create \
@@ -61,7 +63,8 @@ Use the following steps to build and deploy the sample applications.
6163
--assign-endpoint
6264
```
6365

64-
1. Use the following commands to deploy applications:
66+
1. Use the following commands to deploy the applications:
67+
6568

6669
```azurecli
6770
az spring app deploy \
@@ -82,10 +85,12 @@ Use the following steps to build and deploy the sample applications.
8285

8386
::: zone pivot="sc-enterprise"
8487

85-
1. Use the following command to create Azure Spring Apps:
88+
1. Use the following command to create an Azure Spring Apps service instance:
89+
8690

8791
> [!NOTE]
88-
> If your subscription has never been used to create an Enterprise plan instance of Azure Spring Apps, it's necessary to run the following command:
92+
> If your subscription has never been used to create an Enterprise plan instance of Azure Spring Apps, you must run the following command:
93+
8994
>
9095
> ```azurecli
9196
> az term accept \
@@ -116,7 +121,8 @@ Use the following steps to build and deploy the sample applications.
116121
--assign-endpoint
117122
```
118123

119-
1. Use the following commands to deploy applications:
124+
1. Use the following commands to deploy the applications:
125+
120126

121127
```azurecli
122128
az spring app deploy \
@@ -180,10 +186,11 @@ Use the following steps to build and deploy the sample applications.
180186
181187
1. In your Azure Spring Apps instance, select **Application Insights** in the navigation pane and then select **Application Insights** on the page.
182188
183-
:::image type="content" source="media/how-to-circuit-breaker-metrics/application-insights.png" alt-text="Screenshot of the Azure portal that shows the Azure Spring Apps Application Insights page with the Application Insights highlighted." lightbox="media/how-to-circuit-breaker-metrics/application-insights.png":::
189+
:::image type="content" source="media/how-to-circuit-breaker-metrics/application-insights.png" alt-text="Screenshot of the Azure portal that shows the Azure Spring Apps Application Insights page with Application Insights highlighted." lightbox="media/how-to-circuit-breaker-metrics/application-insights.png":::
190+
184191
185192
> [!NOTE]
186-
> If there's no default Application Insights available, you can enable the Java In-Process agent. For more information, see the [Manage Application Insights using the Azure portal](./how-to-application-insights.md#manage-application-insights-using-the-azure-portal) section of [Use Application Insights Java In-Process Agent in Azure Spring Apps](./how-to-application-insights.md).
193+
> If you don't enable Application Insights, you can enable the Java In-Process agent. For more information, see the [Manage Application Insights using the Azure portal](./how-to-application-insights.md#manage-application-insights-using-the-azure-portal) section of [Use Application Insights Java In-Process Agent in Azure Spring Apps](./how-to-application-insights.md).
187194
188195
1. Enable dimension collection for resilience4j metrics. For more information, see the [Custom metrics dimensions and pre-aggregation](../../azure-monitor/app/pre-aggregated-metrics-log-metrics.md#custom-metrics-dimensions-and-pre-aggregation) section of [Log-based and pre-aggregated metrics in Application Insights](../../azure-monitor/app/pre-aggregated-metrics-log-metrics.md).
189196

0 commit comments

Comments
 (0)