Skip to content

Commit 312e4ee

Browse files
authored
Merge pull request #106555 from MicrosoftDocs/repo_sync_working_branch
Confirm merge from repo_sync_working_branch to master to sync with https://github.com/Microsoft/azure-docs (branch master)
2 parents 46b6abc + a863651 commit 312e4ee

14 files changed

+77
-43
lines changed

articles/active-directory-b2c/code-samples.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,4 @@ The following tables provide links to samples for applications including iOS, An
4242

4343
| Sample | Description |
4444
|--------| ----------- |
45-
| [javascript-msal-singlepageapp](https://github.com/Azure-Samples/active-directory-b2c-javascript-msal-singlepageapp) | A single page application (SPA) calling a Web API. Authentication is done with Azure AD B2C by leveraging MSAL.js. |
46-
| [javascript-hellojs-singlepageapp](https://github.com/Azure-Samples/active-directory-b2c-javascript-hellojs-singlepageapp) | A single page app, implemented with an ASP.NET Web API backend, that signs up & signs in users using Azure AD B2C and calls the web API using OAuth 2.0 access tokens. |
45+
| [javascript-msal-singlepageapp](https://github.com/Azure-Samples/active-directory-b2c-javascript-msal-singlepageapp) | A single page application (SPA) calling a Web API. Authentication is done with Azure AD B2C by using MSAL.js. |

articles/active-directory-b2c/implicit-flow-single-page-application.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -239,12 +239,12 @@ GET https://{tenant}.b2clogin.com/{tenant}.onmicrosoft.com/{policy}/oauth2/v2.0/
239239
240240
## Next steps
241241

242-
### Code sample: hello.js with Azure AD B2C
242+
### Code sample: Azure AD B2C with Microsoft Authentication Library for JavaScript
243243

244-
[Single-page application built on hello.js with Azure AD B2C][github-hello-js-example] (GitHub)
244+
[Single-page application built with msal.js for Azure AD B2C][github-msal-js-example] (GitHub)
245245

246-
This sample on GitHub is intended to help get you started with Azure AD B2C in a simple web application built on [hello.js][github-hello-js] and using pop-up-style authentication.
246+
This sample on GitHub is intended to help get you started to Azure AD B2C in a simple web application built with [msal.js][github-msal-js] and using pop-up-style authentication.
247247

248248
<!-- Links - EXTERNAL -->
249-
[github-hello-js-example]: https://github.com/Azure-Samples/active-directory-b2c-javascript-hellojs-singlepageapp
250-
[github-hello-js]: https://github.com/MrSwitch/hello.js
249+
[github-msal-js-example]: https://github.com/Azure-Samples/active-directory-b2c-javascript-msal-singlepageapp
250+
[github-msal-js]: https://github.com/AzureAD/microsoft-authentication-library-for-js

articles/active-directory-domain-services/tutorial-configure-password-hash-sync.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ With Azure AD Connect installed and configured to synchronize with Azure AD, now
7777
# Define the Azure AD Connect connector names and import the required PowerShell module
7878
$azureadConnector = "<CASE SENSITIVE AZURE AD CONNECTOR NAME>"
7979
$adConnector = "<CASE SENSITIVE AD DS CONNECTOR NAME>"
80+
81+
Import-Module "C:\Program Files\Microsoft Azure AD Sync\Bin\ADSync\ADSync.psd1"
8082
Import-Module "C:\Program Files\Microsoft Azure Active Directory Connect\AdSyncConfig\AdSyncConfig.psm1"
8183
8284
# Create a new ForceFullPasswordSync configuration parameter object then

articles/active-directory/develop/quickstart-v2-javascript.md

Lines changed: 27 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,11 @@ In this quickstart, you use a code sample to learn how a JavaScript single-page
8181
> [Download the code sample]()
8282
8383
> [!div renderon="docs"]
84+
8485
> #### Step 3: Configure your JavaScript app
8586
>
86-
> In the *JavaScriptSPA* folder, edit *authConfig.js*, and set the `clientID` and `authority` values under `msalConfig`.
87+
> In the *JavaScriptSPA* folder, edit *authConfig.js*, and set the `clientID`, `authority` and `redirectUri` values under `msalConfig`.
88+
>
8789
> ```javascript
8890
>
8991
> // Config object to be passed to Msal on creation
@@ -96,10 +98,10 @@ In this quickstart, you use a code sample to learn how a JavaScript single-page
9698
> cache: {
9799
> cacheLocation: "sessionStorage", // This configures where your cache will be stored
98100
> storeAuthStateInCookie: false, // Set this to "true" if you are having issues on IE11 or Edge
99-
> forceRefresh: false // Set this to "true" to skip a cached token and go to the server to get a new
100101
> }
101102
> };
102-
> ```
103+
>
104+
>```
103105
104106
> [!div renderon="portal"]
105107
> > [!NOTE]
@@ -123,6 +125,27 @@ In this quickstart, you use a code sample to learn how a JavaScript single-page
123125
> We have configured your project with values of your app's properties.
124126
125127
> [!div renderon="docs"]
128+
>
129+
> Then, still in the same folder, edit *graphConfig.js* file to set the `graphMeEndpoint` and `graphMeEndpoint` for the `apiConfig` object.
130+
> ```javascript
131+
> // Add here the endpoints for MS Graph API services you would like to use.
132+
> const graphConfig = {
133+
> graphMeEndpoint: "Enter_the_Graph_Endpoint_Herev1.0/me",
134+
> graphMailEndpoint: "Enter_the_Graph_Endpoint_Herev1.0/me/messages"
135+
> };
136+
>
137+
> // Add here scopes for access token to be used at MS Graph API endpoints.
138+
> const tokenRequest = {
139+
> scopes: ["Mail.Read"]
140+
> };
141+
> ```
142+
>
143+
144+
> [!div renderon="docs"]
145+
>
146+
> Where:
147+
> - *\<Enter_the_Graph_Endpoint_Here>* is the endpoint that API calls will be made against. For the main or global Microsoft Graph API service, simply enter `https://graph.microsoft.com`. For more information, see [National cloud deployment](https://docs.microsoft.com/graph/deployments)
148+
>
126149
> #### Step 4: Run the project
127150
128151
Run the project with a web server by using [Node.js](https://nodejs.org/en/download/):
@@ -154,7 +177,6 @@ The MSAL library signs in users and requests the tokens that are used to access
154177
> [!TIP]
155178
> You can replace the preceding version with the latest released version under [MSAL.js releases](https://github.com/AzureAD/microsoft-authentication-library-for-js/releases).
156179
157-
158180
Alternatively, if you have Node.js installed, you can download the latest version through Node.js Package Manager (npm):
159181
160182
```batch
@@ -176,7 +198,6 @@ The quickstart code also shows how to initialize the MSAL library:
176198
cache: {
177199
cacheLocation: "sessionStorage", // This configures where your cache will be stored
178200
storeAuthStateInCookie: false, // Set this to "true" if you are having issues on IE11 or Edge
179-
forceRefresh: false // Set this to "true" to skip a cached token and go to the server to get a new
180201
}
181202
};
182203
@@ -227,7 +248,7 @@ MSAL uses three methods to acquire tokens: `acquireTokenRedirect`, `acquireToken
227248
The `acquireTokenSilent` method handles token acquisitions and renewal without any user interaction. After the `loginRedirect` or `loginPopup` method is executed for the first time, `acquireTokenSilent` is the method commonly used to obtain tokens that are used to access protected resources for subsequent calls. Calls to request or renew tokens are made silently.
228249
229250
```javascript
230-
// Add scopes for the access token to be used at Microsoft Graph API endpoints.
251+
231252
const tokenRequest = {
232253
scopes: ["Mail.Read"]
233254
};

articles/active-directory/develop/sample-v2-code.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ The following samples show how to protect a web API with the Microsoft identity
110110
| ![This image shows the ASP.NET Core logo](media/sample-v2-code/logo_NETcore.png)</p>ASP.NET Core 2.2 | ASP.NET Core web API (service) of [dotnet-native-aspnetcore-v2](https://aka.ms/msidentity-aspnetcore-webapi-calls-msgraph) |
111111
| ![This image shows the ASP.NET logo](media/sample-v2-code/logo_NET.png)</p>ASP.NET MVC | Web API (service) of [ms-identity-aspnet-webapi-onbehalfof](https://github.com/Azure-Samples/ms-identity-aspnet-webapi-onbehalfof) |
112112
| ![This image shows the Java logo](media/sample-v2-code/logo_java.png) | Web API (service) of [ms-identity-java-webapi](https://github.com/Azure-Samples/ms-identity-java-webapi) |
113+
| ![This image shows the Node.js logo](media/sample-v2-code/logo_nodejs.png) | Web API (service) of [active-directory-javascript-nodejs-webapi-v2](https://github.com/Azure-Samples/active-directory-javascript-nodejs-webapi-v2) |
113114

114115
## Azure Functions as web APIs
115116

articles/active-directory/saas-apps/amazon-web-service-tutorial.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,10 @@ In this section, you'll enable B.Simon to use Azure single sign-on by granting a
334334
![Screenshot of Settings section, with On highlighted](./media/amazon-web-service-tutorial/provisioning2.png)
335335

336336
> [!NOTE]
337-
> Provisioning service will only import roles from AWS to Azure AD. This service will not provision users and groups from Azure AD back to AWS.
337+
> The provisioning service imports roles only from AWS to Azure AD. The service does not provision users and groups from Azure AD to AWS.
338+
339+
> [!NOTE]
340+
> After you save the provisioning credentials, you must wait for the initial sync cycle to run. Sync usually takes around 40 minutes to finish. You can see the status at the bottom of the **Provisioning** page, under **Current Status**.
338341

339342
### Create Amazon Web Services (AWS) test user
340343

@@ -394,4 +397,4 @@ When you click the Amazon Web Services (AWS) tile in the Access Panel, you shoul
394397
[38]: ./media/amazon-web-service-tutorial/tutorial_amazonwebservices_createnewaccesskey.png
395398
[39]: ./media/amazon-web-service-tutorial/tutorial_amazonwebservices_provisioning_automatic.png
396399
[40]: ./media/amazon-web-service-tutorial/tutorial_amazonwebservices_provisioning_testconnection.png
397-
[41]: ./media/amazon-web-service-tutorial/tutorial_amazonwebservices_provisioning_on.png
400+
[41]: ./media/amazon-web-service-tutorial/tutorial_amazonwebservices_provisioning_on.png

articles/aks/operator-best-practices-storage.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ When you need to attach storage to pods, you use persistent volumes. These persi
7171

7272
![Persistent volume claims in an Azure Kubernetes Services (AKS) cluster](media/concepts-storage/persistent-volume-claims.png)
7373

74-
A persistent volume claim (PVC) lets you dynamically create storage as needed. The underlying Azure disks are created as pods request them. In the pod definition, you request a volume to be created and attached to a designed mount path
74+
A persistent volume claim (PVC) lets you dynamically create storage as needed. The underlying Azure disks are created as pods request them. In the pod definition, you request a volume to be created and attached to a designated mount path.
7575

7676
For the concepts on how to dynamically create and use volumes, see [Persistent Volumes Claims][aks-concepts-storage-pvcs].
7777

articles/backup/backup-configure-vault.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ The data that's available for backup depends on where the agent is installed.
4747
If your machine has limited internet access, ensure that firewall settings on the machine or proxy allow the following URLs and IP addresses:
4848

4949
* URLs
50-
* `www\.msftncsi.com`
50+
* `www.msftncsi.com`
5151
* `*.Microsoft.com`
5252
* `*.WindowsAzure.com`
5353
* `*.microsoftonline.com`

articles/cognitive-services/QnAMaker/How-To/edit-knowledge-base.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ QnA Maker allows you to manage the content of your knowledge base by providing a
3636
|Delete URL|You can delete existing URLs by selecting the delete icon, the trash can.|
3737
|Refresh content|If you want your knowledge base to crawl the latest content of existing URLs, select the **Refresh** checkbox. This will update the knowledge base with latest URL content once. This is not setting a regular schedule of updates.|
3838
|Add file|You can add a supported file document to be part of a knowledge base, by selecting **Manage knowledge base**, then selecting **+ Add File**|
39-
|Import|You can also import any existing knowledge base by selecting **Ímport Knowledge base** button. |
39+
|Import|You can also import any existing knowledge base by selecting **Import Knowledge base** button. |
4040
|Update|Updating of knowledge base depends on **management pricing tier** used while creating QnA Maker service associated with your knowledge base. You can also update the management tier from Azure portal if required.
4141

4242
1. Once you are done making changes to the knowledge base, select **Save and train** in the top right corner of the page in order to persist the changes.

articles/data-factory/control-flow-webhook-activity.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,11 @@ Azure Data Factory will pass an additional property “callBackUri” in the bod
112112

113113
The webhook activity itself fails when the call to the custom endpoint fails. Any error message can be added into the body of the callback and used in a subsequent activity.
114114

115+
Further for every REST API call the client will timeout if the endpoint doesn't respond in 1 min. This is standard http best practice.
116+
To fix this issue, you need to implement 202 pattern in this case where the endpoint will return 202 (Accepted) and the client will poll.
117+
118+
The 1 min timeout on the request doesn't have anything to do with the activity timeout. That will be used to wait for the callbackUri.
119+
115120
The body passed back to the callback URI should be valid JSON. You must set the Content-Type header to `application/json`.
116121

117122
When you use the "Report status on callback" option, you must add the following snippet to the body when making the callback:

0 commit comments

Comments
 (0)