Skip to content

Commit 3a911c3

Browse files
committed
[Dev Space] updated secrets for github actions
1 parent 8eb6731 commit 3a911c3

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

articles/dev-spaces/how-to/github-actions.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
title: "GitHub Actions & Azure Kubernetes Service"
33
services: azure-dev-spaces
4-
ms.date: 11/04/2019
4+
ms.date: 02/04/2020
55
ms.topic: conceptual
66
description: "Review and test changes from a pull request directly in Azure Kubernetes Service using GitHub Actions and Azure Dev Spaces"
77
keywords: "Docker, Kubernetes, Azure, AKS, Azure Kubernetes Service, containers, GitHub Actions, Helm, service mesh, service mesh routing, kubectl, k8s"
@@ -52,14 +52,13 @@ az ad sp create-for-rbac --sdk-auth --skip-assignment
5252

5353
Save the JSON output because it is used in a later step.
5454

55-
56-
Use [az aks show][az-aks-show] to display the *id* of your AKS cluster:
55+
Use [az aks show][az-aks-show] to display the *ID* of your AKS cluster:
5756

5857
```cmd
5958
az aks show -g MyResourceGroup -n MyAKS --query id
6059
```
6160

62-
Use [az acr show][az-acr-show] to display the *id* of the ACR:
61+
Use [az acr show][az-acr-show] to display the *ID* of the ACR:
6362

6463
```cmd
6564
az acr show --name <acrName> --query id
@@ -87,7 +86,6 @@ Navigate to your forked repository and click *Settings*. Click on *Secrets* in t
8786
1. *CLUSTER_NAME*: the name of your AKS cluster, which in this example is *MyAKS*.
8887
1. *CONTAINER_REGISTRY*: the *loginServer* for the ACR.
8988
1. *HOST*: the host for your Dev Space, which takes the form *<MASTER_SPACE>.<APP_NAME>.<HOST_SUFFIX>*, which in this example is *dev.bikesharingweb.fedcab0987.eus.azds.io*.
90-
1. *HOST_SUFFIX*: the host suffix for your Dev Space, which in this example is *fedcab0987.eus.azds.io*.
9189
1. *IMAGE_PULL_SECRET*: the name of the secret you wish to use, for example *demo-secret*.
9290
1. *MASTER_SPACE*: the name of your parent Dev Space, which in this example is *dev*.
9391
1. *REGISTRY_USERNAME*: the *clientId* from the JSON output from the service principal creation.
@@ -96,6 +94,8 @@ Navigate to your forked repository and click *Settings*. Click on *Secrets* in t
9694
> [!NOTE]
9795
> All of these secrets are used by the GitHub action and are configured in [.github/workflows/bikes.yml][github-action-yaml].
9896
97+
Optionally, if you want to update the master space after your PR is merged, add the *GATEWAY_HOST* secret, which takes the form *<MASTER_SPACE>.gateway.<HOST_SUFFIX>*, which in this example is *dev.gateway.fedcab0987.eus.azds.io*. Once you merge your changes into the master branch in your fork, another action will run to rebuild and run your entire application in the master dev space. In this example, the master space is *dev*. This action is configured in [.github/workflows/bikesharing.yml][github-action-bikesharing-yaml].
98+
9999
## Create a new branch for code changes
100100

101101
Navigate to `BikeSharingApp/` and create a new branch called *bike-images*.

0 commit comments

Comments
 (0)