Skip to content

Commit 3b8cb0d

Browse files
Apply suggestions from code review
Co-authored-by: Marina Bashtovaya <[email protected]>
1 parent a1888ca commit 3b8cb0d

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

articles/operator-nexus/howto-baremetal-run-read.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,13 +78,15 @@ These commands do not require `arguments`:
7878

7979
All other inputs are required.
8080

81-
Multiple commands can be provided in json format to `--commands` option. Each `command` specifies command and the arguments.
81+
Multiple commands can be provided in json format to `--commands` option.
8282

8383
For a command with multiple arguments, provide as a list to `arguments` parameter. See [Azure CLI Shorthand](https://github.com/Azure/azure-cli/blob/dev/doc/shorthand_syntax.md) for instructions on constructing the `--commands` structure.
8484

85-
These commands can be long running so the recommendation is to set `--limit-time-seconds` to at least 600 seconds (10 minutes). The `Debug` option or running multiple extracts might take longer that 10 minutes.
85+
These commands can be long running so the recommendation is to set `--limit-time-seconds` to at least 600 seconds (10 minutes). Running multiple extracts might take longer that 10 minutes.
8686

87-
This command runs synchronously. If you wish to skip waiting for the command to complete, specify the `--no-wait` option.
87+
This command runs synchronously. If you wish to skip waiting for the command to complete, specify the `--no-wait --debug` options. In that case, follow the instructions on [how to track asynchronous operation](https://learn.microsoft.com/en-us/azure/operator-nexus/howto-track-async-operations-cli).
88+
89+
When an optional argument `--output-directory` is provided, the output result will be downloaded and extracted to the local directory.
8890

8991
### This example executes the `hostname` command and a `ping` command.
9092

@@ -101,7 +103,7 @@ In the response, an HTTP status code of 202 is returned as the operation is perf
101103
## Checking command status and viewing output
102104

103105

104-
Sample output looks something like this and provides a link to the zipped output file(tar.gz) from the command execution. The tar.gz file name can be used to identify the file in the Storage account of the Cluster Manager resource group. You can also use the link to directly access the output zip file. Download the output file from storage blob to a local directory by specifying the directory path in the optional argument `--output-directory`.
106+
Sample output looks something like below. It prints the top 5K characters of the result to the screen for convenience and provides a short-lived link to the storage blob containing the command execution result. You can use the link to download the zipped output file (tar.gz).
105107

106108
```azurecli
107109
====Action Command Output====
@@ -117,7 +119,7 @@ Sample output looks something like this and provides a link to the zipped output
117119
118120
================================
119121
Script execution result can be found in storage account:
120-
https://cm49vr6vnc6kst.blob.core.windows.net/bmm-run-command-output/a8e0a5fe-3279-46a8-b995-51f2f98a18dd-action-bmmrunreadcmd.tar.gz?se=2023-04-14T06%3A37%3A00Z&sig=ZlN6t%2F534OpmEE545Xie7feHupKSU4v6XYfZTKG6WVo%3D&sp=r&spr=https&sr=b&st=2023-04-14T02%3A37%3A00Z&sv=2019-12-12
122+
https://<storage_account_name>.blob.core.windows.net/bmm-run-command-output/a8e0a5fe-3279-46a8-b995-51f2f98a18dd-action-bmmrunreadcmd.tar.gz?se=2023-04-14T06%3A37%3A00Z&sig=XXX&sp=r&spr=https&sr=b&st=2023-04-14T02%3A37%3A00Z&sv=2019-12-12
121123
```
122124

123125
See [How To BareMetal Review Output Run-Read](howto-baremetal-review-read-output.md) for instructions on locating the output file in the Storage Account. You can also use the link to directly access the output zip file.

articles/operator-nexus/howto-cluster-metrics-configuration-management.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ az networkcloud cluster metricsconfiguration create \
4949
> * There can be only one set of metrics configuration defined per cluster. The resource is created with the name `default`.
5050
5151

52-
Specifying `--debug` in az cli command will result in the tracking operation status in the returned command output. This operation status can be queried to monitor the progress of the operation. See: [How-to track asynchronous operations](howto-track-async-operations-cli.md).
52+
Specifying `--no-wait --debug` options in az cli command will result in the execution of this command asynchronously. See [how to track asynchronous operations](howto-track-async-operations-cli.md) for more details.
5353

5454
## Retrieving a metrics configuration
5555

@@ -79,7 +79,7 @@ az networkcloud cluster metricsconfiguration update \
7979
--resource-group "<RESOURCE_GROUP>"
8080
```
8181

82-
The change may include either or both of the updatable fields, `collectionInterval` or `enabledMetrics`. The `collectionInterval` can be updated independently of `enabledMetrics`. Omit fields that aren't being changed.
82+
The `collection-interval` can be updated independently of `enabled-metrics` list. Omit fields that aren't being changed.
8383

8484
Specifying `--debug` in az cli will result in the tracking operation status in the returned command output. This operation status can be queried to monitor the progress of the operation. See: [How-to track asynchronous operations](howto-track-async-operations-cli.md).
8585

0 commit comments

Comments
 (0)