Skip to content

Commit 3ddce1e

Browse files
committed
added feedback from Ramya and Atchut
1 parent 348904e commit 3ddce1e

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

articles/marketplace/azure-container-plan-technical-configuration-kubernetes.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ For more, see [Prepare Azure Kubernetes technical assets](azure-container-techni
1717

1818
## Setting cluster extension type name
1919

20-
Cluster extensions enable an Azure Resource Manager driven experience for your application. The following limitations apply when setting the cluster extension type name value:
20+
[Cluster extensions][cluster-extensions] enable an Azure Resource Manager driven experience for your application. The following limitations apply when setting the cluster extension type name value:
2121

2222
- You must provide the cluster extension type name in the format of 'PublisherName.ApplicationName'.
2323

@@ -41,4 +41,7 @@ Select *Add CNAB Bundle* to select the payload reference like so:
4141
## Next steps
4242

4343
- To **Co-sell with Microsoft** (optional), select it in the left-nav menu. For details, see [Co-sell partner engagement](/partner-center/co-sell-overview?context=/azure/marketplace/context/context).
44-
- If you're not setting up either of these or you've finished, it's time to [Review and publish your offer](review-publish-offer.md).
44+
- If you're not setting up either of these or you've finished, it's time to [Review and publish your offer](review-publish-offer.md).
45+
46+
<!-- LINKS -->
47+
[cluster-extensions]: ../aks/cluster-extensions.md

articles/marketplace/azure-container-technical-assets-kubernetes.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ In addition to your solution domain, your engineering team should have knowledge
2727
- Working knowledge of [JSON](https://www.json.org/)
2828
- Working knowledge of [Helm](https://www.helm.sh)
2929
- Working knowledge of [createUiDefinition][createuidefinition]
30+
- Working knowledge of [Azure Resource Manager (ARM) templates][arm-templates]
3031

3132
## Prerequisites
3233

@@ -72,6 +73,7 @@ Microsoft has created a first-party application responsible for handling this pr
7273
> [!NOTE]
7374
> If your account doesn't have permission to create a service principal, `az ad sp create` will return an error message containing "Insufficient privileges to complete the operation". Contact your Azure Active Directory admin to create a service principal.
7475
76+
7577
```azurecli-interactive
7678
az login
7779
az ad sp create --id 32597670-3e15-4def-8851-614ff48c1efa
@@ -94,7 +96,9 @@ Your output should look similar to the following:
9496
...
9597
```
9698

97-
Finally, create a role assignment to grant the service principal the ability to pull from your registry using the values you obtained earlier:
99+
Next, create a role assignment to grant the service principal the ability to pull from your registry using the values you obtained earlier:
100+
101+
[!INCLUDE [Azure role assignment prerequisites](../../includes/role-based-access-control/prerequisites-role-assignments.md)]
98102

99103
```azurecli-interactive
100104
az role assignment create --assignee <sp-id> --scope <registry-id> --role acrpull
@@ -147,6 +151,8 @@ Your output should look similar to the following:
147151

148152
Next, create a role assignment to grant the service principal the ability to pull from your registry:
149153

154+
[!INCLUDE [Azure role assignment prerequisites](../../includes/role-based-access-control/prerequisites-role-assignments.md)]
155+
150156
```powershell-interactive
151157
New-AzRoleAssignment -ObjectId <sp-id> -Role acrpull -Scope <registry-id>
152158
```
@@ -329,7 +335,7 @@ For an example of how to integrate `container-package-app` into an Azure Pipelin
329335

330336
[cnab]: https://cnab.io/
331337
[cluster-extensions]: ../aks/cluster-extensions.md
332-
[azure-voting-app]: https://github.com/Azure-Samples/azure-voting-app-redis
338+
[azure-voting-app]: https://github.com/Azure-Samples/kubernetes-offer-samples/tree/main/samples/k8s-offer-azure-vote/azure-vote
333339
[createuidefinition]: ../azure-resource-manager/managed-applications/create-uidefinition-overview.md
334340
[sandbox-environment]: https://ms.portal.azure.com/#view/Microsoft_Azure_CreateUIDef/SandboxBlade
335341
[arm-template-overview]: ../azure-resource-manager/templates/overview.md
7.17 KB
Loading

0 commit comments

Comments
 (0)