Skip to content

Commit 3e22e76

Browse files
committed
integrating review fedback
1 parent bacd80c commit 3e22e76

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

articles/digital-twins/how-to-integrate-azure-signalr.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ Leave the browser window open to the Azure portal, as you'll use it again in the
6161
## Publish and configure the Azure Functions app
6262

6363
In this section, you'll set up two Azure functions:
64-
* negotiate - A HTTP trigger function. It uses the *SignalRConnectionInfo* input binding to generate and return valid connection information.
65-
* broadcast - An [Event Grid](../event-grid/overview.md) trigger function. It receives Azure Digital Twins telemetry data through the event grid, and uses the output binding of the SignalR instance you created in the previous step to broadcast the message to all connected client applications.
64+
* *negotiate* - A HTTP trigger function. It uses the *SignalRConnectionInfo* input binding to generate and return valid connection information.
65+
* *broadcast* - An [Event Grid](../event-grid/overview.md) trigger function. It receives Azure Digital Twins telemetry data through the event grid, and uses the output binding of the SignalR instance you created in the previous step to broadcast the message to all connected client applications.
6666

6767
Start Visual Studio (or another code editor of your choice), and open the code solution in the *digital-twins-samples-master > ADTSampleApp* folder. Then do the following steps to create the functions:
6868

@@ -103,9 +103,9 @@ Next, configure the function to communicate with your Azure SignalR instance. Yo
103103
104104
## Connect the function to Event Grid
105105
106-
Next, subscribe the "broadcast" Azure function to the Event Grid topic you created during the [tutorial prerequisite](how-to-integrate-azure-signalr.md#prerequisites). This action will allow telemetry data to flow from the thermostat67 twin through the Event Grid topic and to the function. From here, the function can broadcast the data to all the clients.
106+
Next, subscribe the *broadcast* Azure function to the Event Grid topic you created during the [tutorial prerequisite](how-to-integrate-azure-signalr.md#prerequisites). This action will allow telemetry data to flow from the thermostat67 twin through the Event Grid topic and to the function. From here, the function can broadcast the data to all the clients.
107107
108-
To broadcast the data, you'll create an Event subscription from your Event Grid topic to your "broadcast" Azure function as an endpoint.
108+
To broadcast the data, you'll create an Event subscription from your Event Grid topic to your *broadcast* Azure function as an endpoint.
109109
110110
In the [Azure portal](https://portal.azure.com/), navigate to your Event Grid topic by searching for its name in the top search bar. Select **+ Event Subscription**.
111111
@@ -115,7 +115,7 @@ On the **Create Event Subscription** page, fill in the fields as follows (fields
115115
* **EVENT SUBSCRIPTION DETAILS** > **Name**: Give a name to your event subscription.
116116
* **ENDPOINT DETAILS** > **Endpoint Type**: Select **Azure Function** from the menu options.
117117
* **ENDPOINT DETAILS** > **Endpoint**: Select the **Select an endpoint** link, which will open a **Select Azure Function** window:
118-
- Fill in your **Subscription**, **Resource group**, **Function app**, and **Function** (*broadcast*). Some of these fields may autopopulate after selecting the subscription.
118+
- Fill in your **Subscription**, **Resource group**, **Function app**, and **Function** (**broadcast**). Some of these fields may autopopulate after selecting the subscription.
119119
- Select **Confirm Selection**.
120120
121121
:::image type="content" source="media/how-to-integrate-azure-signalr/create-event-subscription.png" alt-text="Screenshot of the form for creating an event subscription in the Azure portal.":::
@@ -132,7 +132,7 @@ In this section, you'll see the result in action. First, configure the sample cl
132132
133133
### Configure the sample client web app
134134
135-
Next, you'll configure the sample client web app. Start by gathering the HTTP endpoint URL of the "negotiate" function, and then use it to configure the app code on your machine.
135+
Next, you'll configure the sample client web app. Start by gathering the HTTP endpoint URL of the *negotiate* function, and then use it to configure the app code on your machine.
136136
137137
1. Go to the Azure portal's [Function apps](https://portal.azure.com/#blade/HubsExtension/BrowseResource/resourceType/Microsoft.Web%2Fsites/kind/functionapp) page and select your function app from the list. In the app menu, select **Functions** and choose the **negotiate** function.
138138
@@ -144,7 +144,7 @@ Next, you'll configure the sample client web app. Start by gathering the HTTP en
144144
145145
1. Using Visual Studio or any code editor of your choice, open the unzipped _**digitaltwins-signalr-webapp-sample-main**_ folder that you downloaded in the [Download the sample applications](#download-the-sample-applications) section.
146146
147-
1. Open the *src/App.js* file, and replace the function URL in `HubConnectionBuilder` with the HTTP endpoint URL of the "negotiate" function that you saved in the previous step:
147+
1. Open the *src/App.js* file, and replace the function URL in `HubConnectionBuilder` with the HTTP endpoint URL of the **negotiate** function that you saved in the previous step:
148148
149149
```javascript
150150
const hubConnection = new HubConnectionBuilder()

articles/digital-twins/reference-query-clause-match.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ For more detail about each type of relationship condition and how to combine the
6060

6161
Here is an example query using `MATCH`.
6262

63-
The query specifies a [relationship direction](#specify-relationship-direction), and searches for Building and Sensor Twins where...
63+
The query specifies a [relationship direction](#specify-relationship-direction), and searches for Building and Sensor twins where...
6464
* the Sensor is targeted by any relationship from a Building twin with a `$dtId` of Building21, and
6565
* the Sensor has a temperature above 50.
6666
The Building and Sensor are both included in the query result.

articles/digital-twins/tutorial-end-to-end.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ You can now stop running the project. Keep the solution open in Visual Studio, t
9191
## Set up the sample function app
9292

9393
The next step is setting up an [Azure Functions app](../azure-functions/functions-overview.md) that will be used throughout this tutorial to process data. The function app, SampleFunctionsApp, contains two functions:
94-
* ProcessHubToDTEvents: processes incoming IoT Hub data and updates Azure Digital Twins accordingly
95-
* ProcessDTRoutedData: processes data from digital twins, and updates the parent twins in Azure Digital Twins accordingly
94+
* *ProcessHubToDTEvents*: processes incoming IoT Hub data and updates Azure Digital Twins accordingly
95+
* *ProcessDTRoutedData*: processes data from digital twins, and updates the parent twins in Azure Digital Twins accordingly
9696

9797
In this section, you'll publish the pre-written function app, and ensure the function app can access Azure Digital Twins by assigning it an Azure Active Directory (Azure AD) identity. Completing these steps will allow the rest of the tutorial to use the functions inside the function app.
9898

@@ -227,7 +227,7 @@ The output is the list of settings for the Azure Function, which should now cont
227227

228228
An Azure Digital Twins graph is meant to be driven by telemetry from real devices.
229229

230-
In this step, you'll connect a simulated thermostat device registered in [IoT Hub](../iot-hub/about-iot-hub.md) to the digital twin that represents it in Azure Digital Twins. As the simulated device emits telemetry, the data will be directed through the ProcessHubToDTEvents Azure function that triggers a corresponding update in the digital twin. In this way, the digital twin stays up to date with the real device's data. In Azure Digital Twins, the process of directing events data from one place to another is called [routing events](concepts-route-events.md).
230+
In this step, you'll connect a simulated thermostat device registered in [IoT Hub](../iot-hub/about-iot-hub.md) to the digital twin that represents it in Azure Digital Twins. As the simulated device emits telemetry, the data will be directed through the *ProcessHubToDTEvents* Azure function that triggers a corresponding update in the digital twin. In this way, the digital twin stays up to date with the real device's data. In Azure Digital Twins, the process of directing events data from one place to another is called [routing events](concepts-route-events.md).
231231

232232
Processing the simulated telemetry happens in this part of the end-to-end scenario (**arrow B**):
233233

@@ -256,7 +256,7 @@ Save the **name** that you gave to your IoT hub. You'll use it later.
256256

257257
### Connect the IoT hub to the Azure function
258258

259-
Next, connect your IoT hub to the ProcessHubToDTEvents Azure function in the function app you published earlier, so that data can flow from the device in IoT Hub through the function, which updates Azure Digital Twins.
259+
Next, connect your IoT hub to the *ProcessHubToDTEvents* Azure function in the function app you published earlier, so that data can flow from the device in IoT Hub through the function, which updates Azure Digital Twins.
260260

261261
To do so, you'll create an *Event Subscription* on your IoT Hub, with the Azure function as an endpoint. This "subscribes" the function to events happening in IoT Hub.
262262

@@ -275,7 +275,7 @@ Fill in the fields as follows (fields filled by default aren't mentioned):
275275
* **ENDPOINT DETAILS** > **Endpoint Type**: Select **Azure Function** from the menu options.
276276
* **ENDPOINT DETAILS** > **Endpoint**: Select the **Select an endpoint** link, which will open a **Select Azure Function** window:
277277
:::image type="content" source="media/tutorial-end-to-end/event-subscription-3.png" alt-text="Screenshot of the Azure portal event subscription showing the window to select an Azure function." border="false":::
278-
- Fill in your **Subscription**, **Resource group**, **Function app**, and **Function** (*ProcessHubToDTEvents*). Some of these values may auto-populate after selecting the subscription.
278+
- Fill in your **Subscription**, **Resource group**, **Function app**, and **Function** (**ProcessHubToDTEvents**). Some of these values may auto-populate after selecting the subscription.
279279
- Select **Confirm Selection**.
280280

281281
Back on the **Create Event Subscription** page, select **Create**.
@@ -336,7 +336,7 @@ You don't need to do anything else in this console, but leave it running while y
336336

337337
### See the results in Azure Digital Twins
338338

339-
The ProcessHubToDTEvents function you published earlier listens to the IoT Hub data, and calls an Azure Digital Twins API to update the `Temperature` property on the thermostat67 twin.
339+
The *ProcessHubToDTEvents* function you published earlier listens to the IoT Hub data, and calls an Azure Digital Twins API to update the `Temperature` property on the thermostat67 twin.
340340

341341
To see the data from the Azure Digital Twins side, go to your Visual Studio window where the *AdtE2ESample.sln* solution is open and run the SampleClientApp project.
342342

@@ -359,7 +359,7 @@ Once you've verified the live temperatures logging is working successfully, you
359359

360360
So far in this tutorial, you've seen how Azure Digital Twins can be updated from external device data. Next, you'll see how changes to one digital twin can propagate through the Azure Digital Twins graph—in other words, how to update twins from service-internal data.
361361

362-
To do so, you'll use the ProcessDTRoutedData Azure function to update a Room twin when the connected Thermostat twin is updated. The update functionality happens in this part of the end-to-end scenario (**arrow C**):
362+
To do so, you'll use the *ProcessDTRoutedData* Azure function to update a Room twin when the connected Thermostat twin is updated. The update functionality happens in this part of the end-to-end scenario (**arrow C**):
363363

364364
:::image type="content" source="media/tutorial-end-to-end/building-scenario-c.png" alt-text="Diagram of an excerpt from the full building scenario diagram highlighting the section that shows the elements after Azure Digital Twins.":::
365365

@@ -373,9 +373,9 @@ Here are the actions you'll complete to set up this data flow:
373373

374374
### Connect the Azure function
375375

376-
Next, subscribe the ProcessDTRoutedData Azure function to the event grid topic you created earlier, so that telemetry data can flow from the thermostat67 twin through the event grid topic to the function, which goes back into Azure Digital Twins and updates the room21 twin accordingly.
376+
Next, subscribe the *ProcessDTRoutedData* Azure function to the event grid topic you created earlier, so that telemetry data can flow from the thermostat67 twin through the event grid topic to the function, which goes back into Azure Digital Twins and updates the room21 twin accordingly.
377377

378-
To do so, you'll create an Event Grid subscription that sends data from the event grid topic that you created earlier to your ProcessDTRoutedData Azure function.
378+
To do so, you'll create an Event Grid subscription that sends data from the event grid topic that you created earlier to your *ProcessDTRoutedData* Azure function.
379379

380380
In the [Azure portal](https://portal.azure.com/), navigate to your event grid topic by searching for its name in the top search bar. Select **+ Event Subscription**.
381381

@@ -387,7 +387,7 @@ On the **Create Event Subscription** page, fill in the fields as follows (fields
387387
* **EVENT SUBSCRIPTION DETAILS** > **Name**: Give a name to your event subscription.
388388
* **ENDPOINT DETAILS** > **Endpoint Type**: Select **Azure Function** from the menu options.
389389
* **ENDPOINT DETAILS** > **Endpoint**: Select the **Select an endpoint** link, which will open a **Select Azure Function** window:
390-
- Fill in your **Subscription**, **Resource group**, **Function app**, and **Function** (*ProcessDTRoutedData*). Some of these values may auto-populate after selecting the subscription.
390+
- Fill in your **Subscription**, **Resource group**, **Function app**, and **Function** (**ProcessDTRoutedData**). Some of these values may auto-populate after selecting the subscription.
391391
- Select **Confirm Selection**.
392392

393393
Back on the **Create Event Subscription** page, select **Create**.
@@ -423,8 +423,8 @@ Once you've verified the live temperatures logging from your instance is working
423423
Here's a review of the scenario that you built out in this tutorial.
424424

425425
1. An Azure Digital Twins instance digitally represents a floor, a room, and a thermostat (represented by **section A** in the diagram below)
426-
2. Simulated device telemetry is sent to IoT Hub, where the ProcessHubToDTEvents Azure function is listening for telemetry events. The ProcessHubToDTEvents Azure function uses the information in these events to set the `Temperature` property on thermostat67 (**arrow B** in the diagram).
427-
3. Property change events in Azure Digital Twins are routed to an event grid topic, where the ProcessDTRoutedData Azure function is listening for events. The ProcessDTRoutedData Azure function uses the information in these events to set the `Temperature` property on room21 (**arrow C** in the diagram).
426+
2. Simulated device telemetry is sent to IoT Hub, where the *ProcessHubToDTEvents* Azure function is listening for telemetry events. The *ProcessHubToDTEvents* Azure function uses the information in these events to set the `Temperature` property on thermostat67 (**arrow B** in the diagram).
427+
3. Property change events in Azure Digital Twins are routed to an event grid topic, where the *ProcessDTRoutedData* Azure function is listening for events. The *ProcessDTRoutedData* Azure function uses the information in these events to set the `Temperature` property on room21 (**arrow C** in the diagram).
428428

429429
:::image type="content" source="media/tutorial-end-to-end/building-scenario.png" alt-text="Diagram of the full building scenario, which shows the data flowing from a device into and out of Azure Digital Twins through various Azure services.":::
430430

0 commit comments

Comments
 (0)