Skip to content

Commit 440c9df

Browse files
committed
Updated per review comments
1 parent d4aab16 commit 440c9df

File tree

1 file changed

+17
-19
lines changed

1 file changed

+17
-19
lines changed

articles/communication-services/quickstarts/rooms/manage-rooms-call.md

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ CreateCallResult response = await client.GetCallConnection(callConnectionId).Add
8585

8686
```java
8787
PhoneNumberIdentifier callerIdNumber = new PhoneNumberIdentifier("+16044561234"); // This is the ACS-provisioned phone number for the caller
88-
CallInvite callInvite = new CallInvite(new PhoneNumberIdentifier("+16041234567"), callerIdNumber);
88+
CallInvite callInvite = new CallInvite(new PhoneNumberIdentifier("+16041234567"), callerIdNumber); // The phone number participant to dial out to
8989
AddParticipantOptions addParticipantOptions = new AddParticipantOptions(callInvite);
9090
Response<AddParticipantResult> addParticipantResultResponse = client.getCallConnectionAsync(callConnectionId)
9191
.addParticipantWithResponse(addParticipantOptions).block();
@@ -95,7 +95,7 @@ Response<AddParticipantResult> addParticipantResultResponse = client.getCallConn
9595

9696
```javascript
9797
const callInvite = {
98-
targetParticipant: { phoneNumber: "+18008008800" }, // The target phone number to dial out to
98+
targetParticipant: { phoneNumber: "+18008008800" }, // The phone number participant to dial out to
9999
sourceCallIdNumber: { phoneNumber: "+18888888888" } // This is the ACS-provisioned phone number for the caller
100100
};
101101
const response = await client.getCallConnection(callConnectionId).addParticipant(callInvite);
@@ -107,7 +107,7 @@ const response = await client.getCallConnection(callConnectionId).addParticipant
107107
caller_id_number = PhoneNumberIdentifier(
108108
"+18888888888"
109109
) # TThis is the ACS-provisioned phone number for the caller
110-
target = PhoneNumberIdentifier("+18008008800"),
110+
target = PhoneNumberIdentifier("+18008008800"), # The phone number participant to dial out to
111111

112112
call_connection_client = call_automation_client.get_call_connection(
113113
"call_connection_id"
@@ -132,7 +132,7 @@ var removeThisUser = new PhoneNumberIdentifier("+16044561234");
132132
var removeParticipantOptions = new RemoveParticipantOptions(removeThisUser)
133133
{
134134
OperationContext = "operationContext",
135-
OperationCallbackUri = new Uri("uri_endpoint"); // Sending event to a non-default endpoint.
135+
OperationCallbackUri = new Uri("uri_endpoint"); // Sending event to a non-default endpoint
136136
}
137137

138138
RemoveParticipantsResult result = await client.GetCallConnection(callConnectionId).RemoveParticipantAsync(removeParticipantOptions);
@@ -235,15 +235,15 @@ StartRecordingOptions recordingOptions = new StartRecordingOptions(new ServerCal
235235
Response<RecordingStateResult> response = await callAutomationClient.GetCallRecording()
236236
.StartAsync(recordingOptions);
237237

238-
// Stop recording using recordingId received in response of start recording.
239-
var stopRecording = await callAutomationClient.GetCallRecording().StopAsync(recordingId);
240-
241238
// Pause recording using recordingId received in response of start recording.
242239
var pauseRecording = await callAutomationClient.GetCallRecording ().PauseAsync(recordingId);
243240

244241
// Resume recording using recordingId received in response of start recording.
245242
var resumeRecording = await callAutomationClient.GetCallRecording().ResumeAsync(recordingId);
246243

244+
// Stop recording using recordingId received in response of start recording.
245+
var stopRecording = await callAutomationClient.GetCallRecording().StopAsync(recordingId);
246+
247247
```
248248
### [Java](#tab/java)
249249
```java
@@ -257,10 +257,6 @@ StartRecordingOptions recordingOptions = new StartRecordingOptions(new ServerCal
257257
Response<RecordingStateResult> response = callAutomationClient.getCallRecording()
258258
.startWithResponse(recordingOptions, null);
259259

260-
// Stop recording using recordingId received in response of start recording
261-
Response<Void> response = callAutomationClient.getCallRecording()
262-
.stopWithResponse(recordingId, null);
263-
264260
// Pause recording using recordingId received in response of start recording
265261
Response<Void> response = callAutomationClient.getCallRecording()
266262
.pauseWithResponse(recordingId, null);
@@ -269,6 +265,10 @@ Response<Void> response = callAutomationClient.getCallRecording()
269265
Response<Void> response = callAutomationClient.getCallRecording()
270266
.resumeWithResponse(recordingId, null);
271267

268+
// Stop recording using recordingId received in response of start recording
269+
Response<Void> response = callAutomationClient.getCallRecording()
270+
.stopWithResponse(recordingId, null);
271+
272272
```
273273
### [JavaScript](#tab/javascript)
274274
```javascript
@@ -285,15 +285,15 @@ var options: StartRecordingOptions =
285285
};
286286
var response = await callAutomationClient.getCallRecording().start(options);
287287

288-
// Stop recording using recordingId received in response of start recording
289-
var stopRecording = await callAutomationClient.getCallRecording().stop(recordingId);
290-
291288
// Pause recording using recordingId received in response of start recording
292289
var pauseRecording = await callAutomationClient.getCallRecording().pause(recordingId);
293290

294291
// Resume recording using recordingId received in response of start recording.
295292
var resumeRecording = await callAutomationClient.getCallRecording().resume(recordingId);
296293

294+
// Stop recording using recordingId received in response of start recording
295+
var stopRecording = await callAutomationClient.getCallRecording().stop(recordingId);
296+
297297
```
298298
### [Python](#tab/python)
299299
```python
@@ -304,19 +304,17 @@ response = call_automation_client.start_recording(call_locator=ServerCallLocator
304304
recording_format_type = RecordingFormat.Wav,
305305
recording_state_callback_url = "<CallbackUri>")
306306

307-
# Stop recording using recording_id received in response of start recording
308-
stop_recording = call_automation_client.stop_recording(recording_id = recording_id)
309-
310307
# Pause recording using recording_id received in response of start recording
311308
pause_recording = call_automation_client.pause_recording(recording_id = recording_id)
312309

313310
# Resume recording using recording_id received in response of start recording
314311
resume_recording = call_automation_client.resume_recording(recording_id = recording_id)
312+
313+
# Stop recording using recording_id received in response of start recording
314+
stop_recording = call_automation_client.stop_recording(recording_id = recording_id)
315315
```
316316
-----
317317

318-
319-
320318
### Terminate a Call
321319
You can use the Call Automation SDK Hang Up action to terminate a call. When the Hang Up action completes, the SDK publishes a `CallDisconnected` event.
322320

0 commit comments

Comments
 (0)