Skip to content

Commit 44d4688

Browse files
committed
Addressing comments
1 parent 1e21b7b commit 44d4688

File tree

2 files changed

+16
-13
lines changed

2 files changed

+16
-13
lines changed

articles/azure-monitor/app/opentelemetry-nodejs-migrate.md

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,16 @@ ms.reviewer: mmcc
1010

1111
# Migrating from ApplicationInsights Version 2.X to Azure Monitor OpenTelemetry-based Node.js
1212

13-
This article details two options to upgrade from the Azure Monitor Application Insights Node.js 2.X SDK to OpenTelemetry.
13+
This guide provides two options to upgrade from the Azure Monitor Application Insights Node.js 2.X SDK to OpenTelemetry.
1414

15-
* [Clean install](opentelemetry-nodejs-migrate.md?tabs=clean-install) the [Node.js Azure Monitor OpenTelemetry Distro](https://github.com/microsoft/opentelemetry-azure-monitor-js).
16-
* [Upgrade](opentelemetry-nodejs-migrate.md?tabs=upgrade) to Node.js SDK 3.X.
17-
18-
Upgrading to OpenTelemetry:
19-
20-
> [!div class="checklist"]
21-
> - Maintains compatibility with existing custom events and metrics
22-
> - Provides richer OpenTelemetry instrumentation libraries
23-
> - Ensures eligibility for the latest bug and security fixes
15+
* **Clean install** the [Node.js Azure Monitor OpenTelemetry Distro](https://github.com/microsoft/opentelemetry-azure-monitor-js).
16+
* Remove dependencies on the Application Insights classic API.
17+
* Familiarize yourself with OpenTelemetry APIs and terms.
18+
* Position yourself to use all that OpenTelemetry offers now and in the future.
19+
* **Upgrade** to Node.js SDK 3.X.
20+
* Postpone code changes while preserving compatibility with existing custom events and metrics.
21+
* Access to richer OpenTelemetry instrumentation libraries.
22+
* Maintain eligibility for the latest bug and security fixes.
2423

2524
## [Clean install](#tab/cleaninstall)
2625

@@ -38,7 +37,7 @@ Upgrading to OpenTelemetry:
3837

3938
3. Remove 2.X SDK implementation from your code.
4039

41-
Remove all Application Insights instrumentation from your code. You must delete any sections where the Application Insights client initializes, modifies, or calls.
40+
Remove all Application Insights instrumentation from your code. Delete any sections where the Application Insights client is initialized, modified, or called.
4241

4342
4. Enable Application Insights with the Azure Monitor OpenTelemetry Distro.
4443

@@ -90,7 +89,7 @@ This example shows the equivalent of creating and applying a telemetry processor
9089

9190
```typescript
9291
const applicationInsights = require("applicationinsights");
93-
applicationInsights.setup("YOUR_CONNECTION_STRING"
92+
applicationInsights.setup("YOUR_CONNECTION_STRING");
9493
applicationInsights.defaultClient.addTelemetryProcessor(addCustomProperty);
9594
applicationInsights.start();
9695
@@ -108,7 +107,7 @@ This example shows how to modify an Azure Monitor OpenTelemetry Distro implement
108107
```typescript
109108
import { Context, Span} from "@opentelemetry/api";
110109
import { ReadableSpan, SpanProcessor } from "@opentelemetry/sdk-trace-base";
111-
const { useAzureMonitor, } = require("@azure/monitor-opentelemetry");
110+
const { useAzureMonitor } = require("@azure/monitor-opentelemetry");
112111
113112
class SpanEnrichingProcessor implements SpanProcessor {
114113
forceFlush(): Promise<void> {

articles/azure-monitor/toc.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,10 @@ items:
108108
href: app/java-standalone-telemetry-processors-examples.md
109109
- name: Upgrade from 2.x
110110
href: app/java-standalone-upgrade-from-2x.md
111+
- name: Node.js (supplemental)
112+
items:
113+
- name: Upgrade from SDK 2.X
114+
href: app/opentelemetry-nodejs-migrate.md
111115
- name: Python (supplemental)
112116
items:
113117
- name: Migrate from Opencensus

0 commit comments

Comments
 (0)