Skip to content

Commit 4670845

Browse files
author
Gilca Stefan
committed
PR review comments
1 parent 0da038a commit 4670845

File tree

7 files changed

+24
-25
lines changed

7 files changed

+24
-25
lines changed

articles/communication-services/quickstarts/includes/manage-teams-identity-java.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ ms.custom: include file
1212
ms.author: gistefan
1313
---
1414

15-
## Setting Up prerequisites
15+
## Set up prerequisites
1616

1717
- [Java Development Kit (JDK)](/azure/developer/java/fundamentals/java-jdk-install) version 8 or above.
1818
- [Apache Maven](https://maven.apache.org/download.cgi).
1919

20-
## Setting Up
20+
## Set up
2121

2222
### Create a new Java application
2323

articles/communication-services/quickstarts/includes/manage-teams-identity-js.md

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ ms.custom: include file
1313
ms.author: gistefan
1414
---
1515

16-
## Setting Up prerequisites
16+
## Set up prerequisites
1717

1818
- [Node.js](https://nodejs.org/) Active LTS and Maintenance LTS versions (8.11.1 and 10.14.1 recommended).
1919

20-
## Setting Up
20+
## Set up
2121

2222
### Create a new Node.js Application
2323

@@ -55,21 +55,19 @@ From the project directory:
5555
1. Add a `require` call to load the `CommunicationIdentityClient`
5656
1. Create the structure for the program, including basic exception handling
5757

58-
Use the following code to begin:
59-
60-
```javascript
61-
const { CommunicationIdentityClient } = require('@azure/communication-identity');
62-
const express = require("express");
63-
const msal = require('@azure/msal-node');
64-
65-
const SERVER_PORT = process.env.PORT || 80;
66-
const REDIRECT_URI = "http://localhost";
67-
68-
// Quickstart code goes here
69-
70-
app.listen(SERVER_PORT, () => console.log(`Communication access token application started on ${SERVER_PORT}!`))
71-
72-
```
58+
```javascript
59+
const { CommunicationIdentityClient } = require('@azure/communication-identity');
60+
const express = require("express");
61+
const msal = require('@azure/msal-node');
62+
63+
const SERVER_PORT = process.env.PORT || 80;
64+
const REDIRECT_URI = "http://localhost";
65+
66+
// Quickstart code goes here
67+
68+
app.listen(SERVER_PORT, () => console.log(`Communication access token application started on ${SERVER_PORT}!`))
69+
70+
```
7371

7472
1. Save the new file as `issue-communication-access-token.js` in the `access-tokens-quickstart` directory.
7573

articles/communication-services/quickstarts/includes/manage-teams-identity-net.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ ms.custom: include file
1313
ms.author: gistefan
1414
---
1515

16-
## Setting Up prerequisites
16+
## Set up prerequisites
1717

1818
- The latest version [.NET SDK](https://dotnet.microsoft.com/download/dotnet) for your operating system.
1919

20-
## Setting Up
20+
## Set up
2121

2222
### Create a new C# application
2323

articles/communication-services/quickstarts/includes/manage-teams-identity-python.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ ms.custom: include file
1313
ms.author: gistefan
1414
---
1515

16-
## Setting Up prerequisites
16+
## Set up prerequisites
1717

1818
- [Python](https://www.python.org/downloads/) 2.7 or 3.6+.
1919

20-
## Setting Up
20+
## Set up
2121

2222
### Create a new Python application
2323

articles/communication-services/quickstarts/manage-teams-identity.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,10 @@ On the **Branding** pane, you can update your publisher domain for the applicati
7474
- Navigate to your AAD app in the Azure portal and select **API permissions**
7575
- Select **Add Permissions**
7676
- In the **Add Permissions** menu select **Azure Communication Services**
77-
- Select the desired permissions **Voip** and/or **Teams.ManageCalls** and click **Add permissions**
77+
- Select the desired permissions **VoIP** and/or **Teams.ManageCalls** and click **Add permissions**
7878

79-
![Permissions part1.](./media/AadPermissions.png)
79+
:::image type="content" source="image-file-inline.png" alt-text="Image alt text." lightbox="image-file-expanded.png":::
80+
![Permissions part1.](./media/active_directory_permissions.png)
8081

8182
### Step 5: Create or select a Communication Services resource
8283

Binary file not shown.
27.7 KB
Loading

0 commit comments

Comments
 (0)