Skip to content

Commit 4761a87

Browse files
Apply suggestions from code review
Co-authored-by: steve munk <[email protected]>
1 parent bab722f commit 4761a87

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

articles/azure-maps/android-sdk-migration-guide.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ To use the Map Control in a web page, you must have one of the following prerequ
2222

2323
## Create a WebView
2424

25-
If your Android application doesn't already have a WebView, you need to add one. You can do so by adding the WebView element to your layout XML or programmatically in your Java code. Make sure to set up the WebView to occupy the desired area of your layout.
25+
Add a `WebView` if your Android application doesn't have one. Do so by adding the `WebView` element to your layout XML or programmatically in your Java code. Be sure it's configured to occupy the desired area of your layout.
2626

2727
```xml
2828
<?xml version="1.0" encoding="utf-8"?>
@@ -41,7 +41,7 @@ If your Android application doesn't already have a WebView, you need to add one.
4141
</androidx.coordinatorlayout.widget.CoordinatorLayout>
4242
```
4343

44-
Make sure to include the necessary permissions in your AndroidManifest.xml to enable internet access.
44+
Enable internet access by adding permissions in AndroidManifest.xml.
4545

4646
```xml
4747
<uses-permission android:name="android.permission.INTERNET" />
@@ -144,11 +144,11 @@ To enable communication between your Android application and the WebView, you ca
144144

145145
## Clean Up Native Map Implementation
146146

147-
Remove the code related to the native Azure Maps Android SDK from your project. This includes dependencies and initialization code related to `com.azure.android:azure-maps-control`.
147+
Remove code related to the native Azure Maps Android SDK, including dependencies and initialization code related to `com.azure.android:azure-maps-control`.
148148

149149
## Testing
150150

151-
Test your application thoroughly to ensure that the migration has been successful. Check for any issues related to map functionality, user interactions, and performance.
151+
Test your application thoroughly to ensure the migration was successful. Check for issues related to map functionality, user interactions, and performance.
152152

153153
## Next steps
154154

articles/azure-maps/ios-sdk-migration-guide.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ To use the Map Control in a web page, you must have one of the following prerequ
2222

2323
## Create a WebView
2424

25-
If your iOS application doesn't already have a WebView, you need to add one. You can do so by adding a WKWebView to your storyboard or programmatically in your Swift code. Make sure to set up the WKWebView to occupy the desired area of your view.
25+
Add a `WebView` if your iOS application doesn't have one. Do so by adding the `WKWebView` to your storyboard or programmatically in your Swift code. Be sure it's configured to occupy the desired area of your layout.
2626

2727
```swift
2828
import UIKit
@@ -123,15 +123,15 @@ Save and run the app. A map should be shown within a WebView. Add any features o
123123

124124
## Communication between native code and WebView (optional)
125125

126-
To enable communication between your iOS application and the WebView, you can use the `WKScriptMessageHandler` protocol provided by the `WKWebView` class. It allows you to establish a bridge for communication between JavaScript running in the WebView and your Swift code. For more information, see the [iOS webkit documentation].
126+
To enable communication between your iOS application and the WebView, you can use the `WKScriptMessageHandler` protocol provided by the `WKWebView` class. It allows you to establish a bridge for communication between JavaScript running in the WebView and your Swift code. For more information, see [WKScriptMessageHandler] in the iOS webkit documentation.
127127

128128
## Clean Up Native Map Implementation
129129

130-
Remove the code related to the native Azure Maps iOS SDK from your project. This includes dependencies and initialization code related to `azure-maps-ios-sdk-distribution`.
130+
Remove code related to the native Azure Maps iOS SDK from your project, including dependencies and initialization code related to `azure-maps-ios-sdk-distribution`.
131131

132132
## Testing
133133

134-
Test your application thoroughly to ensure that the migration has been successful. Check for any issues related to map functionality, user interactions, and performance.
134+
Test your application thoroughly to ensure that the migration was successful. Check for issues related to map functionality, user interactions, and performance.
135135

136136
## Next steps
137137

@@ -145,7 +145,7 @@ Learn how to add maps to web and mobile applications using the Map Control clien
145145
[authentication options]: /javascript/api/azure-maps-control/atlas.authenticationoptions
146146
[Azure Maps documentation]: how-to-use-map-control.md
147147
[Azure Maps Code Samples website]: https://samples.azuremaps.com/
148-
[iOS webkit documentation]: https://developer.apple.com/documentation/webkit/wkscriptmessagehandler
148+
[WKScriptMessageHandler]: https://developer.apple.com/documentation/webkit/wkscriptmessagehandler
149149
[Use the Azure Maps map control]: how-to-use-map-control.md
150150

151151

articles/azure-maps/web-sdk-migration-guide.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
title: The Azure Maps Web SDK v1 and v2 migration guide
2+
title: The Azure Maps Web SDK migration guide
33
titleSuffix: Microsoft Azure Maps
44
description: Find out how to migrate your Azure Maps Web SDK v1 and v2 applications to the most recent version of the Web SDK.
55
author: sinnypan
@@ -9,7 +9,7 @@ ms.topic: how-to
99
ms.service: azure-maps
1010
---
1111

12-
# The Azure Maps Web SDK v1 and v2 migration guide
12+
# The Azure Maps Web SDK migration guide
1313

1414
Thank you for choosing the Azure Maps Web SDK for your mapping needs. This migration guide helps you transition from v1 and v2 to v3, allowing you to take advantage of the latest features and enhancements.
1515

@@ -21,7 +21,7 @@ Before you start the migration process, it's important to familiarize yourself w
2121

2222
### CDN
2323

24-
If you're using CDN ([content delivery network]), update the references to the [v3](#v3) stylesheet and JavaScript within the `head` element of your HTML files.
24+
If you're using CDN ([content delivery network]), update the references to the [v3](#v3) stylesheet and JavaScript in the `head` element of your HTML files.
2525

2626
#### v1
2727

0 commit comments

Comments
 (0)