Skip to content

Commit 4cca3d5

Browse files
author
Kimmo Forss
committed
PR link fixes
1 parent c90a1af commit 4cca3d5

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

articles/virtual-machines/workloads/sap/automation-configure-devops.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ az ad app update --id $TF_VAR_app_registration_app_id --web-home-page-url https:
431431
---
432432
After updating the reply-urls, run the pipeline.
433433

434-
By default there will be no inbound public internet access to the web app apart from the deployer virtual network. To allow additional access to the web app, navigate to the Azure portal. In the deployer resource group, navigate to the app service resource. Then under settings on the left hand side, click on networking. From here, click Access restriction. Add any allow or deny rules you would like. For more information on configuring access restrictions, see [Set up Azure App Service access restrictions](https://docs.microsoft.com/en-us/azure/app-service/app-service-ip-restrictions).
434+
By default there will be no inbound public internet access to the web app apart from the deployer virtual network. To allow additional access to the web app, navigate to the Azure portal. In the deployer resource group, navigate to the app service resource. Then under settings on the left hand side, click on networking. From here, click Access restriction. Add any allow or deny rules you would like. For more information on configuring access restrictions, see [Set up Azure App Service access restrictions](/azure/app-service/app-service-ip-restrictions).
435435

436436
You will also need to grant reader permissions to the app service system-assigned managed identity. Navgiate to the app service resource. On the left hand side, click "Identity". In the "system assigned" tab, click on "Azure role assignments" > "Add role assignment". Select "subscription" as the scope, and "reader" as the role. Then click save. Without this step, the web app dropdown functionality won't work.
437437

articles/virtual-machines/workloads/sap/automation-configure-webapp.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ rm ./manifest.json
5959

6060
## Deploy via Azure DevOps (pipelines)
6161

62-
For full instructions on setting up the web app using Azure DevOps, see [Use SAP Deployment Automation Framework from Azure DevOps Services](https://review.docs.microsoft.com/en-us/azure/virtual-machines/workloads/sap/automation-configure-devops?branch=main)
62+
For full instructions on setting up the web app using Azure DevOps, see [Use SAP Deployment Automation Framework from Azure DevOps Services](automation-configure-devops.md)
6363

6464
### Summary of steps required to set up the web app before deploying the control plane:
6565
1. Add the web app deployment pipeline (deploy/pipelines/21-deploy-web-app.yaml).
@@ -75,7 +75,7 @@ For full instructions on setting up the web app using Azure DevOps, see [Use SAP
7575

7676
## Deploy via Azure CLI (Cloud Shell)
7777

78-
For full instructions on setting up the web app using the Azure CLI, see [Deploy the control plane](https://review.docs.microsoft.com/en-us/azure/virtual-machines/workloads/sap/automation-deploy-control-plane?branch=main&tabs=linux)
78+
For full instructions on setting up the web app using the Azure CLI, see [Deploy the control plane](automation-deploy-control-plane.md)
7979

8080
### Summary of steps required to set up the web app before deploying the control plane:
8181
1. Export the environment variables TF_VAR_app_registration_app_id, TF_VAR_webapp_client_secret, and TF_VAR_use_webapp="true".

articles/virtual-machines/workloads/sap/automation-deploy-control-plane.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ cd ~/Azure_SAP_Automated_Deployment/WORKSPACES
138138
--spn_secret "${spn_secret}" \
139139
--tenant_id "${tenant_id}" \
140140
--auto-approve
141-
```
141+
```
142142

143143
# [Windows](#tab/windows)
144144

@@ -337,7 +337,7 @@ IS_PIPELINE_DEPLOYMENT=false
337337

338338
## Accessing the web app
339339

340-
By default there will be no inbound public internet access to the web app apart from the deployer virtual network. To allow additional access to the web app, navigate to the Azure portal. In the deployer resource group, find the web app. Then under settings on the left hand side, click on networking. From here, click Access restriction. Add any allow or deny rules you would like. For more information on configuring access restrictions, see [Set up Azure App Service access restrictions](https://docs.microsoft.com/en-us/azure/app-service/app-service-ip-restrictions).
340+
By default there will be no inbound public internet access to the web app apart from the deployer virtual network. To allow additional access to the web app, navigate to the Azure portal. In the deployer resource group, find the web app. Then under settings on the left hand side, click on networking. From here, click Access restriction. Add any allow or deny rules you would like. For more information on configuring access restrictions, see [Set up Azure App Service access restrictions](/azure/app-service/app-service-ip-restrictions).
341341

342342
You will also need to grant reader permissions to the app service system-assigned managed identity. Navgiate to the app service resource. On the left hand side, click "Identity". In the "system assigned" tab, click on "Azure role assignments" > "Add role assignment". Select "subscription" as the scope, and "reader" as the role. Then click save. Without this step, the web app dropdown functionality will not work.
343343

0 commit comments

Comments
 (0)