Skip to content

Commit 4d9ffb3

Browse files
committed
Updates from code review
1 parent d8b7000 commit 4d9ffb3

File tree

8 files changed

+12
-10
lines changed

8 files changed

+12
-10
lines changed

articles/azure-app-configuration/TOC.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@
150150
href: howto-timewindow-filter.md
151151
- name: ASP.NET Core
152152
href: howto-timewindow-filter-aspnet-core.md
153-
- name: JavaScipt
153+
- name: JavaScript
154154
href: howto-timewindow-filter-javascript.md
155155
- name: Roll out features to targeted audience
156156
items:

articles/azure-app-configuration/howto-feature-filters.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ You can create custom feature filters that enable features based on your specifi
3131

3232
## Add a custom feature filter
3333

34-
1. Create a feature flag named *Beta* in the **Feature Manager** menu of your App Configuration store and move to the right end of the feature flag you want to modify, then select the **More actions** ellipsis (**...**) action and **Edit**. For more information about how to add and edit a feature flag, see [Manage feature flags](./manage-feature-flags.md).
34+
1. Create a feature flag named *Beta* in your App Configuration store and edit it. For more information about how to add and edit a feature flag, see [Manage feature flags](./manage-feature-flags.md#edit-feature-flags).
3535

3636
1. In the **Edit feature flag** pane that opens, check the **Enable feature flag** checkbox if it isn't already enabled. Then check the **Use feature filter** checkbox and select **Create**.
3737

articles/azure-app-configuration/howto-targetingfilter.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ In this article, you will learn how to add and configure a targeting filter for
2424

2525
## Add a targeting filter
2626

27-
1. Create a feature flag named *Beta* in the **Feature Manager** menu of your App Configuration store and move to the right end of the feature flag you want to modify, then select the **More actions** ellipsis (**...**) action and **Edit**. For more information about how to add and edit a feature flag, see [Manage feature flags](./manage-feature-flags.md).
27+
1. Create a feature flag named *Beta* in your App Configuration store and edit it. For more information about how to add and edit a feature flag, see [Manage feature flags](./manage-feature-flags.md#edit-feature-flags).
2828

2929
1. In the **Edit feature flag** pane that opens, check the **Enable feature flag** checkbox if it isn't already enabled. Then check the **Use feature filter** checkbox and select **Create**.
3030

articles/azure-app-configuration/howto-timewindow-filter-aspnet-core.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ The example used in this tutorial is based on the ASP.NET Core application intro
1919
## Prerequisites
2020

2121
- Create an [ASP.NET Core application with a feature flag](./quickstart-feature-flag-aspnet-core.md).
22-
- [Add a non-recurring time window filter to the feature flag](./howto-timewindow-filter.md)
22+
- [Add a time window filter to the feature flag](./howto-timewindow-filter.md)
2323
- Update the [`Microsoft.FeatureManagement.AspNetCore`](https://www.nuget.org/packages/Microsoft.FeatureManagement.AspNetCore/) package to version **3.0.0** or later.
2424

2525
## Use the time window filter
@@ -49,6 +49,8 @@ Once the start time has passed, refresh your browser a few times. You'll notice
4949
> [!div class="mx-imgBorder"]
5050
> ![Screenshot of browser with Beta menu.](./media/quickstarts/aspnet-core-feature-flag-local-after.png)
5151
52+
If recurrence is enabled when you set up the time window filter, the **Beta** menu will disappear once your current time passes the end time you set in the time window filter. However, the **Beta** menu will reappear according to your recurrence settings and continue this pattern until the recurrence expiration time, if set.
53+
5254
## Next steps
5355

5456
To learn more about the feature filters, continue to the following tutorials.

articles/azure-app-configuration/howto-timewindow-filter-javascript.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ Beta is enabled: true
6464
Beta is enabled: true
6565
```
6666

67+
If recurrence is enabled when you set up the time window filter, the console outputs will change to `Beta is enabled: false` once your current time passes the end time you set in the time window filter. However, it will change to `Beta is enabled: true` again according to your recurrence settings and continue this pattern until the recurrence expiration time, if set.
68+
6769
## Next steps
6870

6971
To learn more about the feature filters, continue to the following tutorials.

articles/azure-app-configuration/howto-timewindow-filter.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,11 @@ In this article, you learn how to add and configure a time window filter for you
3737

3838
1. A time zone is selected by default, based on your browser's current time zone. Optionally select another time zone.
3939

40-
## Enable recurrence
40+
1. Optionally set a time window recurrence. This option allows you to define a repeating time window, ensuring that the feature flag is automatically activated and deactivated according to your specified schedule, such as during periods of low or high traffic.
4141

42-
Setting a time window recurrence allows you to define a repeating time window, ensuring that the feature flag is automatically activated and deactivated according to your specified schedule, such as during periods of low or high traffic.
42+
A recurring time window filter always has a start time and an end time, defining a base time window that recurs according to the recurrence pattern you specify. Enter a **Start time** and an **End time**, then select the **Enable recurrence** checkbox, and select the recurrence details, including a recurrence pattern and an expiration time.
4343

44-
1. A recurring time window filter always has a start time and an end time, defining a base time window that recurs according to the recurrence pattern you specified. Enter a **Start time** and an **End time**, then select the **Enable recurrence** checkbox, and select the recurrence details, including a frequency and an expiration time.
45-
46-
In this example, we activate the *Beta* feature **Daily** from November 25, every night between 8:00 PM and 6:00 AM. You can alternatively select a weekly frequency and select one or more days of the week for the recurrence. We set an **expiration time** a few weeks later.
44+
In this example, we activate the *Beta* feature between 5:00 PM and 6:00 PM, starting from November 25. You can alternatively select a weekly frequency and select one or more days of the week for the recurrence. We set an **expiration time** a few weeks later.
4745

4846
:::image type="content" source="media/time-window-filters/add-timewindow-filter-recurrence.png" alt-text="Screenshot of the Azure portal showing feature filter recurrence.":::
4947

@@ -60,7 +58,7 @@ Setting a time window recurrence allows you to define a repeating time window, e
6058
1. Continue to the following instructions to use the feature flag with a time window filter in your application for the language or platform you are using.
6159

6260
- [ASP.NET Core](./howto-timewindow-filter-aspnet-core.md)
63-
- [Node.js](./howto-timewindow-filter-javascript.md)
61+
- [JavaScript](./howto-timewindow-filter-javascript.md)
6462

6563
## Next steps
6664

-4.2 KB
Loading
-6.52 KB
Loading

0 commit comments

Comments
 (0)