Skip to content

Commit 52349e2

Browse files
authored
Apply suggestions from code review
1 parent de73596 commit 52349e2

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

articles/virtual-machines/workloads/sap/automation-configure-devops.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ Push the changes back to the repository by selecting the source control icon and
7979

8080
## Set up the web app
8181

82-
The automation framework optionally provisions a web app as a part of the control plane to assist with the deployment of SAP workload zones and systems. If you would like to use the web app, you must first create an app registration for authentication purposes. Open the Azure cloud shell and execute the following commands:
82+
The automation framework optionally provisions a web app as a part of the control plane to assist with the deployment of SAP workload zones and systems. If you would like to use the web app, you must first create an app registration for authentication purposes. Open the Azure Cloud Shell and execute the following commands:
8383

8484
# [Linux](#tab/linux)
8585
Replace MGMT with your environment as necessary.
@@ -108,7 +108,7 @@ az ad app credential reset --id $TF_VAR_app_registration_app_id --append --query
108108
rm ./manifest.json
109109
```
110110
---
111-
Save the app registration id and password values for later.
111+
Save the app registration ID and password values for later.
112112

113113

114114
## Create Azure Pipelines
@@ -280,7 +280,7 @@ Create a new variable group 'SDAF-General' using the Library page in the Pipelin
280280

281281
Save the variables.
282282

283-
Or alternatively you can use the Azure DevOps CLI to setup the groups.
283+
Or alternatively you can use the Azure DevOps CLI to set up the groups.
284284

285285
```bash
286286
s-user="<SAP Support user account name>"
@@ -433,7 +433,7 @@ After updating the reply-urls, run the pipeline.
433433

434434
By default there will be no inbound public internet access to the web app apart from the deployer virtual network. To allow additional access to the web app, navigate to the Azure portal. In the deployer resource group, navigate to the app service resource. Then under settings on the left hand side, click on networking. From here, click Access restriction. Add any allow or deny rules you would like. For more information on configuring access restrictions, see [Set up Azure App Service access restrictions](/azure/app-service/app-service-ip-restrictions).
435435

436-
You will also need to grant reader permissions to the app service system-assigned managed identity. Navgiate to the app service resource. On the left hand side, click "Identity". In the "system assigned" tab, click on "Azure role assignments" > "Add role assignment". Select "subscription" as the scope, and "reader" as the role. Then click save. Without this step, the web app dropdown functionality won't work.
436+
You will also need to grant reader permissions to the app service system-assigned managed identity. Navigate to the app service resource. On the left hand side, click "Identity". In the "system assigned" tab, click on "Azure role assignments" > "Add role assignment". Select "subscription" as the scope, and "reader" as the role. Then click save. Without this step, the web app dropdown functionality won't work.
437437

438438
You should now be able to visit the web app, and use it to deploy SAP workload zones and SAP system infrastructure.
439439

articles/virtual-machines/workloads/sap/automation-deploy-control-plane.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -345,9 +345,9 @@ IS_PIPELINE_DEPLOYMENT=false
345345

346346
By default there will be no inbound public internet access to the web app apart from the deployer virtual network. To allow additional access to the web app, navigate to the Azure portal. In the deployer resource group, find the web app. Then under settings on the left hand side, click on networking. From here, click Access restriction. Add any allow or deny rules you would like. For more information on configuring access restrictions, see [Set up Azure App Service access restrictions](/azure/app-service/app-service-ip-restrictions).
347347

348-
You will also need to grant reader permissions to the app service system-assigned managed identity. Navgiate to the app service resource. On the left hand side, click "Identity". In the "system assigned" tab, click on "Azure role assignments" > "Add role assignment". Select "subscription" as the scope, and "reader" as the role. Then click save. Without this step, the web app dropdown functionality will not work.
348+
You will also need to grant reader permissions to the app service system-assigned managed identity. Navigate to the app service resource. On the left hand side, click "Identity". In the "system assigned" tab, click on "Azure role assignments" > "Add role assignment". Select "subscription" as the scope, and "reader" as the role. Then click save. Without this step, the web app dropdown functionality will not work.
349349

350-
You can login and visit the web app by following the URL from earlier or clicking browse inside the app service resource. With the web app, you are able to configure SAP workload zones and system infrastructure. Click download to obtain a parameter file of the workload zone or system you specified, for use in the later deployment steps.
350+
You can log in and visit the web app by following the URL from earlier or clicking browse inside the app service resource. With the web app, you are able to configure SAP workload zones and system infrastructure. Click download to obtain a parameter file of the workload zone or system you specified, for use in the later deployment steps.
351351

352352

353353
## Next step

0 commit comments

Comments
 (0)