Skip to content

Commit 5d4272c

Browse files
committed
Add reviewer feedback
1 parent 1437b46 commit 5d4272c

File tree

5 files changed

+12
-13
lines changed

5 files changed

+12
-13
lines changed

articles/iot-edge/debug-module-vs-code.md

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,6 @@ On your development machine, you can start an IoT Edge simulator instead of inst
180180
---
181181

182182
::: zone-end
183-
<!--vscode end-->
184183

185184
## Debug a module with the IoT Edge runtime
186185

@@ -213,7 +212,7 @@ In Visual Studio Code, open the *deployment.debug.template.json* deployment mani
213212
"registryCredentials": {
214213
"myacr": {
215214
"username": "myacr",
216-
"password": "<your_acr_password>",
215+
"password": "<your_azure_container_registry_password>",
217216
"address": "myacr.azurecr.io"
218217
}
219218
}
@@ -222,7 +221,7 @@ In Visual Studio Code, open the *deployment.debug.template.json* deployment mani
222221
...
223222
```
224223

225-
1. Add or replace the following stringified content to the *createOptions* value for each system (edgeHub and edgeAgent) and custom module (for example, filtermodeule) listed. Change the values if necessary.
224+
1. Add or replace the following stringified content to the *createOptions* value for each system (edgeHub and edgeAgent) and custom module (for example, filtermodule) listed. Change the values if necessary.
226225

227226
```json
228227
"createOptions": "{\"HostConfig\":{\"PortBindings\":{\"5671/tcp\":[{\"HostPort\":\"5671\"}],\"8883/tcp\":[{\"HostPort\":\"8883\"}],\"443/tcp\":[{\"HostPort\":\"443\"}]}}}"
@@ -256,7 +255,7 @@ In Visual Studio Code, open the *deployment.debug.template.json* deployment mani
256255
You can check your container status from your device or virtual machine by running the `docker ps` command in a terminal. You should see your container listed after running the command. If your Visual Studio Code and IoT Edge runtime are running on the same machine, you can also check the status in the Visual Studio Code Docker view.
257256

258257
> [!IMPORTANT]
259-
> If you're using a private registry like Azure Container Registry (ACR) for your images, you may need to authenticate to push images. Use `docker login <ACR login server>` or `az acr login --name <ACR name>` to authenticate.
258+
> If you're using a private registry like Azure Container Registry for your images, you may need to authenticate to push images. Use `docker login <Azure Container Registry login server>` or `az acr login --name <Azure Container Registry name>` to authenticate.
260259

261260
::: zone-end
262261
<!--vscode end-->
@@ -267,18 +266,18 @@ You can check your container status from your device or virtual machine by runni
267266

268267
Provide your container registry credentials to Docker so that it can push your container image to storage in the registry.
269268

270-
1. Sign in to Docker with the Azure Container Registry (ACR) credentials that you saved after creating the registry.
269+
1. Sign in to Docker with the Azure Container Registry credentials that you saved after creating the registry.
271270

272271
```bash
273-
docker login -u <ACR username> -p <ACR password> <ACR login server>
272+
docker login -u <Azure Container Registry username> -p <Azure Container Registry password> <Azure Container Registry login server>
274273
```
275274

276275
You may receive a security warning recommending the use of `--password-stdin`. While that's a recommended best practice for production scenarios, it's outside the scope of this tutorial. For more information, see the [docker login](https://docs.docker.com/engine/reference/commandline/login/#provide-a-password-using-stdin) reference.
277276

278277
1. Sign in to the Azure Container Registry. You may need to [Install Azure CLI](/cli/azure/install-azure-cli) to use the `az` command. This command asks for your user name and password found in your container registry in **Settings** > **Access keys**.
279278

280279
```azurecli
281-
az acr login -n <ACR registry name>
280+
az acr login -n <Azure Container Registry name>
282281
```
283282
>[!TIP]
284283
>If you get logged out at any point in this tutorial, repeat the Docker and Azure Container Registry sign in steps to continue.
@@ -291,7 +290,7 @@ Use the module's Dockerfile to [build](https://docs.docker.com/engine/reference/
291290
docker build --rm -f "<DockerFilePath>" -t <ImageNameAndTag> "<ContextPath>"
292291
```
293292

294-
For example, to build the image for the local registry or an Azure container registry, use the following commands:
293+
For example, to build the image for the local registry or an Azure Container Registry, use the following commands:
295294

296295
```bash
297296
# Build the image for the local registry
@@ -321,7 +320,7 @@ az acr login --name myacr
321320
docker push myacr.azurecr.io/filtermodule:0.0.1-amd64
322321
```
323322

324-
#### Deploy the module to the IoT Edge device.
323+
#### Deploy the module to the IoT Edge device
325324

326325
Use the [IoT Edge Azure CLI set-modules](/cli/azure/iot/edge#az-iot-edge-set-modules) command to deploy the modules to the Azure IoT Hub. For example, to deploy the modules defined in the *deployment.debug.template.json* file to IoT Hub *my-iot-hub* for the IoT Edge device *my-device*, use the following command:
327326

@@ -380,7 +379,7 @@ The Docker and Moby engines support SSH connections to containers allowing you t
380379
edgeAgent
381380
```
382381

383-
1. In the *.Visual Studio Code* directory, add a new configuration to **launch.json** by opening the file in Visual Studio Code. Select **Add configuration** then choose the matching remote attach template for your module. For example, the following configuration is for .NET Core. Change the value for the *-H* parameter in *PipeArgs* to your device DNS name or IP address.
382+
1. In the *.vscode* directory, add a new configuration to **launch.json** by opening the file in Visual Studio Code. Select **Add configuration** then choose the matching remote attach template for your module. For example, the following configuration is for .NET Core. Change the value for the *-H* parameter in *PipeArgs* to your device DNS name or IP address.
384383

385384
```json
386385
"configurations": [
Binary file not shown.
Binary file not shown.

articles/iot-edge/tutorial-deploy-custom-vision.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ Currently, Visual Studio Code can develop modules for Linux AMD64 and Linux ARM3
180180

181181
### Add your image classifier
182182

183-
The Python module template in Visual Studio code contains some sample code that you can run to test IoT Edge. You won't use that code in this scenario. Instead, use the steps in this section to replace the sample code with the image classifier container that you exported previously.
183+
The Python module template in Visual Studio Code contains some sample code that you can run to test IoT Edge. You won't use that code in this scenario. Instead, use the steps in this section to replace the sample code with the image classifier container that you exported previously.
184184

185185
1. In your file explorer, browse to the Custom Vision package that you downloaded and extracted. Copy all the contents from the extracted package. It should be two folders, **app** and **azureml**, and two files, **Dockerfile** and **README**.
186186

articles/iot-edge/tutorial-develop-for-linux-on-windows.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ The second step is to configure the EFLOW virtual machine Docker engine to accep
172172
172.31.24.105
173173
```
174174

175-
1. Using the obtained IP address, connect to the EFLOW VM Docker engine, and run the Hello-World sample container.Replace \<EFLOW-VM-IP\> with the EFLOW VM IP address obtained in the previous step.
175+
1. Using the obtained IP address, connect to the EFLOW VM Docker engine, and run the Hello-World sample container. Replace \<EFLOW-VM-IP\> with the EFLOW VM IP address obtained in the previous step.
176176
```powershell
177177
docker -H tcp://<EFLOW-VM-IP>:2375 run --rm hello-world
178178
```
@@ -252,7 +252,7 @@ The IoT Edge extension defaults to the latest stable version of the IoT Edge run
252252
1. Re-generate your deployment manifest with the new runtime version. Right-click the name of your project and select **Generate deployment for IoT Edge**.
253253
254254
> [!WARNING]
255-
> If you are chaging the IoT Edge runtime version, make sure the _deploymnet templates_ reflect the necessary changes. Currently there's a known issue with Azure IoT Edge Tools, that won't change the _"schemVersion"_ inside the _"properties.desired"_ object of _"$edgeHub"_ module (last section of the json file).
255+
> If you are changing the IoT Edge runtime version, make sure the _deployment templates_ reflect the necessary changes. Currently, there's a known issue with Azure IoT Edge Tools that won't change the _"schemVersion"_ inside the _"properties.desired"_ object of _"$edgeHub"_ module (last section of the json file).
256256
257257
258258
### Set up Visual Studio 2019 remote Docker engine instance

0 commit comments

Comments
 (0)