Skip to content

Commit 60cecad

Browse files
Merge pull request #271609 from tomvcassidy/fixingDockerLogin
docker login update
2 parents 03dfba1 + c90e425 commit 60cecad

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

articles/container-instances/container-instances-github-action.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -249,11 +249,11 @@ jobs:
249249
creds: ${{ secrets.AZURE_CREDENTIALS }}
250250
251251
- name: 'Build and push image'
252-
uses: azure/docker-login@v1
252+
uses: docker/login-action@v3
253253
with:
254-
login-server: ${{ secrets.REGISTRY_LOGIN_SERVER }}
255-
username: ${{ secrets.REGISTRY_USERNAME }}
256-
password: ${{ secrets.REGISTRY_PASSWORD }}
254+
registry: <registry-name>.azurecr.io
255+
username: ${{ secrets.AZURE_CLIENT_ID }}
256+
password: ${{ secrets.AZURE_CLIENT_SECRET }}
257257
- run: |
258258
docker build . -t ${{ secrets.REGISTRY_LOGIN_SERVER }}/sampleapp:${{ github.sha }}
259259
docker push ${{ secrets.REGISTRY_LOGIN_SERVER }}/sampleapp:${{ github.sha }}

0 commit comments

Comments
 (0)