Skip to content

Commit 6239f7e

Browse files
committed
address final PR reviewer feedback
1 parent 0408b49 commit 6239f7e

9 files changed

+34
-51
lines changed

articles/azure-monitor/platform/workbooks-access-control.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ ms.author: mbullwin
1616

1717
Access control in workbooks refers to two things:
1818

19-
1. Access required to read data in a workbook. This access is controlled by standard [Azure roles](https://docs.microsoft.com/azure/role-based-access-control/overview) on the resources used in the workbook. Workbooks do not specify or configure access to those resources. Users would usually get this access to those resources using the [Monitoring Reader](https://docs.microsoft.com/azure/role-based-access-control/built-in-roles#monitoring-reader) role on those resources.
19+
* Access required to read data in a workbook. This access is controlled by standard [Azure roles](https://docs.microsoft.com/azure/role-based-access-control/overview) on the resources used in the workbook. Workbooks do not specify or configure access to those resources. Users would usually get this access to those resources using the [Monitoring Reader](https://docs.microsoft.com/azure/role-based-access-control/built-in-roles#monitoring-reader) role on those resources.
2020

21-
2. Access required to save workbooks
22-
23-
- Saving private `("My")` workbooks requires no additional privileges. All users can save private workbooks, and only they can see those workbooks.
24-
- Saving shared workbooks requires write privileges in a resource group to save the workbook. These privileges are usually specified by the [Monitoring Contributor](https://docs.microsoft.com/azure/role-based-access-control/built-in-roles#monitoring-contributor) role, but can also be set via the *Workbooks Contributor* role.
21+
* Access required to save workbooks
2522

23+
- Saving private `("My")` workbooks requires no additional privileges. All users can save private workbooks, and only they can see those workbooks.
24+
- Saving shared workbooks requires write privileges in a resource group to save the workbook. These privileges are usually specified by the [Monitoring Contributor](https://docs.microsoft.com/azure/role-based-access-control/built-in-roles#monitoring-contributor) role, but can also be set via the *Workbooks Contributor* role.
25+
2626
## Standard roles with workbook-related privileges
2727

2828
[Monitoring Reader](https://docs.microsoft.com/azure/role-based-access-control/built-in-roles#monitoring-reader) includes standard /read privileges that would be used by monitoring tools (including workbooks) to read data from resources.

articles/azure-monitor/platform/workbooks-automate.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ ms.author: mbullwin
1717
Resource owners have the option to create and manage their workbooks programmatically via Resource Manager templates.
1818

1919
This can be useful in scenarios like:
20-
1. Deploying org- or domain-specific analytics reports along with resources deployments. For instance, you may deploy org-specific performance and failure workbooks for your new apps or virtual machines.
21-
2. Deploying standard reports or dashboards using workbooks for existing resources.
20+
* Deploying org- or domain-specific analytics reports along with resources deployments. For instance, you may deploy org-specific performance and failure workbooks for your new apps or virtual machines.
21+
* Deploying standard reports or dashboards using workbooks for existing resources.
2222

2323
The workbook will be created in the desired sub/resource-group and with the content specified in the Resource Manager templates.
2424

@@ -29,7 +29,7 @@ The workbook will be created in the desired sub/resource-group and with the cont
2929
4. In the editor, switch _Template Type_ to _Resource Manager template_.
3030
5. The Resource Manager template for creating shows up in the editor. Copy the content and use as-is or merge it with a larger template that also deploys the target resource.
3131

32-
![Image showing how to get the Resource Manager template from within the workbook UI](./media/workbooks-automate/programmatic-template.png)
32+
![Image showing how to get the Resource Manager template from within the workbook UI](./media/workbooks-automate/programmatic-template.png)
3333

3434
## Sample Azure Resource Manager template
3535
This template shows how to deploy a simple workbook that displays a 'Hello World!'

articles/azure-monitor/platform/workbooks-data-sources.md

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,7 @@ ms.author: mbullwin
1515

1616
# Azure Monitor workbooks data sources
1717

18-
Workbooks are compatible with the following data sources:
19-
20-
* [Logs](#logs)
21-
* [Metrics](#metrics)
22-
* [Azure Resource Graph](#azure-resource-graph)
23-
* [Alerts (Preview)](#alerts-preview)
24-
* [Workload Health (Preview)](#workload-health-preview)
25-
* [Azure Resource Health (Preview)](#azure-resource-health)
26-
* [Azure Data Explorer (Preview)](#azure-data-explorer-preview)
18+
Workbooks are compatible with a large number of data sources. This article will walk you through data sources which are currently available for Azure Monitor workbooks.
2719

2820
## Logs
2921

articles/azure-monitor/platform/workbooks-dropdowns.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ The easiest way to specify a drop-down is by providing a static list in the para
4141
7. Choose 'Save' from the toolbar to create the parameter.
4242
8. The Environment parameter will be a drop-down with the three values.
4343

44-
![Image showing the creation of a static drown down](./media/workbook-dropdowns/dropdown-create.png)
44+
![Image showing the creation of a static drown down](./media/workbook-dropdowns/dropdown-create.png)
4545

4646
## Creating a static dropdown with groups of items
4747
If your query result/json contains a "group" field, the dropdown will display groups of values. Follow the above sample, but use the following json instead:
@@ -55,7 +55,7 @@ If your query result/json contains a "group" field, the dropdown will display gr
5555
{ "value":"prod2", "label":"Prod 2", "group":"Production" }
5656
]
5757
```
58-
![Image showing an example of a grouped dropdown](./media/workbook-dropdowns/grouped-dropDown.png)
58+
![Image showing an example of a grouped dropdown](./media/workbook-dropdowns/grouped-dropDown.png)
5959

6060

6161
## Creating a dynamic drop-down parameter
@@ -79,7 +79,7 @@ If your query result/json contains a "group" field, the dropdown will display gr
7979
2. Choose 'Save' from the toolbar to create the parameter.
8080
3. The RequestName parameter will be a drop-down the names of all requests in the app.
8181
82-
![Image showing the creation of a dynamic drop-down](./media/workbook-dropdowns/dropdown-dynamic.png)
82+
![Image showing the creation of a dynamic drop-down](./media/workbook-dropdowns/dropdown-dynamic.png)
8383
8484
## Referencing drop down parameter
8585
### In KQL
@@ -102,7 +102,7 @@ If your query result/json contains a "group" field, the dropdown will display gr
102102
103103
4. Run query to see the results. Optionally, render it as a chart.
104104
105-
![Image showing a drop-down referenced in KQL](./media/workbook-dropdowns/dropdown-reference.png)
105+
![Image showing a drop-down referenced in KQL](./media/workbook-dropdowns/dropdown-reference.png)
106106
107107
108108
## Parameter Value, Label, Selection and Group
@@ -118,7 +118,7 @@ dependencies
118118
| serialize Rank = row_number()
119119
| project value = name, label = strcat('🌐 ', name), selected = iff(Rank == 1, true, false), group = operation_Name
120120
```
121-
![Image showing a drop-down parameter using value, label, selection and group options](./media/workbook-dropdowns/dropdown-more-options.png)
121+
![Image showing a drop-down parameter using value, label, selection and group options](./media/workbook-dropdowns/dropdown-more-options.png)
122122

123123

124124
## Drop down parameter options

articles/azure-monitor/platform/workbooks-interactive.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ Workbooks allow authors to add interactivity via a special type of grid column r
9292
4. Click _Save and Close_ to apply changes
9393
8. Click on one of the `Sample` links in the grid. This opens up a property pane with the details of a sampled request.
9494
95-
![Image showing the creation an interactive experience using grid cell clicks](./media/workbooks-interactive/grid-cell-click-create.png)
95+
![Image showing the creation an interactive experience using grid cell clicks](./media/workbooks-interactive/grid-cell-click-create.png)
9696
9797
### Link Renderer Actions
9898
| Link action | Action on click |

articles/azure-monitor/platform/workbooks-parameters.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ These parameter values can be referenced in other parts of workbooks either via
4141
4. Available time ranges: Last hour, Last 12 hours, Last 24 hours, Last 48 hours, Last 3 days, Last 7 days and Allow custom time range selection
4242
5. Choose 'Save' from the toolbar to create the parameter.
4343

44-
![Image showing the creation of a time range parameter](./media/workbooks-parameters/time-settings.png)
44+
![Image showing the creation of a time range parameter](./media/workbooks-parameters/time-settings.png)
4545

4646
This is how the workbook will look like in read-mode, in the "Pills" style.
4747

48-
![Image showing a time range parameter in read mode](./media/workbooks-parameters/parameters-time.png)
48+
![Image showing a time range parameter in read mode](./media/workbooks-parameters/parameters-time.png)
4949

5050
## Referencing a parameter
5151
### Via Bindings
@@ -54,15 +54,15 @@ This is how the workbook will look like in read-mode, in the "Pills" style.
5454
3. This binds the time range parameter to the time range of the chart. The time scope of the sample query is now Last 24 hours.
5555
4. Run query to see the results
5656

57-
![Image showing a time range parameter referenced via bindings](./media/workbooks-parameters/time-binding.png)
57+
![Image showing a time range parameter referenced via bindings](./media/workbooks-parameters/time-binding.png)
5858

5959
### In KQL
6060
1. Add a query control to the workbook and select an Application Insights resource.
6161
2. In the KQL, enter a time scope filter using the parameter: `| where timestamp {TimeRange}`
6262
3. This expands on query evaluation time to `| where timestamp > ago(1d)`, which is the time range value of the parameter.
6363
4. Run query to see the results
6464

65-
![Image showing a time range referenced in KQL](./media/workbooks-parameters/time-in-code.png)
65+
![Image showing a time range referenced in KQL](./media/workbooks-parameters/time-in-code.png)
6666

6767
### In Text
6868
1. Add a text control to the workbook.

articles/azure-monitor/platform/workbooks-text.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ A common use of textboxes is as internal variables used by other workbook contro
2929
4. Get default value from query: `unchecked`
3030
5. Choose 'Save' from the toolbar to create the parameter.
3131

32-
![Image showing the creation of a text parameter](./media/workbooks-text/text-create.png)
32+
![Image showing the creation of a text parameter](./media/workbooks-text/text-create.png)
3333

3434
This is how the workbook will look like in read-mode.
3535

@@ -53,7 +53,7 @@ This is how the workbook will look like in read-mode.
5353
```
5454
4. Run query to see the results
5555
56-
![Image showing a text parameter referenced in KQL](./media/workbooks-text/text-reference.png)
56+
![Image showing a text parameter referenced in KQL](./media/workbooks-text/text-reference.png)
5757
5858
5959
## Setting default values
@@ -74,7 +74,7 @@ This is how the workbook will look like in read-mode.
7474
6. Run query to see the result
7575
7. Choose 'Save' from the toolbar to create the parameter.
7676
77-
![Image showing a text parameter with default value from KQL](./media/workbooks-text/text-default-value.png)
77+
![Image showing a text parameter with default value from KQL](./media/workbooks-text/text-default-value.png)
7878
7979
> [!NOTE]
8080
> While this example queries Application Insights data, the approach can be used for any log based data source - Log Analytics, Azure Resource Graph, etc.

articles/azure-monitor/platform/workbooks-time.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Time parameters allow users to set the time context of analysis and is used by a
2727
4. Available time ranges: Last hour, Last 12 hours, Last 24 hours, Last 48 hours, Last 3 days, Last 7 days and Allow custom time range selection
2828
5. Choose 'Save' from the toolbar to create the parameter.
2929

30-
![Image showing the creation of a time range parameter](./media/workbooks-time/time-settings.png)
30+
![Image showing the creation of a time range parameter](./media/workbooks-time/time-settings.png)
3131

3232
This is how the workbook will look like in read-mode.
3333

@@ -40,15 +40,15 @@ This is how the workbook will look like in read-mode.
4040
3. This binds the time range parameter to the time range of the chart. The time scope of the sample query is now Last 24 hours.
4141
4. Run query to see the results
4242

43-
![Image showing a time range parameter referenced via bindings](./media/workbooks-time/time-binding.png)
43+
![Image showing a time range parameter referenced via bindings](./media/workbooks-time/time-binding.png)
4444

4545
### In KQL
4646
1. Add a query control to the workbook and select an Application Insights resource.
4747
2. In the KQL, enter a time scope filter using the parameter: `| where timestamp {TimeRange}`
4848
3. This expands on query evaluation time to `| where timestamp > ago(1d)`, which is the time range value of the parameter.
4949
4. Run query to see the results
5050

51-
![Image showing a time range referenced in KQL](./media/workbooks-time/time-in-code.png)
51+
![Image showing a time range referenced in KQL](./media/workbooks-time/time-in-code.png)
5252

5353
### In Text
5454
1. Add a text control to the workbook.

articles/azure-monitor/platform/workbooks-visualizations.md

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,6 @@ ms.author: mbullwin
1616

1717
Azure Monitor workbooks support a number of different styles of visualizations to accommodate your reporting needs. This article provides examples of each type of visualization.
1818

19-
## Visualization components
20-
21-
* [Text](#text)
22-
* [Charts](#charts)
23-
* [Grids](#grids)
24-
* [Tiles](#tiles)
25-
* [Trees](#trees)
26-
* [Graphs](#graphs)
27-
2819
## Text
2920

3021
Workbooks allow authors to include text blocks in their workbooks. The text can be human analysis of telemetry, information to help users interpret your data, section headings, etc.
@@ -238,15 +229,15 @@ The graph below show data flowing in/out of a computer via various port to/from
238229
7. Set the visualization to **Graph**
239230
8. Click the **Graph Settings** button to open the settings pane
240231
9. In _Layout Fields_ at the bottom, set:
241-
* Node Id: `Id`
242-
* Source Id: `SourceId`
243-
* Target Id: `TargetId`
244-
* Edge Label: `None`
245-
* Edge Size: `Calls`
246-
* Node Size: `None`
247-
* Coloring Type: `Categorical`
248-
* Node Color Field: `Kind`
249-
* Color palette: `Pastel`
232+
* `Node Id`: `Id`
233+
* `Source Id`: `SourceId`
234+
* `Target Id`: `TargetId`
235+
* `Edge Label`: `None`
236+
* `Edge Size`: `Calls`
237+
* `Node Size`: `None`
238+
* `Coloring Type`: `Categorical`
239+
* `Node Color Field`: `Kind`
240+
* `Color palette`: `Pastel`
250241
10. In _Node Format Settings_ at the top, set:
251242
* _Top Content_- Use Column: `Name`, Column Renderer: `Text`
252243
* _Center Content_- Use Column: `Calls`, Column Renderer: `Big Number`, Color Palette: `None`

0 commit comments

Comments
 (0)