Merge pull request #273853 from rahulva-msft/rahulva/ga3

GA3 BYOS updates.

Author: American-Dipper

articles/communication-services/concepts/call-automation/call-recording/bring-your-own-storage.md

@@ -13,9 +13,6 @@ ms.service: azure-communication-services
 
 # Bring your own Azure storage overview
 
-[!INCLUDE [Private Preview Disclaimer](../../../../communication-services/includes/private-preview-include-section.md)]
-
-
 Bring Your Own Azure Storage for Call Recording allows you to specify an Azure blob storage account for storing call recording files. Bring your own Azure storage enables businesses to store their data in a way that meets their compliance requirements and business needs. For example, end-users could customize their own rules and access to the data, enabling them to store or delete content whenever they need it. Bring your own Azure Storage provides a simple and straightforward solution that eliminates the need for developers to invest time and resources in downloading and exporting files.
 
 The same Azure Communication Services Call Recording APIs are used to export recordings to your Azure Blob Storage Container. While starting recording for a call, specify the container path where the recording needs to be exported. Upon recording completion, Azure Communication Services automatically fetches and uploads your recording to your storage.
@@ -29,8 +26,8 @@ Bring your own Azure storage uses [Azure Managed Identities](/entra/identity/man
 
 ## Known issues
 
-- Azure Communication Services will also store your files in a built-in storage for 48 hours even if the exporting is successful.
-- Randomly, recording files are duplicated during the exporting process. Make sure you delete the duplicated file to avoid extra storage costs in your storage account.
+- Azure Communication Services will also store your files in a built-in storage for 24 hours even if the exporting is successful.
+- For Pause on Start Recording the meta data file would have an incorrect pause duration in relation to the recording file.
 
 
 ## Next steps

articles/communication-services/concepts/voice-video-calling/call-recording.md

@@ -25,7 +25,7 @@ For example, you can record 1:1 or 1:N audio and video calls:
 ![Diagram showing a call that it's being recorded.](../media/call-recording-client.png)
 
 But also, you can use Call Recording to record complex PSTN or VoIP inbound and outbound calling workflows managed by [Call Automation](../call-automation/call-automation.md).
-Regardless of how you established the call, Call Recording allows you to produce mixed or unmixed media files that are stored for 48 hours on a built-in temporary storage. You can retrieve the files and take them to the long-term storage solution of your choice. Call Recording supports all Azure Communication Services data regions.
+Regardless of how you established the call, Call Recording allows you to produce mixed or unmixed media files that are stored for 24 hours on a built-in temporary storage. You can retrieve the files , move it your own Azure Blob Store [Bring Your Own Storage](../../quickstarts\call-automation\call-recording\bring-your-own-storage.md) or a storage solution of your choice. Call Recording supports all Azure Communication Services data regions.
 
 
 ![Diagram showing call recording architecture.](../media/call-recording-with-call-automation.png)
@@ -70,7 +70,7 @@ A `recordingId` is returned when recording is started, which is then used for fo
 Call Recording use [Azure Event Grid](../../../event-grid/event-schema-communication-services.md) to provide you with notifications related to media and metadata.
 
 > [!NOTE]
-> Azure Communication Services provides short term media storage for recordings. **Recordings will be available to download for 48 hours.** After 48 hours, recordings will no longer be available.
+> Azure Communication Services provides short term media storage for recordings. **Recordings will be available to download for 24 hours.** After 24 hours, recordings will no longer be available.
 
 
 An Event Grid notification `Microsoft.Communication.RecordingFileStatusUpdated` is published when a recording is ready for retrieval, typically a few minutes after the recording process has completed (for example, meeting ended, recording stopped). Recording event notifications include `contentLocation` and `metadataLocation`, which are used to retrieve both recorded media and a recording metadata file. 

articles/communication-services/quickstarts/call-automation/call-recording/bring-your-own-storage.md

@@ -2,7 +2,7 @@
 ms.author: dbasantes
 title: Azure Communication Services Call Recording Bring Your Own Storage
 titleSuffix: An Azure Communication Services document
-description: Private Preview quickstart for Bring your own storage
+description: Quickstart for Bring your own storage
 author: dbasantes
 services: azure-communication-services
 ms.date: 03/17/2023
@@ -14,25 +14,21 @@ ms.custom: mode-api, devx-track-extended-java
 ---
 # Call recording: Bring your own Azure storage quickstart
 
-[!INCLUDE [Private Preview](../../../includes/private-preview-include-section.md)]
-
 This quickstart gets you started with Bring your own Azure storage for Call Recording. To start using Bring your own Azure Storage functionality, make sure you're familiar with the [Call Recording APIs](../../voice-video-calling/get-started-call-recording.md).
 
-You need to be part of the Azure Communication Services TAP program. It's likely that you’re already part of this program, and if you aren't, sign-up using https://aka.ms/acs-tap-invite. Bring your own Azure Storage uses Managed Identities, to access to this functionality for Call Recording, submit your Azure Communication Services Resource IDs by filling this - [Registration form](https://forms.office.com/r/njact5SiVJ). You need to fill the form every time you need a new resource ID allow-listed.
-
-## Pre-requisite: Setting up Managed Identity and RBAC role assignments
+## Pre-requisite: Setting up Managed Identity and Role Based Access Controls(RBAC) role assignments
 
 ### 1. Enable system assigned managed identity for Azure Communication Services
 
 ![Diagram showing a communication service resource with managed identity disabled](../media/byos-managed-identity-1.png)
 
 1. Open your Azure Communication Services resource. Navigate to *Identity* on the left.
-2. System Assigned Managed Identity is disabled by default. Enable it and click on *Save*
+2. Enabled System Assigned Managed Identity and click on *Save*.
 3. Once completed, you're able to see the Object principal ID of the newly created identity.
 
 ![Diagram showing a communication service resource with managed identity enabled](../media/byos-managed-identity-2.png)
 
-4. Now that identity has been successfully created, click on *Azure role assignments* to start adding role assignments.
+4. Once the identity has been successfully created, click on *Azure role assignments* to start adding role assignments.
 
 ### 2. Add role assignment
 
@@ -67,7 +63,7 @@ Use the server call ID received during initiation of the call.
 
 ### Notification on successful export
 
-Use an [Azure Event Grid](../../../../event-grid/overview.md) web hook, or other triggered action, to notify your services when the recorded media is ready and have been exported to the external storage location.
+Use an [Azure Event Grid](../../../../event-grid/overview.md) web hook, or other triggered action, to notify your services when the recorded media is ready and exported to the external storage location.
 
 Refer to this example of the event schema.
 
@@ -77,7 +73,7 @@ Refer to this example of the event schema.
     "topic": "string", // /subscriptions/{subscription-id}/resourceGroups/{group-name}/providers/Microsoft.Communication/communicationServices/{communication-services-resource-name}
     "subject": "string", // /recording/call/{call-id}/serverCallId/{serverCallId}
     "data": {
-        "storageType": "string", // acsstorage, blobstorage etc.
+        "storageType": "string", // AzureBlob etc.
         "recordingId": "string", // unique id for recording
         "recordingStorageInfo": {
             "recordingChunks": [
@@ -101,6 +97,13 @@ Refer to this example of the event schema.
     "eventTime": "string" // ISO 8601 date time for when the event was created
 }
 ```
+### Folder Structure for Call Recording
+
+Recordings are stored in the following format as shown in the diagram.
+-   /YYYYMMDD/callId/first_8_of_recordingId + '-' + unique guid/[chunk-id]-acsmetadata.documentId.json
+-   /YYYYMMDD/callId/first_8_of_recordingId + '-' + unique guid/[chunk-id]-audiomp3.documentId.mp3
+
+![Diagram showing a Call Recording Folder structure](../media/call-recording-folder.png)
 
 ## Next steps
 

articles/communication-services/quickstarts/call-automation/media/call-recording-folder.png

@@ -1,8 +1,8 @@
 ---
-ms.author: dbasantes
-title: Azure Communication Services Call Recording refreshed API quickstart
+ms.author: rahulva
+title: Azure Communication Services Call Recording API quickstart
 titleSuffix: An Azure Communication Services document
-description: Public Preview quickstart for Call Recording APIs
+description: Quickstart for Call Recording APIs
 author: dbasantes
 services: azure-communication-services
 ms.date: 06/12/2023

articles/communication-services/quickstarts/voice-video-calling/get-started-call-recording.md

@@ -62,8 +62,38 @@ StartRecordingOptions recordingOptions = new StartRecordingOptions(new ServerCal
 Response<RecordingStateResult> response = await callAutomationClient.GetCallRecording()
 .StartAsync(recordingOptions);
 ```
+### 2.1. Start Recording  - Bring Your Own Azure Blob Store
+Start Recording with your own Azure Blob Storage defined to store the recording file once recording is complete.
 
-### 2.1. Only for Unmixed - Specify a user on channel 0
+```csharp
+StartRecordingOptions recordingOptions = new StartRecordingOptions(new ServerCallLocator("<ServerCallId>"))
+{
+   RecordingContent = RecordingContent.Audio,
+   RecordingChannel = RecordingChannel.Unmixed,
+   RecordingFormat = RecordingFormat.Wav,
+   RecordingStateCallbackUri = new Uri("<CallbackUri>"),
+   RecordingStorage = RecordingStorage.CreateAzureBlobContainerRecordingStorage(new Uri("<YOUR_STORAGE_CONTAINER_URL>"))
+};
+Response<RecordingStateResult> response = await callAutomationClient.GetCallRecording()
+.StartAsync(recordingOptions);
+```
+## 2.2. Start recording session with Pause mode enabled using 'StartAsync' API
+> [!NOTE]
+> **Recordings will need to be resumed for recording file to be generated.**
+```csharp
+StartRecordingOptions recordingOptions = new StartRecordingOptions(new ServerCallLocator("<ServerCallId>")) 
+{
+    RecordingContent = RecordingContent.Audio,
+    RecordingChannel = RecordingChannel.Unmixed,
+    RecordingFormat = RecordingFormat.Wav,
+    PauseOnStart = true,
+    RecordingStateCallbackUri = new Uri("<CallbackUri>");
+};
+Response<RecordingStateResult> response = await callAutomationClient.GetCallRecording()
+.StartAsync(recordingOptions);
+```
+
+### 2.3. Only for Unmixed - Specify a user on channel 0
 To produce unmixed audio recording files, you can use the `AudioChannelParticipantOrdering` functionality to specify which user you want to record on channel 0. The rest of the participants are assigned to a channel as they speak. If you use `RecordingChannel.Unmixed` but don't use `AudioChannelParticipantOrdering`, Call Recording assigns channel 0 to the first participant speaking. 
 
 ```csharp
@@ -79,7 +109,7 @@ StartRecordingOptions recordingOptions = new StartRecordingOptions(new ServerCal
 Response<RecordingStateResult> response = await callAutomationClient.GetCallRecording().StartAsync(recordingOptions);
 ```
 
-### 2.2. Only for Unmixed - Specify channel affinity
+### 2.4. Only for Unmixed - Specify channel affinity
 
 ```csharp
 var channelAffinity = new ChannelAffinity(new CommunicationUserIdentifier("<ACS_USER_MRI>")) { Channel = 0};

articles/communication-services/quickstarts/voice-video-calling/includes/call-recording-samples/call-recording-csharp.md

@@ -66,7 +66,38 @@ Response<RecordingStateResult> response = callAutomationClient.getCallRecording(
 
 ```
 
-### 2.1. Only for Unmixed - Specify a user on channel 0
+### 2.1. Start Recording  - Bring Your Own Azure Blob Store
+Start Recording session with your own Azure Blob Storage to store the recording file once recording is complete.
+
+```java
+       StartRecordingOptions recordingOptions = new StartRecordingOptions(callLocator)
+       .setRecordingChannel(RecordingChannel.MIXED)
+       .setRecordingContent(RecordingContent.AUDIO_VIDEO)
+       .setRecordingFormat(RecordingFormat.MP4)
+       .setRecordingStorage(new AzureBlobContainerRecordingStorage("<YOUR_STORAGE_CONTAINER_URL>"));
+ 
+       // //start recording
+       RecordingStateResult result = callRecording.start(recordingOptions);
+```
+
+### 2.2. Start recording session with Pause mode enabled using 'StartAsync' API
+> [!NOTE]
+> **Recordings will need to be resumed for recording file to be generated.**
+```java
+StartRecordingOptions recordingOptions = new StartRecordingOptions(new ServerCallLocator("<serverCallId>"))
+                    .setRecordingChannel(RecordingChannel.UNMIXED)
+                    .setRecordingFormat(RecordingFormat.WAV)
+                    .setRecordingContent(RecordingContent.AUDIO)
+                    .setRecordingStateCallbackUrl("<recordingStateCallbackUrl>")
+                    .setPauseOnStart(true)
+                    .setAudioChannelParticipantOrdering(List.of(new CommunicationUserIdentifier("<participantMri>")));
+
+Response<RecordingStateResult> response = callAutomationClient.getCallRecording()
+.startWithResponse(recordingOptions, null);
+
+```
+
+### 2.3. Only for Unmixed - Specify a user on channel 0
 To produce unmixed audio recording files, you can use the `AudioChannelParticipantOrdering` functionality to specify which user you want to record on channel 0. The rest of the participants will be assigned to a channel as they speak. If you use `RecordingChannel.Unmixed` but don't use `AudioChannelParticipantOrdering`, Call Recording will assign channel 0 to the first participant speaking. 
 
 ```java
@@ -82,7 +113,7 @@ Response<RecordingStateResult> response = callAutomationClient.getCallRecording(
 
 ```
 
-### 2.2. Only for Unmixed - Specify channel affinity
+### 2.4. Only for Unmixed - Specify channel affinity
 ```java
 ChannelAffinity channelAffinity = new ChannelAffinity()
 .setParticipant(new PhoneNumberIdentifier("RECORDING_ID"))

articles/communication-services/quickstarts/voice-video-calling/includes/call-recording-samples/call-recording-java.md

@@ -65,7 +65,45 @@ var options: StartRecordingOptions =
 var response = await callAutomationClient.getCallRecording().start(options);
 ```
 
-### 2.1. Only for Unmixed - Specify a user on channel 0
+### 2.1. Start Recording  - Bring Your Own Azure Blob Store
+Start Recording with your own Azure Blob Storage defined to store the recording file once recording is complete.
+
+```javascript
+const recordingStorageKind: RecordingStorageKind = "azureBlobStorage"
+const recordingStorage: RecordingStorage = { 
+       recordingStorageKind: recordingStorageKind, 
+       recordingDestinationContainerUrl: "<YOUR_STORAGE_CONTAINER_URL>"
+   }
+var options: StartRecordingOptions = {
+       callLocator: callLocator,
+       recordingContent: "audio",
+       recordingChannel:"unmixed",
+       recordingFormat: "wav",
+       recordingStateCallbackEndpointUrl: "<CallbackUri>",
+       recordingStorage: recordingStorage
+   };
+var response = await callAutomationClient.getCallRecording().start(options);
+```
+## 2.2. Start recording session with Pause mode enabled using 'StartAsync' API
+> [!NOTE]
+> **Recordings will need to be resumed for recording file to be generated.**
+```javascript
+var locator: CallLocator = { id: "<ServerCallId>", kind: "serverCallLocator" };
+
+var options: StartRecordingOptions =
+{
+  callLocator: locator,
+  recordingContent: "audio",
+  recordingChannel:"unmixed",
+  recordingFormat: "wav",
+  pauseOnStart: true
+  recordingStateCallbackEndpointUrl: "<CallbackUri>",
+  audioChannelParticipantOrdering:[{communicationUserId: "<ACS_USER_MRI>"}]
+};
+var response = await callAutomationClient.getCallRecording().start(options);
+```
+
+### 2.3. Only for Unmixed - Specify a user on channel 0
 To produce unmixed audio recording files, you can use the `AudioChannelParticipantOrdering` functionality to specify which user you want to record on channel 0. The rest of the participants will be assigned to a channel as they speak. If you use `RecordingChannel.Unmixed` but don't use `AudioChannelParticipantOrdering`, Call Recording will assign channel 0 to the first participant speaking.
 
 ```javascript
@@ -83,7 +121,7 @@ var options: StartRecordingOptions =
 var response = await callAutomationClient.getCallRecording().start(options);
 ```
 
-### 2.2. Only for Unmixed - Specify channel affinity
+### 2.4. Only for Unmixed - Specify channel affinity
 
 ```javascript
 var options: StartRecordingOptions =

articles/communication-services/quickstarts/voice-video-calling/includes/call-recording-samples/call-recording-javascript.md

@@ -59,7 +59,31 @@ response = call_automation_client.start_recording(call_locator=ServerCallLocator
             recording_state_callback_url = "<CallbackUri>")
 ```
 
-### 2.1. Only for Unmixed - Specify a user on channel 0
+### 2.1. Start Recording  - Bring Your Own Azure Blob Store
+Start Recording with your own Azure Blob Storage defined to store the recording file once recording is complete.
+
+```python
+response = call_automation_client.start_recording(call_locator=ServerCallLocator(server_call_id),
+                   recording_content_type = RecordingContent.Audio,
+                   recording_channel_type = RecordingChannel.Unmixed,
+                   recording_format_type = RecordingFormat.Wav,
+                   recording_state_callback_url = "<CallbackUri>",
+                   recording_storage = AzureBlobContainerRecordingStorage(container_url="<YOUR_STORAGE_CONTAINER_URL>"))
+```
+## 2.2. Start recording session with Pause mode enabled using 'StartAsync' API
+> [!NOTE]
+> **Recordings will need to be resumed for recording file to be generated.**
+
+```python
+response = call_automation_client.start_recording(call_locator=ServerCallLocator(server_call_id),
+            recording_content_type = RecordingContent.Audio,
+            recording_channel_type = RecordingChannel.Unmixed,
+            recording_format_type = RecordingFormat.Wav,
+            pause_on_start = true,
+            recording_state_callback_url = "<CallbackUri>")
+```
+
+### 2.3. Only for Unmixed - Specify a user on channel 0
 To produce unmixed audio recording files, you can use the `AudioChannelParticipantOrdering` functionality to specify which user you want to record on channel 0. The rest of the participants will be assigned to a channel as they speak. If you use `RecordingChannel.Unmixed` but don't use `AudioChannelParticipantOrdering`, Call Recording will assign channel 0 to the first participant speaking.
 
 ```python
@@ -71,7 +95,7 @@ response =  call_automation_client.start_recording(call_locator=ServerCallLocato
             audio_channel_participant_ordering=[CommunicationUserIdentifier(id="<ACS_USER_MRI>")])
 ```
 
-### 2.2. Only for Unmixed - Specify channel affinity
+### 2.4. Only for Unmixed - Specify channel affinity
 
 ```python
 _channel_affinity = ChannelAffinity(target_participant=CommunicationUserIdentifier("<ACS_USER_MRI>"), channel=0)