Merge pull request #235304 from dramasamy/main

Update the variable names (caps) and remove unused vars

Author: v-dirichards

articles/operator-nexus/template-cloud-native-network-function-deployment.md

@@ -27,42 +27,41 @@ vNET, and finally the AKS-Hybrid cluster that will host the CNF.
 ## Common parameters
 
 ```bash
-export myloc="eastus"
-export myrg="****"
-export MSYS_NO_PATHCONV=1
-export mysub="******"
-export mynfid='******'
-export myplatcustloc='******'
-export myhakscustloc='******'
+export DC_LOCATION="eastus"
+export RESOURCE_GROUP="****"
+export SUBSCRIPTION="******"
+export CUSTOM_LOCATION='******'
+export HAKS_CUSTOM_LOCATION='******'
+export L3_ISD='******'
 ```
 
 ## Initialization
 
-Set `$mysub` as the active subscription for your Operator Nexus instance.
+Set `$SUBSCRIPTION` as the active subscription for your Operator Nexus instance.
 
 ```azurecli
-  az account set --subscription "$mysub"
+  az account set --subscription "$SUBSCRIPTION"
 ```
 
-Get list of `internalnetworks` in the L3 isolation-domain `$myl3isd`
+Get list of `internalnetworks` in the L3 isolation-domain `$L3_ISD`
 
 ```azurecli
-  az nf internalnetwork list --l3domain "$myl3isd" \
-     -g "$myrg" --subscription "$mysub"
+  az nf internalnetwork list --l3domain "$L3_ISD" \
+     -g "$RESOURCE_GROUP" --subscription "$SUBSCRIPTION"
 ```
 
 ## Create Cloud Services Network
 
 ```bash
-export mycsn="******"
+export CLOUD_SERVICES_NETWORK="******"
 ```
 
 ```azurecli
-az networkcloud cloudservicesnetwork create --name "$mycsn" \
---resource-group "$myrg" \
---subscription "$mysub" \
---extended-location name="$myplatcustloc" type="CustomLocation" \
---location "$myloc" \
+az networkcloud cloudservicesnetwork create --name "$CLOUD_SERVICES_NETWORK" \
+--resource-group "$RESOURCE_GROUP" \
+--subscription "$SUBSCRIPTION" \
+--extended-location name="$CUSTOM_LOCATION" type="CustomLocation" \
+--location "$DC_LOCATION" \
 --additional-egress-endpoints '[{
     "category": "azure-resource-management",
     "endpoints": [{
@@ -100,95 +99,94 @@ az networkcloud cloudservicesnetwork create --name "$mycsn" \
 ### Validate Cloud Services Network has been created
 
 ```azurecli
-az networkcloud cloudservicesnetwork show --name "$mycsn" --resource-group "$myrg" --subscription "$mysub" -o table
+az networkcloud cloudservicesnetwork show --name "$CLOUD_SERVICES_NETWORK" --resource-group "$RESOURCE_GROUP" --subscription "$SUBSCRIPTION" -o table
 ```
 
 ## Create Default CNI Network
 
 ```bash
-export myl3n=="******"
-export myalloctype="IPV4"
-export myvlan=****
-export myipv4sub=="******"
-export mymtu="9000"
-export myl3isdarm=="******"
+export DCN_NAME="******"
+export IP_ALLOCATION_TYPE="IPV4"
+export VLAN=****
+export IPV4_SUBNET="******"
+export L3_ISD_ARM="******"
 ```
 
 ```azurecli
-az networkcloud defaultcninetwork create --name "$myl3n" \
-  --resource-group "$myrg" \
-  --subscription "$mysub" \
-  --extended-location name="$myplatcustloc" type="CustomLocation" \
-  --location "$myloc" \
+az networkcloud defaultcninetwork create --name "$DCN_NAME" \
+  --resource-group "$RESOURCE_GROUP" \
+  --subscription "$SUBSCRIPTION" \
+  --extended-location name="$CUSTOM_LOCATION" type="CustomLocation" \
+  --location "$DC_LOCATION" \
   --bgp-peers '[]' \
   --community-advertisements '[{"communities": ["65535:65281", "65535:65282"], "subnetPrefix": "10.244.0.0/16"}]' \
   --service-external-prefixes '["10.101.65.0/24"]' \
   --service-load-balancer-prefixes '["10.101.66.0/24"]' \
-  --ip-allocation-type "$myalloctype" \
-  --ipv4-connected-prefix "$myipv4sub" \
-  --l3-isolation-domain-id "$myl3isdarm" \
-  --vlan $myvlan
+  --ip-allocation-type "$IP_ALLOCATION_TYPE" \
+  --ipv4-connected-prefix "$IPV4_SUBNET" \
+  --l3-isolation-domain-id "$L3_ISD_ARM" \
+  --vlan $VLAN
 ```
 
 ### Validate Default CNI Network has been created
 
 ```azurecli
-az networkcloud defaultcninetwork show --name "$myl3n" \
-   --resource-group "$myrg" --subscription "$mysub" -o table
+az networkcloud defaultcninetwork show --name "$DCN_NAME" \
+   --resource-group "$RESOURCE_GROUP" --subscription "$SUBSCRIPTION" -o table
 ```
 
 ## Set AKS-Hybrid Extended Location
 
 ```bash
-export myhakscustloc=="******"
+export HAKS_CUSTOM_LOCATION="******"
 ```
 
 ## Create AKS-Hybrid Network Cloud Services Network vNET
 
 The AKS-Hybrid (HAKS) Virtual Networks are different from the Azure to on-premises Virtual Networks.
 
 ```bash
-export myhaksvnetname=="******"
-export myncnw=="******"
+export HAKS_VNET_NAME="******"
+export NC_NETWORK="******"
 ```
 
 ```azurecli
 az hybridaks vnet create \
-  --name "$myhaksvnetname" \
-  --resource-group "$myrg" \
-  --subscription "$mysub" \
-  --custom-location "$myhakscustloc" \
-  --aods-vnet-id "$myncnw"
+  --name "$HAKS_VNET_NAME" \
+  --resource-group "$RESOURCE_GROUP" \
+  --subscription "$SUBSCRIPTION" \
+  --custom-location "$HAKS_CUSTOM_LOCATION" \
+  --aods-vnet-id "$NC_NETWORK"
 ```
 
 ## Create AKS-Hybrid Cluster
 
 The AKS-Hybrid (HAKS) cluster will be used to host the CNF.
 
 ```bash
-export myhaksvnet1=="******"
-export myhaksvnet2=="******"
-export myencodedkey=="******"
-export ="******"
-export myclustername=="******"
+export HAKS_VNET_1="******"
+export HAKS_VNET_2="******"
+export ENCODED_KEY="******"
+export AAD_ID="******"
+export HAKS_CLUSTER_NAME="******"
 ```
 
 ```azurecli
 az hybridaks create \
-  --name "$myclustername" \
-  --resource-group "$myrg" \
-  --subscription "$mysub" \
-  --aad-admin-group-object-ids "$AADID" \
-  --custom-location "$myhakscustloc" \
+  --name "$HAKS_CLUSTER_NAME" \
+  --resource-group "$RESOURCE_GROUP" \
+  --subscription "$SUBSCRIPTION" \
+  --aad-admin-group-object-ids "$AAD_ID" \
+  --custom-location "$HAKS_CUSTOM_LOCATION" \
   --location eastus \
   --control-plane-vm-size NC_G4_v1 \
   --node-vm-size NC_H16_v1 \
   --kubernetes-version v1.22.11 \
   --load-balancer-sku stacked-kube-vip \
   --load-balancer-count 0 \
   --load-balancer-vm-size '' \
-  --vnet-ids "$myhaksvnet1","$myhaksvnet2" \
-  --ssh-key-value "$myencodedkey" \
+  --vnet-ids "$HAKS_VNET_1","$HAKS_VNET_2" \
+  --ssh-key-value "$ENCODED_KEY" \
   --control-plane-count 3 \
   --node-count 4
 ```