Skip to content

Commit 6f6771d

Browse files
committed
resolve pr comments
1 parent c47e248 commit 6f6771d

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

articles/azure-arc/kubernetes/tutorial-arc-enabled-open-service-mesh.md

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ OSM runs an Envoy-based control plane on Kubernetes, can be configured with [SMI
3737
- Ensure you have met all the common prerequisites for cluster extensions listed [here](extensions.md#prerequisites).
3838
- Use az k8s-extension CLI version >= v0.4.0
3939

40-
## Basic Installation of OSM on an Azure Arc-enabled Kubernetes Cluster
40+
## Basic Installation of Azure Arc-enabled OSM on an Azure Arc-enabled Kubernetes Cluster
4141

4242
The following steps assume that you already have a cluster with supported a Kubernetes distribution connected to Azure Arc.
4343
Ensure that your KUBECONFIG environment variable points to the kubeconfig of the Arc-enabled Kubernetes cluster.
@@ -89,13 +89,18 @@ You should see output similar to the output shown below. It may take 3-5 minutes
8989
}
9090
```
9191

92-
## Installation with Custom Configurations
93-
The following sections describe further configurations of OSM during installation.
92+
## Custom Installations of Azure Arc-enabled OSM
93+
The following sections describe certain custom installations of Azure Arc-enabled OSM.
9494

9595
### Setting values during OSM installation
9696

97-
To set custom configurations of OSM, applicable values must be passed in during installation.
98-
This requires creating a JSON file containing the required settings and passing them into `k8s-extension create` CLI command.
97+
Setting custom values of OSM requires creating a JSON file containing the required settings and passing them into `k8s-extension create` CLI command.
98+
For example, to change the log level of logs emitted by the OSM controller to `info`, the JSON file would be as follows:
99+
```json
100+
{
101+
"osm.osm.controllerLogLevel": "info"
102+
}
103+
```
99104

100105
Refer to sections below to determine the contents of the JSON file you require.
101106

@@ -115,7 +120,7 @@ create the OSM extension, passing in the settings file using the `--configuratio
115120
1. Copy and save the following contents into a JSON file. If you have already created a configuration settings file, please add the following line to the existing file to preserve your previous changes.
116121
```json
117122
{
118-
"osm.OpenServiceMesh.enablePrivilegedInitContainer": "true"
123+
"osm.osm.enablePrivilegedInitContainer": "true"
119124
}
120125
```
121126

@@ -129,7 +134,7 @@ create the OSM extension, passing in the settings file using the `--configuratio
129134

130135
It may take 3-5 minutes for the actual OSM helm chart to get deployed to the cluster. Until this deployment happens, you will continue to see installState as Pending.
131136

132-
To ensure that the privileged init container setting is not reverted to the default, pass in the "osm.OpenServiceMesh.enablePrivilegedInitContainer" : "true" configuration setting to all subsequent az k8s-extension create commands.
137+
To ensure that the privileged init container setting is not reverted to the default, pass in the "osm.osm.enablePrivilegedInitContainer" : "true" configuration setting to all subsequent az k8s-extension create commands.
133138

134139
### Install OSM with cert-manager for Certificate Management
135140
[cert-manager](https://cert-manager.io/) is a provider that can be used for issuing signed certificates to OSM without
@@ -174,7 +179,7 @@ To set required values for configuring Contour during OSM installation, create t
174179

175180
[Now, install OSM with custom values](#setting-values-during-osm-installation).
176181

177-
### Install Azure Arc-enabled OSM using ARM template
182+
## Install Azure Arc-enabled OSM using ARM template
178183

179184
After connecting your cluster to Azure Arc, create a json file with the following format, making sure to update the \<cluster-name\> and \<osm-arc-version\> values:
180185

@@ -383,7 +388,7 @@ To make changes to the OSM ConfigMap for version v0.8.4, use the following guida
383388
1. Copy and save the changes you wish to make in a JSON file. In this example, we are going to change the permissive_traffic_policy_mode from true to false. Each time you make a change to `osm-config`, you will have to provide the full list of changes (compared to the default `osm-config`) in a JSON file.
384389
```json
385390
{
386-
"osm.OpenServiceMesh.enablePermissiveTrafficPolicy" : "false"
391+
"osm.osm.enablePermissiveTrafficPolicy" : "false"
387392
}
388393
```
389394

@@ -400,7 +405,6 @@ To make changes to the OSM ConfigMap for version v0.8.4, use the following guida
400405

401406
> [!NOTE]
402407
> To ensure that the ConfigMap changes are not reverted to the default, pass in the same configuration settings to all subsequent az k8s-extension create commands.
403-
404408

405409
## Using the Azure Arc-enabled Open Service Mesh
406410

0 commit comments

Comments
 (0)