Skip to content

Commit 7222f78

Browse files
committed
Updated per review comments
1 parent b848c90 commit 7222f78

File tree

1 file changed

+24
-21
lines changed

1 file changed

+24
-21
lines changed

articles/communication-services/quickstarts/rooms/manage-rooms-call.md

Lines changed: 24 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,20 @@ ms.custom: mode-other
1616
# Quickstart: Manage a room call
1717

1818
## Introduction
19-
Once Azure Communication Services (ACS) room call is started, the call can be managed using Calling SDKs or Call Automation SDKs or both. In a room call, the mid-call actions are controlled by either the roles assigned to participants and properties configured in the room. The participant's roles are used to control capabilities permitted per participant while room's properties are applied to a room call as a whole.
19+
During an Azure Communication Services (ACS) room call, you can manage the call using Calling SDKs or Call Automation SDKs or both. In a room call, you can control in-call actions using both the roles assigned to participants and properties configured in the room. The participant's roles control capabilities permitted per participant, while room properties apply to the room call as a whole.
2020

2121
## Calling SDKs
22-
Calling SDK is a client side calling libraries enabling participants in a room call to perform several mid-call operations (e.g. screen share, turn on/off video, mute/unmute, etc. ). Full list of capabilities offered in Calling SDK is listed in the [Calling SDK Overview](../../concepts/voice-video-calling/calling-sdk-features.md#detailed-capabilities)
22+
Calling SDK is a client-side calling library enabling participants in a room call to perform several in-call operations, such as screen share, turn on/off video, mute/unmute, and so on. For the full list of capabilities, see [Calling SDK Overview](../../concepts/voice-video-calling/calling-sdk-features.md#detailed-capabilities).
2323

24-
The capabilities are controlled based on roles assigned participants in the call (e.g. Only presenter can screen share). Please refer to [Rooms concepts](../../concepts/rooms/room-concept#predefined-participant-roles-and-permissions) for participant roles and permissions.
24+
You control the capabilities based on roles assigned to participants in the call. For example, only the presenter can screen share. For participant roles and permissions, see [Rooms concepts](../../concepts/rooms/room-concept.md#predefined-participant-roles-and-permissions).
2525

2626
## Call Automation SDKs
27-
Call Automation SDK is a sever side libraries enabling administrator to manage an ongoing room call in a central and controlled environment. Unlike Calling SDK, Call Automation SDK operations are roles agnostic. Therefore, a call administrator may perform several mid-call operations on behalf of the room call participants.
27+
Call Automation SDK is a server-side library enabling administrators to manage an ongoing room call in a central and controlled environment. Unlike Calling SDK, Call Automation SDK operations are roles agnostic. Therefore, a call administrator can perform several in-call operations on behalf of the room call participants.
2828

29-
The following lists common mid-call actions available in a room call.
29+
The following lists describe common in-call actions available in a room call.
3030

3131
### Connect to a room call
32-
Call Automation must connect to an existing room call prior to performing any mid-call operations. CallConnected or ConnectFailed events are notified using callback mechanism to indicate a connect operation is successful or failed respectively.
32+
Call Automation must connect to an existing room call before performing any in-call operations. The `CallConnected` or `ConnectFailed` events are raised using callback mechanisms to indicate if a connect operation was successful or failed respectively.
3333

3434
### [csharp](#tab/csharp)
3535

@@ -64,24 +64,27 @@ call_connection_properties = client.connect_call(call_locator=room_call_locator,
6464
```
6565
-----
6666

67-
Once successfully connected to a room call, a CallConnect event is notified via Callback URI. The ```callConnectionId``` is available such that it can be used to retrieve a call connection on the room call as needed. ```callConnectionId``` will be used in the following sample code snippets.
67+
Once successfully connected to a room call, a `CallConnect` event is notified via Callback URI. You can use `callConnectionId` to retrieve a call connection on the room call as needed. The following sample code snippets use the `callConnectionId` to demonstrate this function.
6868

6969

7070
### Add PSTN Participant
71-
Call Automation can dial out to a PSTN number and add the participant into a room call. A room, however, must be set up to enable PSTN dial-out option (EnabledPSTNDialout is set to true) and Azure Communication Services (ACS) resource must have a valid phone number. Please refer to [Rooms quickstart](get-started-rooms?tabs=windows&pivots=platform-azcli#enable-pstn-dial-out-capability-for-a-room) for detail.
71+
Using Call Automation you can dial out to a PSTN number and add the participant into a room call. You must, however, set up a room to enable PSTN dial-out option (`EnabledPSTNDialout` set to `true`) and the Azure Communication Services resource must have a valid phone number provisioned.
72+
73+
For more information, see [Rooms quickstart](../../quickstarts//rooms/get-started-rooms.md?tabs=windows&pivots=platform-azcli#enable-pstn-dial-out-capability-for-a-room).
74+
7275

7376
### [csharp](#tab/csharp)
7477

7578
```csharp
76-
var callerIdNumber = new PhoneNumberIdentifier("+16044561234"); // This is the Azure Communication Services provisioned phone number for the caller
77-
var callThisPerson = new CallInvite(new PhoneNumberIdentifier("+16041234567"), callerIdNumber); // person to call
79+
var callerIdNumber = new PhoneNumberIdentifier("+16044561234"); // This is the ACS-provisioned phone number for the caller
80+
var callThisPerson = new CallInvite(new PhoneNumberIdentifier("+16041234567"), callerIdNumber); // The target phone number to dial out to
7881
CreateCallResult response = await client.GetCallConnection(callConnectionId).AddParticipantAsync(callThisPerson);
7982
```
8083

8184
### [Java](#tab/java)
8285

8386
```java
84-
PhoneNumberIdentifier callerIdNumber = new PhoneNumberIdentifier("+16044561234"); // This is the Azure Communication Services provisioned phone number for the caller
87+
PhoneNumberIdentifier callerIdNumber = new PhoneNumberIdentifier("+16044561234"); // This is the ACS-provisioned phone number for the caller
8588
CallInvite callInvite = new CallInvite(new PhoneNumberIdentifier("+16041234567"), callerIdNumber);
8689
AddParticipantOptions addParticipantOptions = new AddParticipantOptions(callInvite);
8790
Response<AddParticipantResult> addParticipantResultResponse = client.getCallConnectionAsync(callConnectionId)
@@ -92,8 +95,8 @@ Response<AddParticipantResult> addParticipantResultResponse = client.getCallConn
9295

9396
```javascript
9497
const callInvite = {
95-
targetParticipant: { phoneNumber: "+18008008800" }, // person to call
96-
sourceCallIdNumber: { phoneNumber: "+18888888888" } // This is the Azure Communication Services provisioned phone number for the caller
98+
targetParticipant: { phoneNumber: "+18008008800" }, // The target phone number to dial out to
99+
sourceCallIdNumber: { phoneNumber: "+18888888888" } // This is the ACS-provisioned phone number for the caller
97100
};
98101
const response = await client.getCallConnection(callConnectionId).addParticipant(callInvite);
99102
```
@@ -103,7 +106,7 @@ const response = await client.getCallConnection(callConnectionId).addParticipant
103106
```python
104107
caller_id_number = PhoneNumberIdentifier(
105108
"+18888888888"
106-
) # This is the Azure Communication Services provisioned phone number for the caller
109+
) # TThis is the ACS-provisioned phone number for the caller
107110
target = PhoneNumberIdentifier("+18008008800"),
108111

109112
call_connection_client = call_automation_client.get_call_connection(
@@ -125,7 +128,7 @@ result = call_connection_client.add_participant(
125128

126129
var removeThisUser = new PhoneNumberIdentifier("+16044561234");
127130

128-
// remove a participant from the call with optional parameters
131+
// Remove a participant from the call with optional parameters
129132
var removeParticipantOptions = new RemoveParticipantOptions(removeThisUser)
130133
{
131134
OperationContext = "operationContext",
@@ -216,7 +219,7 @@ result = call_connection_client.send_dtmf_tones(
216219
-----
217220

218221
### Call Recording
219-
ACS Rooms supports recording capabilities (start, stop, pause, resume, etc.) provided by Call Automation. The following code snippets are used to start/stop/pause/resume a recording in a room call. However, please refer to [Call Automation recording](../../concepts/voice-video-calling/call-recording#get-full-control-over-your-recordings-with-our-call-recording-apis) for a complete list of actions.
222+
Azure Communication Services rooms support recording capabilities including `start`, `stop`, `pause`, `resume`, and so on, provided by Call Automation. See the following code snippets to start/stop/pause/resume a recording in a room call. For a complete list of actions, see [Call Automation recording](../../concepts/voice-video-calling/call-recording.md#get-full-control-over-your-recordings-with-our-call-recording-apis).
220223

221224
### [csharp](#tab/csharp)
222225
```csharp
@@ -315,7 +318,7 @@ resume_recording = call_automation_client.resume_recording(recording_id = record
315318

316319

317320
### Terminate a Call
318-
Call Automation SDKs provides Hang Up action which can be used to terminate a call. CallDisconnected event is published once the Hang Up action has completed successfully.
321+
You can use the Call Automation SDK Hang Up action to terminate a call. When the Hang Up action completes, the SDK publishes a `CallDisconnected` event.
319322

320323
### [csharp](#tab/csharp)
321324

@@ -347,7 +350,7 @@ call_connection_client.hang_up(is_for_everyone=True)
347350
-----
348351

349352
## Other Actions
350-
The following mid-call actions are also supported in a room call.
353+
The following in-call actions are also supported in a room call.
351354
1. Add participant (ACS identifier)
352355
1. Remove participant (ACS identifier)
353356
1. Cancel add participant (ACS identifier and PSTN number)
@@ -360,15 +363,15 @@ The following mid-call actions are also supported in a room call.
360363
1. Recognize both DTMF and speech
361364
1. Recognize continuous DTMF
362365

363-
Please see [call actions](../../how-tos/call-automation/actions-for-call-control?branch=pr-en-us-280574&tabs=csharp) and [media actions](../../how-tos/call-automation/control-mid-call-media-actions?branch=pr-en-us-280574&tabs=csharp) for detail.
366+
For more information, see [call actions](../../how-tos/call-automation/actions-for-call-control.md?branch=pr-en-us-280574&tabs=csharp) and [media actions](../../how-tos/call-automation/control-mid-call-media-actions.md?branch=pr-en-us-280574&tabs=csharp).
364367

365368
## Next steps
366369

367370
In this section you learned how to:
368371
> [!div class="checklist"]
369372
> - Join a room call from your application
370-
> - Add mid-call actions into a room call using calling SDKs
371-
> - Add mid-call actions into a room call using Call Automation SDKs
373+
> - Add in-call actions into a room call using calling SDKs
374+
> - Add in-call actions into a room call using Call Automation SDKs
372375
373376
You may also want to:
374377
- Learn about [Rooms concept](../../concepts/rooms/room-concept.md)

0 commit comments

Comments
 (0)