Update acs calling native sdk data channel docs

Author: chengyuanlai-msft

articles/communication-services/quickstarts/voice-video-calling/includes/data-channel/data-channel-android.md

@@ -25,19 +25,7 @@ Refer to the [Voice Calling Quickstart](../../getting-started-with-calling.md?pi
 | DataChannelCallFeature | Used to start and manage data channel feature. | 
 | DataChannelSender | Used to manage a data channel as a sender and send data. | 
 | DataChannelReceiver | Used to manage a data channel as a receiver and receive data. |
-| DataChannelSenderCreateOptions | Used for representing options to create a data channel sender. |
-### Events
-| Name | Description |  
-| - | - |
-| DataChannelReceiverCreatedEvent | Describes the event when a receiver is created. A new receiver is created when receiving a data message from another endpoint through a new data channel for the first time. |
-| DataChannelReceiverMessageReceivedEvent | Describes the event when a data message is received and ready to be fetched. |
-| DataChannelReceiverClosedEvent | Describes the event when a data channel receiver is to be closed. |
-### Listeners
-| Name | Description |  
-| - | - |
-| DataChannelReceiverCreatedListener | Used to handle `DataChannelReceiverCreatedEvent`. |
-| DataChannelReceiverMessageReceivedListener | Used to handle `DataChannelReceiverMessageReceivedEvent`. |
-| DataChannelReceiverClosedListener | Used to handle `DataChannelReceiverClosedEvent`. |
+| DataChannelSenderOptions | Used for representing options to create a data channel sender. |
 ### Enums
 | Name | Description |  
 | - | - | 
@@ -56,7 +44,7 @@ DataChannelCallFeature dataChannelCallFeature = call.feature(Features.DATA_CHANN
 ```java
 DataChannelReceiverCreatedListener receiverCreatedListener = new DataChannelReceiverCreatedListener() {
     @Override
-    public void onDataChannelReceiverCreated(DataChannelReceiverCreatedEvent e) {
+    public void onReceiverCreated(DataChannelReceiverCreatedEvent e) {
         DataChannelReceiver receiver = e.getReceiver(); // get the new data channel receiver
         int channelId = receiver.getChannelId(); // get the channel id
         CommunicationIdentifier senderId = receiver.getSenderIdentifier(); // get the message sender id
@@ -68,26 +56,25 @@ DataChannelReceiverCreatedListener receiverCreatedListener = new DataChannelRece
 ```
 2. Register the `receiverCreatedListener`.
 ```java
-dataChannelCallFeature.addOnDataChannelReceiverCreatedListener(receiverCreatedListener);
+dataChannelCallFeature.addOnReceiverCreatedListener(receiverCreatedListener);
  ```
-3. Define the DataChannelReceiverMessageReceivedListener.
+3. Define the MessageReceivedListener.
 ```java
-DataChannelReceiverMessageReceivedListener messageReceivedListener = new DataChannelReceiverMessageReceivedListener() {
+MessageReceivedListener messageReceivedListener = new MessageReceivedListener() {
     @Override
-    public void onMessageReceived(DataChannelReceiverMessageReceivedEvent e) {
-        DataChannelMessage message = e.getReceiver().readMessage(); // read the data message from the receiver
+    public void onMessageReceived(PropertyChangedEvent e) {
+        DataChannelMessage message = e.getReceiver().popMessage(); // read the data message from the receiver
         int sequence = message.getSequenceNumber(); // get the message sequence number
         byte[] data = message.getData(); // get the data content
     }
 };
 ```
-4. Define the DataChannelReceiverClosedListener.
+4. Define the ReceiverClosedListener.
 ```java
-DataChannelReceiverClosedListener receiverClosedListener = new DataChannelReceiverClosedListener() {
+ReceiverClosedListener receiverClosedListener = new ReceiverClosedListener() {
     @Override
-    public void onReceiverClosed(DataChannelReceiverClosedEvent e) {
+    public void onReceiverClosed(PropertyChangedEvent e) {
         DataChannelReceiver receiver = e.getReceiver(); // get the data channel receiver to be closed
-        // clean up resources related to the receiver
     }
 };
 ```
@@ -97,9 +84,9 @@ receiver.addOnMessageReceivedListener(messageReceivedlistener);
 receiver.addOnClosedListener(receiverClosedListener);
 ```
 #### Sending data message
-1. Configure the DataChannelSenderCreateOptions.
+1. Configure the DataChannelSenderOptions.
 ```java
-DataChannelSenderCreateOptions options = new DataChannelSenderCreateOptions();
+DataChannelSenderOptions options = new DataChannelSenderOptions();
 options.setChannelId(1000);
 options.setBitrateInKbps(32);
 options.setPriority(DataChannelPriority.NORMAL);
@@ -108,9 +95,13 @@ options.setReliability(DataChannelReliability.LOSSY);
 List<CommunicationIdentifier> participants = Arrays.asList( /* identifier1, identifier2, ... */ );
 options.setParticipants(participants);
 ```
-2. Define the DataChannelSender and send data message
+2. Get the DataChannelSender and send data message
 ```java
-DataChannelSender dataChannelSender = dataChannelCallFeature.createDataChannelSender(options);
-dataChannelSender.setParticipants(new ArrayList<CommunicationIdentifier>()); // change participants in the channel if needed
-dataChannelSender.sendMessage(msgData); // msgData contains the byte[] data to be sent
+DataChannelSender dataChannelSender = dataChannelCallFeature.getDataChannelSender(options);
+
+// msgData contains the byte[] data to be sent
+dataChannelSender.sendMessage(msgData);
+
+// change participants in the channel if needed
+dataChannelSender.setParticipants(new ArrayList<CommunicationIdentifier>()); 
 ```

articles/communication-services/quickstarts/voice-video-calling/includes/data-channel/data-channel-ios.md

@@ -25,13 +25,7 @@ Refer to the [Voice Calling Quickstart](../../getting-started-with-calling.md?pi
 | DataChannelCallFeature | Used to start and manage data channel feature. | 
 | DataChannelSender | Used to manage a data channel as a sender and send data. | 
 | DataChannelReceiver | Used to manage a data channel as a receiver and receive data. |
-| DataChannelSenderCreateOptions | Used for representing options to create a data channel sender. |
-### Delegates
-| Name | Description |  
-| - | - |
-| didCreateDataChannelReceiver | Handles the event when a receiver is created. A new receiver is created when receiving a data message from another endpoint through a new data channel for the first time. |
-| didReceiveMessage | Handles the event when a data message is received and ready to be fetched. |
-| didClose | Handles the event when a data channel receiver is to be closed. |
+| DataChannelSenderOptions | Used for representing options to create a data channel sender. |
 ### Enums
 | Name | Description |  
 | - | - | 
@@ -47,41 +41,36 @@ var dataChannelCallFeature = self.call!.feature(Features.dataChannel)
 ```
 #### Receiving data message
 ```swift
-@State var callObserver:CallObserver?
-self.callObserver = CallObserver(view:self)
+let featureDelegate = new FeatureDelegate()
+let receiverDelegate = new ReceiverDelegate()
+dataChannelCallFeature!.delegate = featureDelegate
 
-extension CallObserver: DataChannelCallFeatureDelegate {
-    init(view:<nameOfView>) {
-        owner = view
-        super.init()
-    }
-    public func dataChannelCallFeature(_ dataChannelCallFeature: DataChannelCallFeature, didCreateDataChannelReceiver args: DataChannelReceiverCreatedEventArgs) {
-        let dataChannelReceiver = e.receiver // get the new data channel receiver
-        let channelId = dataChannelReceiver.channelId // get the channel id
-        let senderId = dataChannelReceiver.senderIdentifier // get the message sender id
-        dataChannelReceiver!.delegate = self;
+class FeatureDelegate: NSObject, DataChannelCallFeatureDelegate {
+    func onReceiverCreated(_ dataChannelCallFeature: DataChannelCallFeature, didCreateReceiver args: DataChannelReceiverCreatedEventArgs) {
+        let receiver = args.receiver // get the new data channel receiver
+        let channelId = receiver.channelId // get the channel id
+        let senderId = receiver.senderIdentifier // get the message sender id
+
+        receiver.delegate = receiverDelegate
     }
 }
 
-extension CallObserver: DataChannelReceiverDelegate {
-    public func dataChannelReceiver(_ dataChannelReceiver: DataChannelReceiver, didReceiveMessage args: DataChannelReceiverMessageReceivedEventArgs) {
-        let message = args.receiver.readMessage() // read the data message from the receiver
-        let sequence = message.sequenceNumber // get the message sequence number
-        let data = message.data // get the data content
+class ReceiverDelegate: NSObject, DataChannelReceiverDelegate {
+    func onMessageReceived(_ dataChannelReceiver: DataChannelReceiver, didReceiveMessage args: PropertyChangedEventArgs) {
+        let message = dataChannelReceiver.popMessage() // read the data message from the receiver
+        let sequence = message?.sequenceNumber // get the message sequence number
+        let data = message?.data // get the data content
     }
 
-    public func dataChannelReceiver(_ dataChannelReceiver: DataChannelReceiver, didClose args: DataChannelReceiverClosedEventArgs) {
-       let receiver = args.receiver // get the data channel receiver to be closed
-        // clean up resources related to the receiver
+    func onClosed(_ dataChannelReceiver: DataChannelReceiver, didClose args: PropertyChangedEventArgs) {
+       let channelId = dataChannelReceiver.channelId // get the data channel id to be closed
     }
 }
-
-dataChannelCallFeature!.delegate = self.callObserver
 ```
 #### Sending data message
-1. Configure the DataChannelSenderCreateOptions.
+1. Configure the DataChannelSenderOptions.
 ```swift
-let options = new DataChannelSenderCreateOptions()
+let options = new DataChannelSenderOptions()
 options.channelId = 1000
 options.bitrateInKbps = 32
 options.priority = DataChannelPriority.normal
@@ -92,8 +81,12 @@ options.participants = communicationIdentifiers
 ```
 2. Define the DataChannelSender and send data message
 ```swift
-DataChannelSender dataChannelSender = dataChannelCallFeature.createDataChannelSender(options)
+DataChannelSender sender = dataChannelCallFeature.getDataChannelSender(options)
+
+// msgData contains the data to be sent
+sender.sendMessage(msgData)
+
+// change participants in the channel if needed
 let participants: [CommunicationIdentifier] = []
-dataChannelSender.setParticipants(participants: participants) // change participants in the channel if needed
-dataChannelSender.sendMessage(msgData) // msgData contains the data to be sent
+dataChannelSender.setParticipants(participants: participants)
 ```

articles/communication-services/quickstarts/voice-video-calling/includes/data-channel/data-channel-windows.md

@@ -25,13 +25,7 @@ Refer to the [Voice Calling Quickstart](../../getting-started-with-calling.md?pi
 | DataChannelCallFeature | Used to start and manage data channel feature. | 
 | DataChannelSender | Used to manage a data channel as a sender and send data. | 
 | DataChannelReceiver | Used to manage a data channel as a receiver and receive data. |
-| DataChannelSenderCreateOptions | Used for representing options to create a data channel sender. |
-### Events
-| Name | Description |  
-| - | - |
-| DataChannelReceiverCreated | Describes the event when a receiver is created. A new receiver is created when receiving a data message from another endpoint through a new data channel for the first time. |
-| DataChannelReceiverMessageReceived | Describes the event when a data message is received and ready to be fetched. |
-| DataChannelReceiverClosed | Describes the event when a data channel receiver is to be closed. |
+| DataChannelSenderOptions | Used for representing options to create a data channel sender. |
 ### Enums
 | Name | Description |  
 | - | - | 
@@ -61,23 +55,22 @@ void DataChannelReceiverCreatedHandler(object sender, DataChannelReceiverCreated
 ```
 2. Attach the `DataChannelReceiverCreatedHandler`.
 ```csharp
-dataChannelCallFeature.DataChannelReceiverCreated += DataChannelReceiverCreatedHandler;
+dataChannelCallFeature.ReceiverCreated += DataChannelReceiverCreatedHandler;
  ```
-3. Define the DataChannelReceiverMessageReceived event handler.
+3. Define the MessageReceived event handler.
 ```csharp
-void MessageReceivedHandler(object sender, DataChannelReceiverMessageReceivedEventArgs args) 
+void MessageReceivedHandler(object sender, PropertyChangedEventArgs args) 
 {
-    DataChannelMessage message = args.Receiver.ReadMessage(); // read the data message from the receiver
-    uint sequence = message.SequenceNumber; // get the message sequence number
+    DataChannelMessage message = (sender as DataChannelReceiver).PopMessage(); // read the data message from the receiver
+    long sequence = message.SequenceNumber; // get the message sequence number
     byte[] data = message.Data; // get the data content
 }
 ```
-4. Define the DataChannelReceiverClosed event handler.
+4. Define the Closed event handler.
 ```csharp
-void ReceiverClosedHandler(object sender, DataChannelReceiverClosedEventArgs args) 
+void ReceiverClosedHandler(object sender, PropertyChangedEventArgs args) 
 {
-        DataChannelReceiver receiver = ergs.Receiver; // get the data channel receiver to be closed
-        // clean up resources related to the receiver
+    DataChannelReceiver receiver = sender as DataChannelReceiver; // get the data channel receiver to be closed
 };
 ```
 5. Attach the `MessageReceivedHandler` and `ReceiverClosedHandler`.
@@ -86,20 +79,21 @@ receiver.MessageReceived += MessageReceivedHandler;
 receiver.Closed += ReceiverClosedHandler;
 ```
 #### Sending data message
-1. Configure the DataChannelSenderCreateOptions.
+1. Configure the DataChannelSenderOptions.
 ```csharp
-DataChannelSenderCreateOptions options = new DataChannelSenderCreateOptions();
+DataChannelSenderOptions options = new DataChannelSenderOptions();
 options.ChannelId = 1000;
 options.BitrateInKbps = 32;
-options.Priority = DataChannelPriority.NORMAL;
-options.Reliability = DataChannelReliability.LOSSY;
+options.Priority = DataChannelPriority.Normal;
+options.Reliability = DataChannelReliability.Lossy;
 var participants = new List<CallIdentifier> { /* identifier1, identifier2, ... */ };
 options.Participants = participants.AsReadOnly();
 ```
 2. Define the DataChannelSender and send data message
 ```csharp
-DataChannelSender dataChannelSender = dataChannelCallFeature.CreateDataChannelSender(options);
-dataChannelSender.SetParticipants(new List<CallIdentifier>().AsReadOnly()); // change participants in the channel if needed
-dataChannelSender.SendMessageAsync(msgData); // msgData contains the byte[] data to be sent
-
+DataChannelSender sender = dataChannelCallFeature.GetDataChannelSender(options);
+// msgData contains the byte[] data to be sent
+sender.SendMessage(msgData);
+// change participants in the channel if needed
+sender.SetParticipants(new List<CallIdentifier>().AsReadOnly()); 
 ```