Skip to content

Commit 7376e40

Browse files
committed
dev feedback
1 parent 7c7459a commit 7376e40

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

articles/private-5g-core/whats-new.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,9 @@ Make the following changes for each 2022-04-01-preview API template that you wan
6060
| MediumPackage | G5 |
6161
| LargePackage | G10 |
6262

63-
2. In the **Attached Data Network** resource, add the new mandatory field **properties.dnsAddresses** if one doesn't already exist. List your chosen DNS addresses in an array or provide an empty array if no DNS addresses are required.
64-
3. In the **Sites** resource, remove the field **properties.networkFunctions**. This field is now read-only and will be ignored if provided.
63+
1. In the **Attached Data Network** resource, add the new mandatory field **properties.dnsAddresses** if one doesn't already exist. List your chosen DNS addresses in an array or provide an empty array if no DNS addresses are required.
64+
1. In the **Sites** resource, remove the field **properties.networkFunctions**. This field is now read-only and will be ignored if provided.
65+
1. Move the **Sites** resource above the **packetCoreControlPlanes** resource. This ensures that the resources are created in the required order.
6566

6667
See below for a comparison between templates using the 2022-04-01-preview and the 2022-11-01 APIs.
6768

@@ -78,10 +79,10 @@ See below for a comparison between templates using the 2022-04-01-preview and th
7879
"properties": {
7980
"networkFunctions": [
8081
{
81-
"id": "[resourceId('Microsoft.MobileNetwork/packetCoreControlPlanes', parameters('siteName'))]"
82+
"id": "[resourceId('Microsoft.MobileNetwork/packetCoreControlPlanes', parameters('siteID'))]"
8283
},
8384
{
84-
"id": "[resourceId('Microsoft.MobileNetwork/packetCoreControlPlanes/packetCoreDataPlanes', parameters('siteName'), parameters('siteName'))]"
85+
"id": "[resourceId('Microsoft.MobileNetwork/packetCoreControlPlanes/packetCoreDataPlanes', parameters('siteID'), parameters('siteID'))]"
8586
}
8687
]
8788
},
@@ -114,7 +115,6 @@ See below for a comparison between templates using the 2022-04-01-preview and th
114115
```
115116

116117
# [2022-11-01 API](#tab/2022-11-01)
117-
<!-- "sites": "parameters('siteName')", - should this have a new site ID parameter instead? -->
118118
```json
119119
{
120120
...
@@ -142,7 +142,7 @@ See below for a comparison between templates using the 2022-04-01-preview and th
142142
"apiVersion": "2022-11-01",
143143
...
144144
"properties": {
145-
"sites": "parameters('siteName')",
145+
"sites": "parameters('siteID')",
146146
"localDiagnosticsAccess": {
147147
"authenticationType": "Password"
148148
},

0 commit comments

Comments
 (0)