Merge pull request #254799 from mumian/1012-linter-no-deployments-resource

new linter rule - no deployments resources

Author: denrea

articles/azure-resource-manager/bicep/bicep-config-linter.md

@@ -48,6 +48,9 @@ The following example shows the rules that are available for configuration.
         "no-conflicting-metadata" : {
           "level": "warning"
         },
+        "no-deployments-resources" : {
+          "level": "warning"
+        }
         "no-hardcoded-env-urls": {
           "level": "warning"
         },

articles/azure-resource-manager/bicep/linter-rule-no-deployments-resources.md

@@ -0,0 +1,42 @@
+---
+title: Linter rule - no deployments resources
+description: Linter rule - no deployments resources
+ms.topic: conceptual
+ms.custom: devx-track-bicep
+ms.date: 10/12/2023
+---
+
+# Linter rule - no deployments resources
+
+This linter rule issues a warning when a template contains a `Microsoft.Resources/deployments` resource on the root level.
+
+## Linter rule code
+
+Use the following value in the [Bicep configuration file](bicep-config-linter.md) to customize rule settings:
+
+`no-deployments-resources`
+
+## Solution
+
+The following example fails this test because the template contains a `Microsoft.Resources/deployments` resource on the root level.
+
+```bicep
+param name string
+param specId string
+resource foo 'Microsoft.Resources/deployments@2023-07-01' = {
+  name: name
+  properties: {
+    mode: 'Incremental'
+    templateLink: {
+      uri: specId
+    }
+    parameters: {}
+  }
+}
+```
+
+It should be declared as a [Bicep module](./modules.md).
+
+## Next steps
+
+For more information about the linter, see [Use Bicep linter](./linter.md).

articles/azure-resource-manager/bicep/linter.md

@@ -26,6 +26,7 @@ The default set of linter rules is minimal and taken from [arm-ttk test cases](.
 - [max-resources](./linter-rule-max-resources.md)
 - [max-variables](./linter-rule-max-variables.md)
 - [no-conflicting-metadata](./linter-rule-no-conflicting-metadata.md)
+- [no-deployments-resources](./linter-rule-no-deployments-resources.md)
 - [no-hardcoded-env-urls](./linter-rule-no-hardcoded-environment-urls.md)
 - [no-hardcoded-location](./linter-rule-no-hardcoded-location.md)
 - [no-loc-expr-outside-params](./linter-rule-no-loc-expr-outside-params.md)
@@ -79,7 +80,7 @@ You can integrate these checks as a part of your CI/CD pipelines. You can use a
 
 ## Silencing false positives
 
-Sometimes a rule can have false positives. For example, you may need to include a link to a blob storage directly without using the [environment()](./bicep-functions-deployment.md#environment) function.
+Sometimes a rule can have false positives. For example, you might need to include a link to a blob storage directly without using the [environment()](./bicep-functions-deployment.md#environment) function.
 In this case you can disable the warning for one line only, not the entire document, by adding `#disable-next-line <rule name>` before the line with the warning.
 
 ```bicep

articles/azure-resource-manager/bicep/toc.yml

@@ -447,6 +447,9 @@
       - name: No conflicting metadata
         displayName: linter
         href: linter-rule-no-conflicting-metadata.md
+      - name: No deployments resources
+        displayName: linter
+        href: linter-rule-no-deployments-resources.md
       - name: No hardcoded environment URLs
         displayName: linter
         href: linter-rule-no-hardcoded-environment-urls.md