Skip to content

Commit 74c901a

Browse files
author
Kimmo Forss
committed
Review feedback
1 parent 116bcb0 commit 74c901a

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

articles/sap/automation/configure-control-plane.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,8 @@ xxx_vm_image = {
147147
This section defines the parameters used for defining the VM authentication.
148148

149149
> [!div class="mx-tdCol2BreakAll "]
150-
> | Variable | Description | Type | |
151-
> | ------------------------------------------------ | --------------------------------------------------- | ---------------------------------- | --------- |
150+
> | Variable | Description | Type |
151+
> | ------------------------------------------------ | ---------------------------------------------------------------------------------------- | --------- |
152152
> | `deployer_vm_authentication_type` | Defines the default authentication for the deployer | Optional |
153153
> | `deployer_authentication_username` | Administrator account name | Optional |
154154
> | `deployer_authentication_password` | Administrator password | Optional |

articles/sap/automation/configure-system.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ This section contains the parameters related to the Azure infrastructure.
8585
> | `custom_disk_sizes_filename` | Defines the disk sizing file name, See [Custom sizing](configure-extra-disks.md). | Optional |
8686
> | `resource_offset` | Provides an offset for resource naming. | Optional |
8787
> | `use_loadbalancers_for_standalone_deployments` | Controls if load balancers are deployed for standalone installations | Optional |
88-
> | `user_assigned_identity_id | User assigned identity to assign to the virtual machines | Optional |
88+
> | `user_assigned_identity_id` | User assigned identity to assign to the virtual machines | Optional |
8989
> | `vm_disk_encryption_set_id` | The disk encryption key to use for encrypting managed disks by using customer-provided keys. | Optional |
9090
> | `use_random_id_for_storageaccounts` | If defined will append a random string to the storage account name | Optional |
9191
> | | | |
@@ -101,7 +101,7 @@ This section contains the parameters related to the Azure infrastructure.
101101
> | `use_spn` | If defined the deployment will be performed using a Service Principal, otherwise an MSI | Optional |
102102
> | `use_private_endpoint` | Use private endpoints. | Optional |
103103
104-
the
104+
105105
The `resource_offset` parameter controls the naming of resources. For example, if you set the `resource_offset` to 1, the first disk will be named `disk1`. The default value is 0.
106106

107107
## SAP Application parameters
@@ -325,7 +325,7 @@ This section contains the parameters related to the anchor virtual machine.
325325
> | `anchor_vm_authentication_type` | Defines the authentication type for the anchor VM (key or password) | Optional |
326326
> | `anchor_vm_authentication_username` | Defines the username for the anchor VM | Optional |
327327
> | `anchor_vm_image` | Defines the VM image to use (as shown in the following code sample) | Optional |
328-
> | `anchor_vm_nic_ips[]` | List of IP addresses for the anchor VMs (app subnet) | Optional | |
328+
> | `anchor_vm_nic_ips[]` | List of IP addresses for the anchor VMs (app subnet) | Optional |
329329
> | `anchor_vm_sku` | Defines the VM SKU to use, for example, Standard_D4s_v3 | Optional |
330330
> | `anchor_vm_use_DHCP` | Controls whether to use dynamic IP addresses provided by Azure subnet | Optional |
331331
@@ -355,7 +355,7 @@ By default, the SAP system deployment uses the credentials from the SAP workload
355355
> | `automation_path_to_public_key` | Path to existing public key | Optional |
356356
> | `automation_path_to_private_key` | Path to existing private key | Optional |
357357
358-
## Other parameters
358+
## Miscellaneous parameters
359359

360360
> [!div class="mx-tdCol2BreakAll "]
361361
> | Variable | Description |
@@ -480,8 +480,8 @@ configuration_settings = {
480480
> [!div class="mx-tdCol2BreakAll "]
481481
> | Variable | Description | Type | Notes |
482482
> | ------------------------------------ | ---------------------------------------------------------------------- ----- | -------- | ------------------------------------- |
483-
> | `Agent_IP` | IP address of the agent. | Optional |
484-
> | `add_Agent_IP` | Controls if Agent IP is added to the key vault and storage account firewalls | Optional |
483+
> | `Agent_IP` | IP address of the agent. | Optional | |
484+
> | `add_Agent_IP` | Controls if Agent IP is added to the key vault and storage account firewalls | Optional | |
485485
486486
## Terraform parameters
487487

articles/sap/automation/configure-workload-zone.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,7 @@ ANF_service_level = "Ultra"
282282
> | `management_dns_subscription_id` | Subscription ID for the subscription that contains the private DNS zone. | Optional |
283283
> | `use_custom_dns_a_registration` | Use an existing private DNS zone. | Optional |
284284
285+
285286
## Other parameters
286287

287288
> [!div class="mx-tdCol2BreakAll "]
@@ -294,6 +295,7 @@ ANF_service_level = "Ultra"
294295
> | `add_Agent_IP` | Controls if Agent IP is added to the key vault and storage account firewalls | Optional | |
295296
> | `enable_firewall_for_keyvaults_and_storage` | Restrict access to selected subnets. | Optional | |
296297
298+
297299
## iSCSI parameters
298300

299301
> [!div class="mx-tdCol2BreakAll "]

0 commit comments

Comments
 (0)