Skip to content

Commit 773ffa8

Browse files
author
Yogesh Mohanraj (from Dev Box)
committed
Addressing PR feedback
1 parent d8a557e commit 773ffa8

File tree

4 files changed

+89
-29
lines changed

4 files changed

+89
-29
lines changed

articles/communication-services/quickstarts/email/includes/manage-suppression-list-java.md

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,23 @@ Update the code sample with the resource group name, the email service name, and
7171
For the list name, make sure it's the same as the sender username of the MailFrom address you would like to suppress emails from. These MailFrom addresses can be found in the "MailFrom addresses" section of your domain resource in the portal. For example, you may have a MailFrom address that looks like "[email protected]". The sender username for this address would be "donotreply" so a list name of "donotreply" should be used.
7272

7373
```java
74-
String resourceGroupName = "<your-resource-group-name>";
75-
String emailServiceName = "<your-email-service-name>";
76-
String domainResourceName = "<your-domain-name>";
74+
String resourceGroupName = "<your-resource-group-name>"; // Found in the essentials section of the domain resource portal overview
75+
String emailServiceName = "<your-email-service-name>"; // Found in the first part of the portal domain resource title
76+
String domainResourceName = "<your-domain-name>"; // Found in the second part of the portal domain resource title
7777
String suppressionListResourceName = "<your-suppression-list-resource-name>";
7878

7979
manager.suppressionLists().define(suppressionListResourceName)
8080
.withExistingDomain(resourceGroupName, emailServiceName, domainResourceName)
81-
.withListName("<your-sender-username>")
81+
.withListName("<your-sender-username>") // Should match the sender username of the MailFrom address you would like to suppress emails from
82+
.create();
83+
```
84+
85+
If you would like to suppress emails from all the sender usernames in particular domain, you can pass in an empty string for the list name.
86+
87+
```java
88+
manager.suppressionLists().define(suppressionListResourceName)
89+
.withExistingDomain(resourceGroupName, emailServiceName, domainResourceName)
90+
.withListName("")
8291
.create();
8392
```
8493

@@ -95,11 +104,13 @@ String suppressionListAddressId = "<your-suppression-list-address-id>";
95104

96105
manager.suppressionListAddresses().define(suppressionListAddressId)
97106
.withExistingSuppressionList(resourceGroupName, emailServiceName, domainResourceName, suppressionListResourceName)
98-
.withEmail("<email-address-to-suppress>")
107+
.withEmail("<email-address-to-suppress>") // Should match the email address you would like to block from receiving your messages
99108
.create();
100109
```
101110

102-
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Your email won't be sent to the suppressed address.
111+
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Make sure to send the email using the MailFrom address with the sender username you've chosen to suppress. Your email won't be sent to the suppressed address.
112+
113+
If you try sending an email with a domain that has not been suppressed, you will see that the email successfully sends.
103114

104115
## Remove an address from a suppression list
105116

@@ -110,7 +121,7 @@ manager.suppressionListAddresses()
110121
.delete(resourceGroupName, emailServiceName, domainResourceName, suppressionListResourceName, suppressionListAddressId);
111122
```
112123

113-
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Your email will successfully send to the previously suppressed address.
124+
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Make sure to send the email using the MailFrom address with the sender username you've chosen to suppress. Your email will successfully send to the previously suppressed address.
114125

115126
## Remove a suppression list from a domains resource
116127

articles/communication-services/quickstarts/email/includes/manage-suppression-list-js.md

Lines changed: 25 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,29 @@ Update the code sample with the resource group name, the email service name, and
4949
For the list name, make sure it's the same as the sender username of the MailFrom address you would like to suppress emails from. These MailFrom addresses can be found in the "MailFrom addresses" section of your domain resource in the portal. For example, you may have a MailFrom address that looks like "[email protected]". The sender username for this address would be "donotreply" so a list name of "donotreply" should be used.
5050

5151
```javascript
52-
const resourceGroupName = "<your-resource-group-name>";
53-
const emailServiceName = "<your-email-service-name>";
54-
const domainResourceName = "<your-domain-name>";
52+
const resourceGroupName = "<your-resource-group-name>"; // Found in the essentials section of the domain resource portal overview
53+
const emailServiceName = "<your-email-service-name>"; // Found in the first part of the portal domain resource title
54+
const domainResourceName = "<your-domain-name>"; // Found in the second part of the portal domain resource title
5555
const suppressionListResourceName = "<your-suppression-list-resource-name>";
5656

5757
parameters = {
58-
"listName": "<your-sender-username>",
58+
"listName": "<your-sender-username>", // Should match the sender username of the MailFrom address you would like to suppress emails from
59+
}
60+
61+
await client.suppressionLists.createOrUpdate(
62+
resourceGroupName,
63+
emailServiceName,
64+
domainResourceName,
65+
suppressionListResourceName,
66+
parameters
67+
);
68+
```
69+
70+
If you would like to suppress emails from all the sender usernames in particular domain, you can pass in an empty string for the list name.
71+
72+
```javascript
73+
parameters = {
74+
"listName": "",
5975
}
6076

6177
await client.suppressionLists.createOrUpdate(
@@ -79,7 +95,7 @@ To add multiple addresses to the suppression list, you need to repeat this code
7995
const suppressionListAddressId = "<your-suppression-list-address-id>";
8096

8197
parameters = {
82-
"email": "<email-address-to-suppress>"
98+
"email": "<email-address-to-suppress>" // Should match the email address you would like to block from receiving your messages
8399
}
84100

85101
await client.suppressionListAddresses.createOrUpdate(
@@ -93,7 +109,9 @@ await client.suppressionListAddresses.createOrUpdate(
93109

94110
```
95111

96-
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Your email won't be sent to the suppressed address.
112+
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Make sure to send the email using the MailFrom address with the sender username you've chosen to suppress. Your email won't be sent to the suppressed address.
113+
114+
If you try sending an email with a domain that has not been suppressed, you will see that the email successfully sends.
97115

98116
## Remove an address from a suppression list
99117

@@ -109,7 +127,7 @@ await client.suppressionListAddresses.delete(
109127
);
110128
```
111129

112-
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Your email will successfully send to the previously suppressed address.
130+
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Make sure to send the email using the MailFrom address with the sender username you've chosen to suppress. Your email will successfully send to the previously suppressed address.
113131

114132
## Remove a suppression list from a domains resource
115133

articles/communication-services/quickstarts/email/includes/manage-suppression-list-net.md

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,18 +50,29 @@ For the list name, make sure it's the same as the sender username of the MailFro
5050
The code sample will create the suppression list and store it in the `suppressionListResource` variable for future operations.
5151

5252
```csharp
53-
string subscriptionId = "<your-subscription-id>";
54-
string resourceGroupName = "<your-resource-group-name>";
55-
string emailServiceName = "<your-email-service-name>";
56-
string domainResourceName = "<your-domain-name>";
53+
string subscriptionId = "<your-subscription-id>"; // Found in the essentials section of the domain resource portal overview
54+
string resourceGroupName = "<your-resource-group-name>"; // Found in the essentials section of the domain resource portal overview
55+
string emailServiceName = "<your-email-service-name>"; // Found in the first part of the portal domain resource title
56+
string domainResourceName = "<your-domain-name>"; // Found in the second part of the portal domain resource title
5757
string suppressionListResourceName = "<your-suppression-list-resource-name>";
5858

5959
ResourceIdentifier suppressionListResourceId = SuppressionListResource.CreateResourceIdentifier(subscriptionId, resourceGroupName, emailServiceName, domainResourceName, suppressionListResourceName);
6060
SuppressionListResource suppressionListResource = client.GetSuppressionListResource(suppressionListResourceId);
6161

6262
SuppressionListResourceData suppressiontListData = new SuppressionListResourceData()
6363
{
64-
ListName = "<your-sender-username>",
64+
ListName = "<your-sender-username>", // Should match the sender username of the MailFrom address you would like to suppress emails from
65+
};
66+
67+
suppressionListResource.Update(WaitUntil.Completed, suppressiontListData);
68+
```
69+
70+
If you would like to suppress emails from all the sender usernames in particular domain, you can pass in an empty string for the list name.
71+
72+
```csharp
73+
SuppressionListResourceData suppressiontListData = new SuppressionListResourceData()
74+
{
75+
ListName = "",
6576
};
6677

6778
suppressionListResource.Update(WaitUntil.Completed, suppressiontListData);
@@ -83,13 +94,15 @@ SuppressionListAddressResource suppressionListAddressResource = client.GetSuppre
8394

8495
SuppressionListAddressResourceData suppressionListAddressData = new SuppressionListAddressResourceData()
8596
{
86-
Email = "<email-address-to-suppress>"
97+
Email = "<email-address-to-suppress>" // Should match the email address you would like to block from receiving your messages
8798
};
8899

89100
suppressionListAddressResource.Update(WaitUntil.Completed, suppressionListAddressData);
90101
```
91102

92-
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Your email won't be sent to the suppressed address.
103+
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Make sure to send the email using the MailFrom address with the sender username you've chosen to suppress. Your email won't be sent to the suppressed address.
104+
105+
If you try sending an email with a domain that has not been suppressed, you will see that the email successfully sends.
93106

94107
## Remove an address from a suppression list
95108

@@ -99,7 +112,7 @@ To remove an address from the suppression list, create the `SuppressionListAddre
99112
suppressionListAddressResource.Delete(WaitUntil.Completed);
100113
```
101114

102-
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Your email will successfully send to the previously suppressed address.
115+
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Make sure to send the email using the MailFrom address with the sender username you've chosen to suppress. Your email will successfully send to the previously suppressed address.
103116

104117
## Remove a suppression list from a domains resource
105118

articles/communication-services/quickstarts/email/includes/manage-suppression-list-python.md

Lines changed: 25 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ For the list name, make sure it's the same as the sender username of the MailFro
5050

5151

5252
```python
53-
resource_group_name = "<your-resource-group-name>";
54-
email_service_name = "<your-email-service-name>";
55-
domain_resource_name = "<your-domain-name>";
53+
resource_group_name = "<your-resource-group-name>"; # Found in the essentials section of the domain resource portal overview
54+
email_service_name = "<your-email-service-name>"; # Found in the first part of the portal domain resource title
55+
domain_resource_name = "<your-domain-name>"; # Found in the second part of the portal domain resource title
5656
suppression_list_resource_name = "<your-suppression-list-resource-name>";
5757

5858
mgmt_client.suppression_lists.create_or_update(
@@ -62,7 +62,23 @@ mgmt_client.suppression_lists.create_or_update(
6262
suppression_list_resource_name,
6363
parameters={
6464
"properties": {
65-
"listName": "<your-sender-username>"
65+
"listName": "<your-sender-username>" # Should match the sender username of the MailFrom address you would like to suppress emails from
66+
}
67+
},
68+
)
69+
```
70+
71+
If you would like to suppress emails from all the sender usernames in particular domain, you can pass in an empty string for the list name.
72+
73+
```python
74+
mgmt_client.suppression_lists.create_or_update(
75+
resource_group_name,
76+
email_service_name,
77+
domain_resource_name,
78+
suppression_list_resource_name,
79+
parameters={
80+
"properties": {
81+
"listName": ""
6682
}
6783
},
6884
)
@@ -87,13 +103,15 @@ mgmt_client.suppression_list_addresses.create_or_update(
87103
suppression_list_address_id,
88104
parameters={
89105
"properties": {
90-
"email": "<email-address-to-suppress>"
106+
"email": "<email-address-to-suppress>" # Should match the email address you would like to block from receiving your messages
91107
}
92108
},
93109
)
94110
```
95111

96-
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Your email won't be sent to the suppressed address.
112+
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Make sure to send the email using the MailFrom address with the sender username you've chosen to suppress. Your email won't be sent to the suppressed address.
113+
114+
If you try sending an email with a domain that has not been suppressed, you will see that the email successfully sends.
97115

98116
## Remove an address from a suppression list
99117

@@ -109,7 +127,7 @@ mgmt_client.suppression_list_addresses.delete(
109127
)
110128
```
111129

112-
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Your email will successfully send to the previously suppressed address.
130+
You can now try sending an email to the suppressed address from the [`TryEmail` section of your Communication Service resource](./try-send-email.md) or by [using one of the Email SDKs](../send-email.md). Make sure to send the email using the MailFrom address with the sender username you've chosen to suppress. Your email will successfully send to the previously suppressed address.
113131

114132
## Remove a suppression list from a domains resource
115133

0 commit comments

Comments
 (0)