Skip to content

Commit 791ef63

Browse files
daviburgecfan
andauthored
Apply suggestions from code review
Slight modification to avoid confusion about gateway overall configuration versus SAP adapter component specific configuration. Co-authored-by: Esther Fan <[email protected]>
1 parent 7dc3bca commit 791ef63

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

articles/logic-apps/logic-apps-using-sap-connector.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -898,39 +898,39 @@ If you're receiving this error message and experience intermittent failures call
898898

899899
1. Check SAP settings in your on-premises data gateway service configuration file, `Microsoft.PowerBI.EnterpriseGateway.exe.config`.
900900

901-
1. Add a `configSections` element under the `configuration` root node if it is not already present.
902-
1. Add a `section` element with attributes `name="SapAdapterSection" type="Microsoft.Adapters.SAP.Common.SapAdapterSection, Microsoft.Adapters.SAP.Common"` under the `configSections` node if it is not already present.
901+
1. Under the `configuration` root node, add a `configSections` element, if none exists.
902+
1. Under the `configSections` node, add a `section` element with the following attributes, if none exist: `name="SapAdapterSection" type="Microsoft.Adapters.SAP.Common.SapAdapterSection, Microsoft.Adapters.SAP.Common"`
903903

904904
> [!IMPORTANT]
905-
> Do not modify attributes of existing `section` elements if such elements already exist.
905+
> Don't change the attributes in existing `section` elements, if such elements already exist.
906906
907-
1. If no other section or section group is declared in the configuration, the `configSections` element will be a follows:
907+
Your `configSections` element looks like the following version, if no other section or section group is declared in the gateway service configuration:
908908

909909
```xml
910910
<configSections>
911911
<section name="SapAdapterSection" type="Microsoft.Adapters.SAP.Common.SapAdapterSection, Microsoft.Adapters.SAP.Common"/>
912912
</configSections>
913913
```
914914

915-
1. Add a `SapAdapterSection` element under the `configuration` root node if it is not already present.
916-
1. Add a `Broker` element with attributes `WebhookRetryDefaultDelay="00:00:00.10" WebhookRetryMaximumCount="2"` under the `SapAdapterSection` node if it is not already present.
915+
1. Under the `configuration` root node, add an `SapAdapterSection` element, if none exists.
916+
1. Under the `SapAdapterSection` node, add a `Broker` element with the following attributes, if none exist: `WebhookRetryDefaultDelay="00:00:00.10" WebhookRetryMaximumCount="2"`
917917

918918
> [!IMPORTANT]
919-
> Modify attributes of existing `Broker` element if such element already exists.
919+
> Change the attributes for the `Broker` element, even if the element already exists.
920920

921-
1. If no other element or attribute is declared in the SAP adapter configuration, the `SapAdapterSection` element will be a follows:
921+
The `SapAdapterSection` element looks like the following version, if no other element or attribute is declared in the SAP adapter configuration:
922922

923923
```xml
924924
<SapAdapterSection>
925925
<Broker WebhookRetryDefaultDelay="00:00:00.10" WebhookRetryMaximumCount="2" />
926926
</SapAdapterSection>
927927
```
928928

929-
The retry count setting looks like `WebhookRetryMaximumCount="2"`. The retry interval setting looks like `WebhookRetryDefaultDelay="00:00:00.10"` and the timespan format is `HH:mm:ss.ff`.
929+
The retry count setting looks like `WebhookRetryMaximumCount="2"`. The retry interval setting looks like `WebhookRetryDefaultDelay="00:00:00.10"` where the timespan format is `HH:mm:ss.ff`.
930930

931931
> [!NOTE]
932932
> For more information about the configuration file,
933-
> read [Configuration file schema for .NET Framework](/dotnet/framework/configure-apps/file-schema/).
933+
> review [Configuration file schema for .NET Framework](/dotnet/framework/configure-apps/file-schema/).
934934

935935
1. Save your changes. Restart your on-premises data gateway.
936936

0 commit comments

Comments
 (0)