Skip to content

Commit 83fd96d

Browse files
Merge pull request #290167 from vac0224/vc-diagnostics-code-fix-2024-11-15
Media statistics code fix
2 parents b3af342 + f6db75b commit 83fd96d

File tree

3 files changed

+48
-56
lines changed

3 files changed

+48
-56
lines changed

articles/communication-services/concepts/voice-video-calling/includes/media-stats/media-stats-web.md

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,13 @@ Media quality statistics is an extended feature of the core `Call` API. You firs
2323
const mediaStatsFeature = call.feature(Features.MediaStats);
2424
```
2525

26-
To receive the media statistics data, you can subscribe `sampleReported` event or `summaryReported` event.
26+
To receive the media statistics data, you can subscribe to the `sampleReported` event or the `summaryReported` event.
2727

28-
`sampleReported` event triggers every second. It's suitable as a data source for UI display or your own data pipeline.
28+
The `sampleReported` event triggers every second. It's suitable as a data source for UI display or your own data pipeline.
2929

30-
`summaryReported` event contains the aggregated values of the data over intervals, which is useful when you just need a summary.
30+
The `summaryReported` event contains the aggregated values of the data over intervals, which is useful when you just need a summary.
3131

32-
If you want control over the interval of the `summaryReported` event, you need to define `mediaStatsCollectorOptions` of type `MediaStatsCollectorOptions`.
33-
Otherwise, the SDK uses default values.
32+
If you want control over the interval of the `summaryReported` event, you need to define `mediaStatsCollectorOptions` of type `MediaStatsCollectorOptions`. Otherwise, the SDK uses default values.
3433

3534

3635
```js
@@ -50,12 +49,13 @@ mediaStatsCollector.on('summaryReported', (summary) => {
5049
});
5150
```
5251

53-
In case you don't need to use the media statistics collector, you can call `dispose` method of `mediaStatsCollector`.
52+
If you don't need to use the media statistics collector, you can call `dispose` method of `mediaStatsCollector`.
5453

5554
```js
5655
mediaStatsCollector.dispose();
5756
```
58-
It's not necessary to call `dispose` method of `mediaStatsCollector` every time when the call ends, as the collectorsare reclaimed internally when the call ends.
57+
58+
You don't need to call `dispose` method of `mediaStatsCollector` every time when the call ends, because the collectors are reclaimed internally when the call ends.
5959

6060
### MediaStatsCollectorOptions
6161

@@ -80,15 +80,15 @@ If you set the following values:
8080
- `aggregatinInterval` = 60
8181
- `dataPointsPerAggregation` = 1
8282

83-
The `summaryReported` event is raised every 60 seconds and contains 1 unique unit for each statistic recorded.
83+
The `summaryReported` event is raised every 60 seconds and contains one (1) unique unit for each statistic recorded.
8484

8585
## Best practices
8686

8787
If you want to collect the data for offline inspection, we recommend that you collect the data and send it to your pipeline ingestion after your call ends. If you transmit the data during a call, it could use internet bandwidth needed to continue an Azure Communication Services call (especially when available bandwidth is low).
8888

89-
In either `sampleReported` event or `summaryReported` event, the media statistics data are not just a simple key-value mapping.
89+
In either `sampleReported` event or `summaryReported` event, the media statistics data aren't just a simple key-value mapping.
9090

91-
Here is the type declaration of the event data reported by `sampleReported` event.
91+
Here's the type declaration of the event data reported by `sampleReported` event.
9292

9393
```typescript
9494
export interface MediaStatsReportSample {
@@ -106,11 +106,11 @@ export interface MediaStatsReportSample {
106106
};
107107
transports: TransportMediaStats<number>[];
108108
}
109-
110109
```
110+
111111
The event data provide the statistics data for each media stream in the call, including both send and receive directions.
112112

113-
It's recommended that you print the event using the `console.log` to observe its layout and value changes, so you can find a proper way to display or process the data according to your usage scenario.
113+
We recommended that you print the event using the `console.log` to observe its layout and value changes, so you can find a proper way to display or process the data according to your usage scenario.
114114

115115
### Audio send metrics
116116

@@ -130,7 +130,7 @@ It's recommended that you print the event using the `console.log` to observe its
130130

131131
### Audio receive metrics
132132

133-
In the SDK versions ealier than 1.20.1, `jitterBufferDelayInMs` existed as `jitterBufferInMs`.
133+
In the SDK versions earlier than 1.20.1, `jitterBufferDelayInMs` existed as `jitterBufferInMs`.
134134

135135
| Metric name | Description | Comments |
136136
| ----------- | ----------- | -------- |
@@ -149,7 +149,7 @@ In the SDK versions ealier than 1.20.1, `jitterBufferDelayInMs` existed as `jitt
149149

150150
### Video send metrics
151151

152-
Starting from SDK version 1.20.1, the video send metrics included the `altLayouts` metric field, which allows for a better representation of simulcast stream statistics.
152+
Starting from SDK version 1.20.1, the video send metrics included the `altLayouts` metric field, which enable a better representation of simulcast stream statistics.
153153

154154
| Metric name | Description | Comments |
155155
| ----------- | ----------- | -------- |
@@ -232,13 +232,13 @@ In earlier versions, `rttInMs` existed as `pairRttInMs` in the stats for audio,
232232
## What are changed in SDK version 1.20.1 (GA)
233233

234234
We now support MediaStats feature API in 1.20.1 (GA).
235+
235236
Compared to the previous beta versions, we also made some minor changes to the API interface in this GA version.
236237

237-
In the previous beta versions, `pairRttInMs`, `availableBitrate` were included in audio, video, and screenShare statistics.
238-
Now, these metrics have been separated into transport metrics.
238+
In the previous beta versions, `pairRttInMs`, `availableBitrate` were included in audio, video, and screenShare statistics. Now these metrics are separated into transport metrics.
239239

240-
We introduced `packets`, `packetsLost` metric fields in audio, video, screenShare statistics. These metrics are useful for calculating the total number of packets sent or recieved between two different time points.
240+
We introduced `packets` and `packetsLost` metric fields in audio, video, screenShare statistics. These metrics are useful for calculating the total number of packets sent or recieved between two different time points.
241241

242242
The `frameRateOutput` in video and screenShare statistics is removed. You can use `frameRateDecoded` instead.
243243

244-
The metric field `jitterBufferInMs` has been renamed to `jitterBufferDelayInMs` to provide a clearer description, as this metric indicates the duration of a packet stay in the jitter buffer.
244+
The metric field `jitterBufferInMs` is renamed to `jitterBufferDelayInMs` to provide a clearer description, because this metric indicates the duration of a packet stay in the jitter buffer.

articles/communication-services/concepts/voice-video-calling/media-quality-sdk.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ zone_pivot_groups: acs-plat-web-ios-android-windows
1616

1717
# Media quality statistics
1818

19-
To help you understand media quality in VoIP and video calls that use Azure Communication Services, there's a feature called *media quality statistics*. Use it to examine the low-level audio, video, and screen-sharing quality metrics for incoming and outgoing call metrics.
19+
To help you better understand media quality in VoIP and video calls that use Azure Communication Services, there's a feature called *media quality statistics*. Use it to examine the low-level audio, video, and screen-sharing quality metrics for incoming and outgoing call metrics.
2020

2121
::: zone pivot="platform-web"
2222
[!INCLUDE [Media Stats for Web](./includes/media-stats/media-stats-web.md)]

0 commit comments

Comments
 (0)