Skip to content

Commit 842afd5

Browse files
committed
Ramya comments
1 parent abc1ddd commit 842afd5

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

articles/azure-functions/functions-deploy-container-apps.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,13 @@ In the [`az functionapp create`](/cli/azure/functionapp#az-functionapp-create) c
117117
To use a system-assigned managed identity to access the container registry, you need to enable managed identities in your app and grant the system-assigned managed identity access to the container registry. This example uses `az functionapp identity assign` and `az role assignment create` command to enable managed identities in the app and assign the system-assigned identity to the `ACRPull` role in the container registry:
118118

119119
```azurecli
120-
FUNCTION_APP_ID=$(az functionapp identity assign --name glengatestaca-py --resource-group AzureFunctionsContainers-rg --query principalId --output tsv)
121-
ACR_ID=$(az acr show --name glengatest --query id --output tsv)
120+
FUNCTION_APP_ID=$(az functionapp identity assign --name <APP_NAME> --resource-group AzureFunctionsContainers-rg --query principalId --output tsv)
121+
ACR_ID=$(az acr show --name <REGISTRY_NAME> --query id --output tsv)
122122
az role assignment create --assignee $FUNCTION_APP_ID --role AcrPull --scope $ACR_ID
123123
```
124124

125+
In this example, replace `<APP_NAME>` and `<REGISTRY_NAME>` with the name of your function app and container registry, respectively.
126+
125127
### [Docker Hub](#tab/docker)
126128
::: zone pivot="programming-language-csharp"
127129
```azurecli
@@ -154,7 +156,9 @@ az functionapp create --name <APP_NAME> --storage-account <STORAGE_NAME> --envir
154156
```
155157
::: zone-end
156158

157-
In the [`az functionapp create`](/cli/azure/functionapp#az-functionapp-create) command, the `--environment` parameter specifies the Container Apps environment and the `--image` parameter specifies the image to use for the function app. In this example, replace `<STORAGE_NAME>` with the name you used in the previous section for the storage account. Also, replace `<APP_NAME>` with a globally unique name appropriate to you and `<DOCKER_ID>` with your Docker Hub account ID. If you're using a private registry, you also need to supply `--registry-username`, `--registry-password`, and `--registry-server`.
159+
In the [`az functionapp create`](/cli/azure/functionapp#az-functionapp-create) command, the `--environment` parameter specifies the Container Apps environment and the `--image` parameter specifies the image to use for the function app. In this example, replace `<STORAGE_NAME>` with the name you used in the previous section for the storage account. Also, replace `<APP_NAME>` with a globally unique name appropriate to you and `<DOCKER_ID>` with your public Docker Hub account ID.
160+
161+
If you're using a private registry, you need to include the fully qualified domain name of your registry instead of just the Docker ID for `<DOCKER_ID>`, along with the `--registry-username` and `--registry-password` credential required to access the registry.
158162

159163
---
160164

articles/azure-functions/functions-how-to-custom-container.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,9 @@ You aren't currently able to continuously deploy containers based on image chang
323323
> [!IMPORTANT]
324324
> Webhook-based deployment isn't currently supported when running your container in an [Elastic Premium plan](functions-premium-plan.md). If you need to use the continuous deployment method described in this section, instead deploy your container in an [App Service plan](dedicated-plan.md). When running in an Elastic Premium plan, you need to manually restart your app whenever you make updates to your container in the repository.
325325
>
326-
> You can also configure continous deployment from a source code repository using either [Azure Pipelines](./functions-how-to-azure-devops.md#deploy-a-container) or [GitHub Actions](./functions-how-to-github-actions.md?tabs=container).
326+
> You can also configure continous deployment from a source code repository using either [Azure Pipelines](./functions-how-to-azure-devops.md#deploy-a-container) or [GitHub Actions](https://github.com/Azure/azure-functions-on-container-apps/blob/main/samples/GitHubActions/Func_on_ACA_GitHubAction_deployment.yml).
327+
328+
<!--- replace with [GitHub Actions](./functions-how-to-github-actions.md?tabs=container) after the updated article is published. -->
327329

328330
You can enable Azure Functions to automatically update your deployment of an image whenever you update the image in the registry.
329331

0 commit comments

Comments
 (0)