Merge pull request #206335 from radubulboaca/master

update quickstarts for communication-services rooms with additional review comments

Author: PRMerger5

articles/communication-services/quickstarts/rooms/get-started-rooms.md

@@ -19,10 +19,6 @@ zone_pivot_groups: acs-js-csharp-java-python
 
 This quickstart will help you get started with Azure Communication Services Rooms. A `room` is a server-managed communications space for a known, fixed set of participants to collaborate for a pre-determined duration. The [rooms conceptual documentation](../../concepts/rooms/room-concept.md) covers more details and use cases for `rooms`.
 
-::: zone pivot="programming-language-javascript"
-[!INCLUDE [Use rooms with Java SDK](./includes/rooms-quickstart-javascript.md)]
-::: zone-end
-
 ::: zone pivot="programming-language-csharp"
 [!INCLUDE [Use rooms with .NET SDK](./includes/rooms-quickstart-net.md)]
 ::: zone-end
@@ -35,6 +31,10 @@ This quickstart will help you get started with Azure Communication Services Room
 [!INCLUDE [Use rooms with Java SDK](./includes/rooms-quickstart-python.md)]
 ::: zone-end
 
+::: zone pivot="programming-language-javascript"
+[!INCLUDE [Use rooms with Java SDK](./includes/rooms-quickstart-javascript.md)]
+::: zone-end
+
 ## Object model
 
 The table below lists the main properties of `room` objects: 
@@ -46,6 +46,7 @@ The table below lists the main properties of `room` objects:
 | `validUntil`          | Latest time a `room` can be used. |
 | `roomJoinPolicy`      | Specifies which user identities are allowed to join room calls. Valid options are `InviteOnly` and `CommunicationServiceUsers`. | 
 | `participants`        | List of participants to a `room`. Specified as a `CommunicationIdentifier`. | 
+| `roleType`            | The role of a room participant. Can be either `Presenter`, `Attendee`, or `Consumer`. |
 
 ## Next steps
 

articles/communication-services/quickstarts/rooms/includes/rooms-quickstart-java.md

@@ -114,7 +114,7 @@ CommunicationRoom roomResult = roomsClient.getRoom(roomId);
 
 ### Update the lifetime of a room
 
-The lifetime of a `room` can be modified by issuing an update request for the `ValidFrom` and `ValidUntil` parameters.
+The lifetime of a `room` can be modified by issuing an update request for the `ValidFrom` and `ValidUntil` parameters. A room can be valid for a maximum of six months. 
 
 ```java
 OffsetDateTime validFrom = OffsetDateTime.of(2022, 2, 1, 5, 30, 20, 10, ZoneOffset.UTC);
@@ -149,6 +149,19 @@ try {
 
 Participants that have been added to a `room` become eligible to join calls.
 
+### Get list of participants
+
+Retrieve the list of participants for an existing `room` by referencing the `roomId`:
+
+```java
+try {
+    ParticipantsCollection participants = roomsClient.listParticipants(roomId);
+    System.out.println("Participants: \n" + participants.getParticipants());
+} catch (Exception ex) {
+    System.out.println(ex);
+}
+```
+
 ### Remove participants
 
 To remove a participant from a `room` and revoke their access, use the `removeParticipants` method.

articles/communication-services/quickstarts/rooms/includes/rooms-quickstart-javascript.md

@@ -86,7 +86,7 @@ console.log(`Retrieved Room with ID ${roomId}`);
 
 ### Update the lifetime of a room
 
-The lifetime of a `room` can be modified by issuing an update request for the `ValidFrom` and `ValidUntil` parameters.
+The lifetime of a `room` can be modified by issuing an update request for the `ValidFrom` and `ValidUntil` parameters. A room can be valid for a maximum of six months. 
 
 ```javascript
 validFrom.setTime(validUntil.getTime());
@@ -128,6 +128,14 @@ To add new participants to a `room`, use the `addParticipants` method exposed on
 
 Participants that have been added to a `room` become eligible to join calls.
 
+### Get list of participants
+
+Retrieve the list of participants for an existing `room` by referencing the `roomId`:
+
+```javascript
+  const participantsList = await roomsClient.getParticipants(roomId);
+```
+
 ### Remove participants
 
 To remove a participant from a `room` and revoke their access, use the `removeParticipants` method.

articles/communication-services/quickstarts/rooms/includes/rooms-quickstart-net.md

@@ -78,7 +78,7 @@ RoomModel getCommunicationRoom = getRoomResponse.Value;
 
 ### Update the lifetime of a room
 
-The lifetime of a `room` can be modified by issuing an update request for the `ValidFrom` and `ValidUntil` parameters.
+The lifetime of a `room` can be modified by issuing an update request for the `ValidFrom` and `ValidUntil` parameters. A room can be valid for a maximum of six months. 
 
 ```csharp
 var validFrom = new DateTime(2022, 05, 01, 00, 00, 00, DateTimeKind.Utc);
@@ -112,6 +112,15 @@ ParticipantsCollection addedParticipantsRoom = addParticipantResponse.Value;
 
 Participants that have been added to a `room` become eligible to join calls.
 
+### Get list of participants
+
+Retrieve the list of participants for an existing `room` by referencing the `roomId`:
+
+```csharp
+Response<ParticipantsCollection> getParticipantsResponse = await roomsClient.GetParticipantsAsync(roomId);
+ParticipantsCollection roomParticipants = getParticipantsResponse.Value;
+```
+
 ### Remove participants
 
 To remove a participant from a `room` and revoke their access, use the `RemoveParticipantsAsync` method.

articles/communication-services/quickstarts/rooms/includes/rooms-quickstart-python.md

@@ -53,8 +53,8 @@ if __name__ == '__main__':
 From a console prompt, navigate to the directory containing the rooms.py file, then execute the following command:
 
 ```console
-pip install azure_communication_rooms
-pip install azure.communication.identity
+pip install azure-communication-rooms
+pip install azure-communication-identity
 ```
 
 ### Initialize a room client
@@ -63,7 +63,7 @@ Create a new `RoomsClient` object that will be used to create new `rooms` and ma
 
 ```python
 #Find your Communication Services resource in the Azure portal
-self.connection_string = os.getenv("COMMUNICATION_SAMPLES_CONNECTION_STRING")
+self.connection_string = <COMMUNICATION_SAMPLES_CONNECTION_STRING>
 self.rooms_client = RoomsClient.from_connection_string(self.connection_string)
 ```
 
@@ -100,7 +100,7 @@ except HttpResponseError as ex:
 
 ### Update the lifetime of a room
 
-The lifetime of a `room` can be modified by issuing an update request for the `ValidFrom` and `ValidUntil` parameters.
+The lifetime of a `room` can be modified by issuing an update request for the `ValidFrom` and `ValidUntil` parameters. A room can be valid for a maximum of six months. 
 
 ```python
 # set attributes you want to change
@@ -121,17 +121,26 @@ To add new participants to a `room`, use the `add_participants` method exposed o
 ```python
 try:
     participants = []
-    for p in participants_list:
-        participants.append(RoomParticipant(CommunicationUserIdentifier(p), RoleType.ATTENDEE))
+    participants.append(RoomParticipant(CommunicationUserIdentifier("<ACS User MRI identity 1>"), RoleType.ATTENDEE))
     self.rooms_client.add_participants(room_id, participants)
 
-    print(str(len(participants)) + ' new participants added to the room : ' + str(room_id))
 except Exception as ex:
-    print('Error in adding participants to room.',ex)
+    print('Error in adding participants to room.', ex)
 ```
 
 Participants that have been added to a `room` become eligible to join calls.
 
+### Get list of participants
+
+Retrieve the list of participants for an existing `room` by referencing the `roomId`:
+
+```python
+try:
+    participants = self.rooms_client.get_participants(room_id)
+except HttpResponseError as ex:
+    print(ex)
+```
+
 ### Remove participants
 
 To remove a participant from a `room` and revoke their access, use the `remove_participants` method.