Skip to content

Commit 85ae380

Browse files
Merge pull request #253413 from johnsta/patch-2
Quickstart feedback
2 parents 4e5617f + 3cea84b commit 85ae380

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

articles/playwright-testing/quickstart-automate-end-to-end-testing.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ If you haven't configured your Playwright tests yet for running them on cloud-ho
114114

115115
1. Create a new file `playwright.service.config.ts` alongside the `playwright.config.ts` file.
116116

117-
1. Create a file `playwright.service.config.ts` and add the following content to it:
117+
1. Add the following content to it:
118118

119119
```typescript
120120
import { defineConfig } from '@playwright/test';
@@ -185,6 +185,7 @@ Update the CI workflow definition to run your Playwright tests with the Playwrig
185185
# Access token and regional endpoint for Microsoft Playwright Testing
186186
PLAYWRIGHT_SERVICE_ACCESS_TOKEN: ${{ secrets.PLAYWRIGHT_SERVICE_ACCESS_TOKEN }}
187187
PLAYWRIGHT_SERVICE_URL: ${{ secrets.PLAYWRIGHT_SERVICE_URL }}
188+
PLAYWRIGHT_SERVICE_RUN_ID: ${{ github.run_id }}-${{ github.run_attempt }}-${{ github.sha }}
188189
run: npx playwright test -c playwright.service.config.ts --workers=20
189190
```
190191

articles/playwright-testing/quickstart-run-end-to-end-tests.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ When the workspace creation finishes, you're redirected to the setup guide.
3030

3131
## Create an access token for service authentication
3232

33-
Microsoft Playwright Testing uses access token to authorize users to run Playwright tests with the service. You first generate a service access token in the Playwright portal, and then store the value in an environment variable.
33+
Microsoft Playwright Testing uses access tokens to authorize users to run Playwright tests with the service. You first generate a service access token in the Playwright portal, and then store the value in an environment variable.
3434

3535
To generate the access token, perform the following steps:
3636

@@ -86,7 +86,7 @@ To add the service configuration to your project:
8686
8787
1. Create a new file `playwright.service.config.ts` alongside the `playwright.config.ts` file.
8888
89-
1. Create a file `playwright.service.config.ts` and add the following content to it:
89+
1. Add the following content to it:
9090
9191
```typescript
9292
import { defineConfig } from '@playwright/test';

0 commit comments

Comments
 (0)