Update instruction for pv2 creation (Azure CLI side)

Author: VincentLiu777

articles/storage/files/storage-how-to-create-file-share.md

@@ -229,34 +229,20 @@ $storageAccount = New-AzStorageAccount `
 
 # [Azure CLI](#tab/azure-cli)
 ### Create a provisioned v2 storage account (Azure CLI)
-The Azure CLI storage command group doesn't currently support creating provisioned v2 storage accounts. To create a provisioned v2 storage account using Azure CLI, use the `az resource create` command. Storage account properties can be set using the `--properties` parameter of the command. See [Microsoft.Storage resource provider REST API documentation](/rest/api/storagerp/storage-accounts/create#request-body) to learn more about the possible property names.
+To create a provisioned v2 storage account using Azure CLI, use the `az storage account create` command. This command has many options; only the required options are shown. To learn more about the advanced options, see the [`az storage account create` command documentation](/cli/azure/storage/account).
 
-To create a storage account for provisioned v2 file shares, use the following command. Remember to replace the values for the variables `resourceGroupName`, `storageAccountName`, `region`, and `storageAccountSku` with the desired values for your storage account deployment.
+To create a storage account for provisioned v2 file shares, use the following command. Remember to replace the values for the variables `resourceGroupName`, `storageAccountName`, `region`, `storageAccountKind`, and `storageAccountSku` with the desired values for your storage account deployment.
 
 ```bash
-resourceGroupName="<my-resource-group>"
-storageAccountName="<my-storage-account-name>"
-region="<my-region>"
+$resourceGroupName="<my-resource-group>"
+$storageAccountName="<my-storage-account-name>"
+$region="<my-region>"
+$storageAccountKind="FileStorage"
 
-# Valid SKUs are StandardV2_LRS (HDD Local provisioned v2), StandardV2_ZRS (HDD 
-# Zone provisioned v2), StandardV2_GRS (HDD Geo provisioned v2), 
-# StandardV2_GZRS (HDD GeoZone provisioned v2)
-storageAccountSku="StandardV2_LRS"
-
-# Note that kind provided is FileStorage. Combining this with a valid selected 
-# SKU will result in an HDD provisioned v2 file share with the selected 
-# redundancy. It is also possible to other types of storage accounts with the 
-# az resource create command, however, we recommend using the az storage account 
-# create command instead.
-storageAccount=$(az resource create \
-        --resource-type "Microsoft.Storage/storageAccounts" \
-        --resource-group $resourceGroupName \
-        --name $storageAccountName \
-        --is-full-object \
-        --properties "{\"location\":\"$region\",\"kind\":\"FileStorage\",\"sku\":{\"name\":\"$storageAccountSku\"},\"properties\":{}}" \
-        --query "id" \
-        --output tsv
-)
+# Valid SKUs for provisioned v2 HDD file share are 'StandardV2_LRS' (HDD Local Pv2), 'StandardV2_GRS' (HDD Geo Pv2), 'StandardV2_ZRS' (HDD Zone Pv2), 'StandardV2_GZRS' (HDD GeoZone Pv2).
+$storageAccountSku="StandardV2_LRS"
+
+az storage account create --resource-group $resourceGroupName --name $storageAccountName --location $region --kind $storageAccountKind --sku $storageAccountSku --output none
 ```
 
 ### Create a provisioned v1 or pay-as-you-go storage account (Azure CLI)
@@ -351,52 +337,23 @@ $f | fl
 ```
 
 # [Azure CLI](#tab/azure-cli)
-You can create an Azure file share with the `az resource create` command. The following commands assume you set the `storageAccount` variable when creating a storage account in the Azure CLI section.
+You can create an Provisioned v2 Azure file share with [`az storage share-rm create`](/cli/azure/storage/share-rm#az-storage-share-rm-create) command. The following PowerShell commands assume you set the variables `resourceGroupName` and `storageAccountName` as defined in the creating a storage account with Azure CLI section.
 
-To create a provisioned v2 file share, use the following command. Remember to replace the values for the variables `shareName`, `provisionedStorageGib`, `provisionedIops`, and `provisionedThroughputMibPerSec` with the desired selections for your file share deployment.
+To create a provisioned v2 file share, use the following command. Remember to replace the values for the variables `shareName`, `provisionedStorageGib` with the desired selections for your file share deployment.
 
 ```bash
-shareName="<file-share>"
+$shareName="<file-share>"
 
-# The provisioned storage size of the share in GiB. Valid range is 32 to 
+# The provisioned storage size of the share in GiB. Valid range is 32 to
 # 262,144.
-provisionedStorageGib=1024
-
-# The provisioned IOPS of the share. This is set to the empty string here to 
-# get the recommended IOPS for the amount of provisioned storage provided, 
-# however, you can override this value if you have detail about how many IOPS 
-# your workload requires.
-provisionedIops=""
-
-# The provisioned throughput in MiB / sec of the share. This is set to null 
-# here to get the recommended throughput for the amount of provisioned storage 
-# provided, however, you can override this value if you have detail about how 
-# much throughput your workload requires.
-provisionedThroughputMibPerSec=""
-
-# Build file share properties JSON.
-fileShareProperties="{\"shareQuota\":$provisionedStorageGib"
-
-if [ ! -z "${provisionedIops}" ]; then
-    fileShareProperties="$fileShareProperties,\"provisionedIops\":"
-    fileShareProperties="$fileShareProperties$provisionedIops"
-fi
-
-if [ ! -z "${provisionedThroughputMibPerSec}" ]; then
-    fileShareProperties="$fileShareProperties,\"provisionedBandwidthMibps\":"
-    fileShareProperties="$fileShareProperties$provisionedThroughputMibPerSec"
-fi
-
-fileShareProperties="$fileShareProperties}"
+$provisionedStorageGib = 1024
 
-# Build resource ID for desired file share
-resourceId="$storageAccount/fileServices/default/shares/$shareName"
+# If you do not specify on the ProvisionedBandwidthMibps and ProvisionedIops, the deployment will use the recommended provisioning.
+$provisionedIops = 3000
+$provisionedThroughputMibPerSec = 130
 
-# Create resource
-az resource create \
-        --id $resourceId \
-        --properties $fileShareProperties \
-        --output none
+az storage share-rm create --resource-group $resourceGroupName --name $shareName --storage-account $storageAccountName --quota $provisionedStorageGib
+# --provisioned-iops $provisionedIops --provisioned-bandwidth-mibps $provisionedThroughputMibPerSec
 ```
 
 ---
@@ -598,74 +555,23 @@ $f | fl
 ```
 
 # [Azure CLI](#tab/azure-cli)
-You can modify a provisioned v2 file share with the `az resource patch` command. Remember to replace the value of variables `resourceGroupName`, `storageAccountName`, `fileShareName`, `provisionedStorageGib`, `provisionedIops`, and `provisionedThroughputMibPerSec` with the correct values for your file share.
+You can modify a provisioned v2 file share with the `az storage share-rm update` command. Remember to replace the values for the variables `resourceGroupName`, `storageAccountName`, `fileShareName`, `provisionedStorageGib`, `provisionedIops`, and `provisionedThroughputMibPerSec` with the desired values for your file share.
 
 ```bash
 # The path to the file share resource to be modified.
 resourceGroupName="<resource-group>"
 storageAccountName="<storage-account>"
 fileShareName="<file-share>"
 
-# The provisioning desired on the file share. Set these values to the empty 
-# string if no change is desired.
-provisionedStorageGib=10240
-provisionedIops=10000
-provisionedThroughputMibPerSec=2048
-
-# Get the resource ID of the storage account
-storageAccount=$(az resource show \
-        --resource-type "Microsoft.Storage/storageAccounts" \
-        --resource-group $resourceGroupName \
-        --name $storageAccountName \
-        --query "id" \
-        --output tsv
-)
-
-# Build the resource ID of the file share
-resourceId="$storageAccount/fileServices/default/shares/$fileShareName"
-
-# Build the properties to be updated for the file share
-fileShareProperties="{"
-
-if [ -z "${provisionedStorageGib}" ]; then
-    provisionedStorageGib=$(az resource show \
-            --ids $resourceId \
-            --query "properties.shareQuota" \
-            --output tsv
-    )
-fi
-
-fileShareProperties="$fileShareProperties\"shareQuota\":"
-fileShareProperties="$fileShareProperties$provisionedStorageGib"
-
-if [ -z "${provisionedIops}" ]; then
-    provisionedIops=$(az resource show \
-            --ids $resourceId \
-            --query "properties.provisionedIops" \
-            --output tsv
-    )
-fi
-
-fileShareProperties="$fileShareProperties,\"provisionedIops\":"
-fileShareProperties="$fileShareProperties$provisionedIops"
-
-if [ -z "${provisionedThroughputMibPerSec}" ]; then
-    provisionedThroughputMibPerSec=$(az resource show \
-            --ids $resourceId \
-            --query "properties.provisionedBandwidthMibps" \
-            --output tsv
-    )
-fi
-
-fileShareProperties="$fileShareProperties,\"provisionedBandwidthMibps\":"
-fileShareProperties="$fileShareProperties$provisionedThroughputMibPerSec"
+# The provisioning desired on the file share. Delete the parameters if no
+# change is desired.
+$provisionedStorageGib = 10240
+$provisionedIops = 10000
+$provisionedThroughputMibPerSec = 2048
 
-fileShareProperties="$fileShareProperties}"
+# Update the file share provisioning.
+az storage share-rm update --resource-group $resourceGroupName --name $shareName --storage-account $storageAccountName --quota $provisionedStorageGib --provisioned-iops $provisionedIops --provisioned-bandwidth-mibps $provisionedThroughputMibPerSec
 
-# Update file share with new provisioning
-az resource patch \
-        --ids $resourceId \
-        --properties $fileShareProperties
 ```
 
 ---