Skip to content

Commit 92417b7

Browse files
committed
more team review
1 parent 6ab9350 commit 92417b7

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

articles/mysql/concepts-performance-recommendations.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ ms.date: 05/23/2019
1414
> [!NOTE]
1515
> Performance Recommendations is in public preview.
1616
17-
The Performance Recommendations feature analyzes your databases to create customized suggestions for improved performance. To produce the recommendations, the analysis looks at various database characteristics including schema. Enable [Query Store](concepts-query-store.md) on your server to fully utilize the Performance Recommendations feature. Turning on Query Store enables performance_schema and a subset of performance schema instruments required for the feature. After implementing any performance recommendation, you should test performance to evaluate the impact of those changes.
17+
The Performance Recommendations feature analyzes your databases to create customized suggestions for improved performance. To produce the recommendations, the analysis looks at various database characteristics including schema. Enable [Query Store](concepts-query-store.md) on your server to fully utilize the Performance Recommendations feature. If performance schema is OFF, turning on Query Store enables performance_schema and a subset of performance schema instruments required for the feature. After implementing any performance recommendation, you should test performance to evaluate the impact of those changes.
1818

1919
## Permissions
2020

@@ -30,7 +30,7 @@ Open **Performance Recommendations** from the **Intelligent Performance** sectio
3030

3131
Select **Analyze** and choose a database, which will begin the analysis. Depending on your workload, the analysis may take several minutes to complete. Once the analysis is done, there will be a notification in the portal. Analysis performs a deep examination of your database. We recommend you perform analysis during off-peak periods.
3232

33-
The **Recommendations** window will show a list of recommendations if any were found.
33+
The **Recommendations** window will show a list of recommendations if any were found and the related query ID that generated this recommendation. With the query ID, you can use the [mysql.query_store](concepts-query-store.md#mysqlquery_store) view to learn more about the query.
3434

3535
![Performance Recommendations new page](./media/concepts-performance-recommendations/performance-recommendations-result.png)
3636

articles/mysql/concepts-query-store.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ The Query Store feature in Azure Database for MySQL provides a way to track quer
1818

1919
## Common scenarios for using Query Store
2020

21-
Query store can be used in a number scenarios, including the following:
21+
Query store can be used in a number of scenarios, including the following:
2222

2323
- Detecting regressed queries
2424
- Determining the number of times a query was executed in a given time window
@@ -50,18 +50,18 @@ Allow up to 20 minutes for the first batch of data to persist in the mysql datab
5050

5151
Query Store has two stores:
5252

53-
- A runtime stats store for persisting the query execution statistics information.
54-
- A wait stats store for persisting wait statistics information.
53+
- A runtime statistics store for persisting the query execution statistics information.
54+
- A wait statistics store for persisting wait statistics information.
5555

56-
To minimize space usage, the runtime execution statistics in the runtime stats store are aggregated over a fixed, configurable time window. The information in these stores is visible by querying the query store views.
56+
To minimize space usage, the runtime execution statistics in the runtime statistics store are aggregated over a fixed, configurable time window. The information in these stores is visible by querying the query store views.
5757

5858
The following query returns information about queries in Query Store:
5959

6060
```sql
6161
SELECT * FROM mysql.query_store;
6262
```
6363

64-
Or this query for wait stats:
64+
Or this query for wait wait statistics:
6565

6666
```sql
6767
SELECT * FROM mysql.query_store_wait_stats;
@@ -90,14 +90,14 @@ The following options are available for configuring Query Store parameters.
9090
| query_store_capture_mode | Turn the query store feature ON/OFF based on the value. Note: If performance_schema is OFF, turning on query_store_capture_mode will turn on performance_schema and a subset of performance schema instruments required for this feature. | ALL | NONE, ALL |
9191
| query_store_capture_interval | The query store capture interval in minutes. Allows specifying the interval in which the query metrics are aggregated | 15 | 5 - 60 |
9292
| query_store_capture_utility_queries | Turning ON or OFF to capture all the utility queries that is executing in the system. | NO | YES, NO |
93-
| query_store_retention_period_in_days | Time window in days to retain the data in the query store| 7 | 1 - 30 |
93+
| query_store_retention_period_in_days | Time window in days to retain the data in the query store. | 7 | 1 - 30 |
9494

9595
The following options apply specifically to wait statistics.
9696

9797
| **Parameter** | **Description** | **Default** | **Range** |
9898
|---|---|---|---|
9999
| query_store_wait_sampling_capture_mode | Allows turning ON / OFF the wait statistics. | NONE | NONE, ALL |
100-
| query_store_wait_sampling_frequency | Alters frequency of wait-sampling in seconds. 5 to 300 seconds. Default is currently 30. | 30 | 5-300 |
100+
| query_store_wait_sampling_frequency | Alters frequency of wait-sampling in seconds. 5 to 300 seconds. | 30 | 5-300 |
101101

102102
> [!NOTE]
103103
> Currently **query_store_capture_mode** supersedes this configuration, meaning both **query_store_capture_mode** and **query_store_wait_sampling_capture_mode** have to be enabled to ALL for wait statistics to work. If **query_store_capture_mode** is turned off, then wait statistics is turned off as well since wait statistics utilizes the performance_schema enabled, and the query_text captured by query store.

0 commit comments

Comments
 (0)