Skip to content

Commit 9252d68

Browse files
authored
Apply suggestions from code review
Acrolinx and related fixes
1 parent e4fe147 commit 9252d68

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

articles/communication-services/concepts/chat/concepts.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Chat conversations happen within **chat threads**. Chat threads have the followi
3636
- Users are added as a participant to any chat threads that they create.
3737

3838
### User access
39-
Azure Communication Services support three levels of user access control, using the chat tokens. See [Identity and Tokens](../identity-model.md) for details. Participants don't have write-access to messages sent by other participants, which means only the message sender can update or delete their sent messages. If another participant tries to do that, they get an error.
39+
Azure Communication Services supports three levels of user access control, using the chat tokens. See [Identity and Tokens](../identity-model.md) for details. Participants don't have write-access to messages sent by other participants, which means only the message sender can update or delete their sent messages. If another participant tries to do that, they get an error.
4040

4141
### Chat Data
4242
Azure Communication Services stores chat messages indefinitely until they are deleted by the customer. Chat thread participants can use `ListMessages` to view message history for a particular thread. Users that are removed from a chat thread are able to view previous message history but can't send or receive new messages. Accidentally deleted messages aren't recoverable by the system. To learn more about data being stored in Azure Communication Services chat service, refer to the [data residency and privacy page](../privacy.md).

articles/communication-services/concepts/identity-model.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ Azure Communication Services is an identity-agnostic service, which offers multi
2222

2323
Azure Communication Services identity model works with two key concepts.
2424

25-
## User Identity / Mapping:
25+
## User identity / mapping
2626
Uniquely identifies a user through a user-identifier, which is generated by Azure Communication Services when a user is created. External identifiers such as phone numbers, users, devices, applications, and GUIDs can't be used for identity in Azure Communication Services. You can create Azure Communication Service user identities for free. Charges are only incurred when the user consumes communications modalities such as a chat or a call. Your users identity can be mapped to Azure Communication Services user Identity in 1:1, 1:N, N:1, N:N configurations. A user can participate in multiple communication sessions, using multiple devices, simultaneously. Mapping between Azure Communication Services user identity and customer's private user identity is kept and maintained by the customer. For example, customers can add a `CommunicationServicesId` column in their user table to store the associated Azure Communication Services identity.
2727

28-
## Access Tokens:
29-
After a user identity is created, a user is granted with the capability to participate in communications using chat or calls, using access tokens. For example, only a user with chat token can participate in chat and user with VoIP token can participate in a VoIP call. A user can have multiple tokens simultaneously. Azure Communication Services support multiple types of tokens to account for users who require full access vs limited access. Access token have following properties.
28+
## Access tokens
29+
After a user identity is created, a user is granted with the capability to participate in communications using chat or calls, using access tokens. For example, only a user with chat token can participate in chat and user with VoIP token can participate in a VoIP call. A user can have multiple tokens simultaneously. Azure Communication Services supports multiple types of tokens to account for users who require full access vs limited access. Access tokens have the following properties.
3030

3131
|Property|Description|
3232
|---|----|
@@ -36,7 +36,7 @@ After a user identity is created, a user is granted with the capability to parti
3636

3737
An access token is a JSON Web Token (JWT) and has integrity protection. That is, its claims can't be changed after it's issued. So a manual change of properties such as identity, expiration, or scopes will invalidate the access token. If primitives are used with invalidated tokens, then access will be denied to the primitives. Azure Communication Services supports the following scopes for access tokens.
3838

39-
## Chat Token Scopes
39+
## Chat token scopes
4040
Three types of chat token scopes are supported. Permissions for each token are described below.
4141
- chat
4242
- chat.join
@@ -60,7 +60,7 @@ Three types of chat token scopes are supported. Permissions for each token are d
6060
|Send typing indicator | Y | Y | Y |
6161
|Get participant for thread ID | Y | Y | Y |
6262

63-
## VoIP Token Scopes
63+
## VoIP token scopes
6464
Two types of VoIP token scopes are supported. Permissions for each token are described below.
6565
- voip
6666
- voip.join
@@ -71,10 +71,10 @@ Two types of VoIP token scopes are supported. Permissions for each token are des
7171
|Start a VoIP call in Virtual Rooms, when the user is already invited to the Room| Y | Y |
7272
|Join an InProgress VoIP call | Y | Y |
7373
|Join an InProgress VoIP call in Virtual Rooms, when the user is already invited to the Room| Y | Y |
74-
|All other in call operations such as mute/unmute, screen share etc. | Y | Y |
75-
|All other in call operations such as mute/unmute, screen share etc. in Virtual Rooms| Y | Determined by user role |
74+
|All other in-call operations such as mute/unmute, screen share etc. | Y | Y |
75+
|All other in-call operations such as mute/unmute, screen share etc. in Virtual Rooms| Y | Determined by user role |
7676

77-
## Revoke or Update access token
77+
## Revoke or update access token
7878
- Azure Communication Services Identity library can be used to revoke an access token before its expiration time. Token revocation isn't immediate. It can take up to 15 minutes to propagate.
7979
- The removal of an identity, resource, or subscription revokes all access tokens.
8080
- If you want to remove a user's ability to access specific functionality, revoke all access tokens. Then issue a new access token that has a more limited set of scopes.

articles/communication-services/concepts/voice-video-calling/calling-sdk-features.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Once you've started development, check out the [known issues page](../known-issu
2222
Key features of the Calling SDK:
2323

2424
- **Addressing** - Azure Communication Services provides generic [identities](../identity-model.md) that are used to address communication endpoints. Clients use these identities to authenticate to the service and communicate with each other. These identities are used in Calling APIs that provide clients visibility into who is connected to a call (the roster).
25-
- **User Accesss Security**
25+
- **User Access Security**
2626
- **Roster** control, **Schedule** control, and user **roles/permissions** are enforced through [Virtual Rooms](../rooms/room-concept.md).
2727
- Ability for a user to **Initiate a new call** or to **Join an existing call** can be managed through [User Identities and Tokens](../identity-model.md)
2828
- **Encryption** - The Calling SDK encrypts traffic and prevents tampering on the wire.

0 commit comments

Comments
 (0)