Skip to content

Commit 9452b54

Browse files
committed
Fix review comments
1 parent be062ab commit 9452b54

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

articles/communication-services/concepts/voice-video-calling/calling-sdk-features.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,12 @@ The following list presents the set of features that are currently available in
102102
| Notifications <sup>4</sup> | [Push notifications](../../how-tos/calling-sdk/push-notifications.md) | ✔️ | ✔️ | ✔️ | ✔️ |
103103

104104
<sup>1</sup> The capability to Mute Others is currently in public preview.
105+
105106
<sup>2</sup> The Share Screen capability can be achieved using Raw Media APIs. To learn more visit [the raw media access quickstart guide](../../quickstarts/voice-video-calling/get-started-raw-media-access.md).
107+
106108
<sup>3</sup> The Calling SDK doesn't have an explicit API for these functions, you should use the Android & iOS OS APIs to achieve instead.
107-
<sup>4</sup> The maximum value for TTL in native platforms, is **180 days (15,552,000 seconds)**, and the min value is **5 minutes (300 seconds)**. For CTE (Custom Teams Endpoint)/M365 indetity the max TTL value is **24 hrs (86,400 seconds)**.
109+
110+
<sup>4</sup> The maximum value for TTL in native platforms, is **180 days (15,552,000 seconds)**, and the min value is **5 minutes (300 seconds)**. For CTE (Custom Teams Endpoint)/M365 Identity the max TTL value is **24 hrs (86,400 seconds)**.
108111

109112
## JavaScript Calling SDK support by OS and browser
110113

@@ -154,7 +157,6 @@ For example, this iframe allows both camera and microphone access:
154157
- Xcode 12.0+
155158
- Support for **iPadOS** 13.0+
156159

157-
158160
## Maximum call duration
159161

160162
**The maximum call duration is 30 hours**, participants that reach the maximum call duration lifetime of 30 hours will be disconnected from the call.

articles/communication-services/how-tos/calling-sdk/push-notifications.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,14 @@ The Time To Live (TTL) token is a setting that determines the length of time a n
2828

2929
The TTL configuration allows the management of push notifications' lifecycle, reducing the need for frequent token renewals while ensuring that the communication channel between the application and its users remains open and reliable for extended durations.
3030

31-
Currently, the maximum value for TTL is **180 days (15,552,000 seconds)**, and the min value is **5 minutes (300 seconds)**. You can enter this value and adjust it accordingly to your needs. In case of not provide a value, the defatult value is **24 hours (86,400 seconds)**.
31+
Currently, the maximum value for TTL is **180 days (15,552,000 seconds)**, and the min value is **5 minutes (300 seconds)**. You can enter this value and adjust it accordingly to your needs. If you don't provide a value, the default value is **24 hours (86,400 seconds)**.
3232

3333
Once the register push notification API is called when the device token information is saved in Registrar. After TTL lifespan ends, the device endpoint information is deleted. Any incoming calls on those devices can't be delivered to the devices if those devices don't call the register push notification API again.
3434

3535
In case that you want to revoke an identity you need to follow [this process](../../concepts/identity-model.md#revoke-or-update-access-token), once the identity is revoked the Registrar entry should be deleted.
3636

37-
Note: For CTE (Custom Teams Endpoint) the max TTL value is **24 hrs (86,400 seconds)** there's no way to increase this value.
37+
[!Note]
38+
For CTE (Custom Teams Endpoint) the max TTL value is **24 hrs (86,400 seconds)** there's no way to increase this value.
3839

3940
## Prerequisites
4041

articles/communication-services/tutorials/add-voip-push-notifications-event-grid.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ ms.author: sanathr
1010
---
1111

1212
# Connect Calling Native Push Notification with Azure Event Grid
13-
1413
With Azure Communication Services, you can receive real-time event notifications in a dependable, expandable, and safe way by integrating it with [Azure Event Grid](https://azure.microsoft.com/services/event-grid/). This integration can be used to build a notification system that sends push notifications to your users on mobile devices. To achieve it, create an Event Grid subscription that triggers an [Azure Function](../../azure-functions/functions-overview.md) or webhook.
1514

1615
:::image type="content" source="../concepts/media/notifications/acs-events-int.png" alt-text="Diagram showing how Communication Services integrates with Event Grid.":::

0 commit comments

Comments
 (0)