Skip to content

Commit 95fa88b

Browse files
authored
Merge pull request #124694 from sdaytelefonicatechuk/patch-1
Corrected typos in deploy-github-actions.md
2 parents d810107 + ff4d905 commit 95fa88b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

articles/azure-resource-manager/bicep/deploy-github-actions.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ Open ID Connect is an authentication method that uses short-lived tokens. Settin
7878
7979
1. Create a service principal. Replace the `$appID` with the appId from your JSON output.
8080
81-
This command generates JSON output with a different `objectId` and will be used in the next step. The new `objectId` is the `assignee-object-id`.
81+
This command generates JSON output with a different `Id` and will be used in the next step. The new `Id` is the `assignee-object-id`.
8282
8383
Copy the `appOwnerTenantId` to use as a GitHub secret for `AZURE_TENANT_ID` later.
8484
@@ -89,12 +89,12 @@ Open ID Connect is an authentication method that uses short-lived tokens. Settin
8989
1. Create a new role assignment by subscription and object. By default, the role assignment is tied to your default subscription. Replace `$subscriptionId` with your subscription ID, `$resourceGroupName` with your resource group name, and `$assigneeObjectId` with the generated `assignee-object-id`. Learn [how to manage Azure subscriptions with the Azure CLI](/cli/azure/manage-azure-subscriptions-azure-cli).
9090
9191
```azurecli-interactive
92-
az role assignment create --role contributor --subscription $subscriptionId --assignee-object-id $assigneeObjectId --assignee-principal-type ServicePrincipal --scopes /subscriptions/$subscriptionId/resourceGroups/$resourceGroupName/providers/Microsoft.Web/sites/
92+
az role assignment create --role contributor --subscription $subscriptionId --assignee-object-id $assigneeObjectId --assignee-principal-type ServicePrincipal --scope /subscriptions/$subscriptionId/resourceGroups/$resourceGroupName
9393
```
9494
9595
1. Run the following command to [create a new federated identity credential](/graph/api/application-post-federatedidentitycredentials?view=graph-rest-beta&preserve-view=true) for your active directory application.
9696
97-
* Replace `APPLICATION-OBJECT-ID` with the **objectId (generated while creating app)** for your Active Directory application.
97+
* Replace `APPLICATION-OBJECT-ID` with the **objectId (of the app registration)** for your Active Directory application.
9898
* Set a value for `CREDENTIAL-NAME` to reference later.
9999
* Set the `subject`. The value of this is defined by GitHub depending on your workflow:
100100
* Jobs in your GitHub Actions environment: `repo:< Organization/Repository >:environment:< Name >`

0 commit comments

Comments
 (0)